The MASM Forum

Projects => MASM32 => Topic started by: hutch-- on August 17, 2014, 01:11:19 AM

Title: Discussion for the 3 editors for MASM32.
Post by: hutch-- on August 17, 2014, 01:11:19 AM
These are the collective tweaks done over the last while, mainly obscure and internal. Just overwrite the existing 3 in the MASM32 directory with these three.

Will have an updated ZIP file shortly.
Title: Re: Updates for the 3 editors for MASM32.
Post by: jj2007 on August 17, 2014, 01:26:08 AM
UniEdit, Open file: the second file type below "All files" looks a bit odd.
Title: Re: Updates for the 3 editors for MASM32.
Post by: hutch-- on August 17, 2014, 01:57:40 AM
I can't duplicate it on either Win7 64 or XP so I don't know why you are getting that effect.
Title: Re: Updates for the 3 editors for MASM32.
Post by: guga on August 17, 2014, 04:01:18 AM
Very very nice toolbar images steve. Where did you got those ? I´m trying to find some pretty images for RosAsm´s toolbar, but no lucky so far. This ones you found are really nice. Do you have the link of them, so i can try to see if they have more that may be usefull ?
Title: Re: Updates for the 3 editors for MASM32.
Post by: Gunther on August 17, 2014, 04:13:29 AM
No problems so far under Windows 7-64. Good job. :t

Gunther
Title: Re: Updates for the 3 editors for MASM32.
Post by: jj2007 on August 17, 2014, 04:31:09 AM
I can't duplicate it on either Win7 64 or XP so I don't know why you are getting that effect.

Tested only on XP, but it shows consistently the same odd symbols. Did you specify two words at the end of the filters?
Title: Re: Updates for the 3 editors for MASM32.
Post by: guga on August 17, 2014, 04:56:18 AM
That´s odd...No Problem here on WinXp Sp3 for qeditor.


On uniedit, i´having the same problem as JJ said.
Title: Re: Updates for the 3 editors for MASM32.
Post by: hutch-- on August 17, 2014, 11:17:31 AM
This is what I have in the unicode RC file in the string table.

900,   "All Files\0*.*\0\0"

I get the string with the unicode version of GetStringW and it displays according to the specification on my XP and Win7 64 boxes but both use US English so there may be a version difference.

Guga,

The fancy icons and toolbar in Uniedit are done with Axialis Icon Workshop, one of the few decent tools I have bought for years. Get the professional version so that you can download all of the icon and image libraries as this gives you a massive range of components to create your own toolbars and icons with. Does nice PNG for web sites as well.
Title: Re: Updates for the 3 editors for MASM32.
Post by: hutch-- on August 17, 2014, 11:52:47 AM
See if this does the job, I added 4 more "\0" to the end of the string in the string table.
Title: Re: Updates for the 3 editors for MASM32.
Post by: jj2007 on August 17, 2014, 12:14:00 PM
Still the same problem.

> I get the string with the unicode version of GetStringW

LoadStringW will probably return one word-sized zero delimiter...

Can you post the relevant lines of code? Here is a test piece.
Code: [Select]
include \masm32\include\masm32rt.inc

.data
buffer db "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX", 0

.code
start:
  mov esi, offset buffer
  invoke LoadStringW, rv(GetModuleHandle, 0), 1, esi, sizeof buffer
  push esi
  .Repeat
lodsb
.if !al
mov byte ptr [esi-1], "_"
.endif
  .Until al=="X"
  pop esi
  invoke MessageBox, 0, esi, 0, MB_OK
  exit

end start

STRINGTABLE
BEGIN
   001,   "All files\0*.*\0\0\0\0\0\0\0\0\0\0\0\0"
END


IMHO it's a big fat bug in LoadString's way to handle C character escapes. Can be "healed" with and dword ptr [esi+2*eax], 0 directly after the LoadStringW invoke.
Title: Re: Updates for the 3 editors for MASM32.
Post by: hutch-- on August 17, 2014, 03:09:03 PM
This one should do it, write the bytes directly to the data section.

This is the change.


            ;;;; mov pbuf1, ptr$(buffer1)
            ;;;; invoke LoadStringW,hInstance,900,pbuf1,260


            mov pbuf1, ptr$(buffer1)
            mov pbuf1, uni$("All Files ....",0,"*.*",0,0)
Title: Re: Updates for the 3 editors for MASM32.
Post by: jj2007 on August 17, 2014, 05:13:30 PM
 :t
Title: Re: Updates for the 3 editors for MASM32.
Post by: hutch-- on August 17, 2014, 07:09:40 PM
Gratsie and thanks for the help, I had no way of testing it. depending on your sense of humour, one can imagine a Microsoft team full of too much good vino translating the US edition into other languages where someone did not understand the finer details and botched it.  :biggrin:
Title: Re: Updates for the 3 editors for MASM32.
Post by: Vortex on August 17, 2014, 08:15:22 PM
Hi Hutch,

Very nice work :t
Title: Re: Discussion for the 3 editors for MASM32.
Post by: guga on September 06, 2014, 09:03:44 AM
Excellent work Steve. Working perfectly now.

Btw, i think i have "Axialis Icon Workshop" here somewhere in my DVDs. ´ll take a look at it. To try building a better toolbar images.
Title: Re: Discussion for the 3 editors for MASM32.
Post by: dedndave on September 06, 2014, 10:55:57 AM
Axialis is nice for icons - but, toolbar buttons aren't always icons
i made these with MS Paint   :P
Title: Re: Discussion for the 3 editors for MASM32.
Post by: hutch-- on September 06, 2014, 01:38:59 PM
Dave,

With IconWorkshop you simply use images, not just icons. Your image strip looks like a 256 colour version and it has come out well but I will bet you it can be done easier and faster in Axialis Iconworkshop as it has a dredicated toolbar strip method built into it. Thats why I bought it in the first place, got tired of doing image strips in MSpaint.
Title: Re: Discussion for the 3 editors for MASM32.
Post by: dedndave on September 07, 2014, 01:56:15 AM
sure - but these were simple ones - lol
and, i am used to Paint - not that it's a great program or anything

btw, it's 16-color   :P
Title: Re: Discussion for the 3 editors for MASM32.
Post by: dedndave on September 07, 2014, 02:02:09 AM
the custom buttons where i use them
i wanted buttons like those offered in .NET, without using .NET   :P