CodeEdit, the Christmas Edition

[zedd151]

Yurp

Hey, I think hutch-- is onto something. 

[jj2007]

Just try this, its a test of the "exist" algo.

entry_point proc
  rcall MessageBox,0,str$(rv(exist, CL$()))," 1 = file exists",MB_OK
  invoke MessageBox, 0, CL$(), chr$("The command line:"), MB_OK

Works like a charm, even with extra long command lines with spaces and apostrophes etc.

Source of CL$() attached, ruthless stolen from MasmBasic and minimally modified for use with the Masm64 SDK

[hutch--]

Converted the test piece to console so the results can be directly posted.

; ¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤

    include \masm64\include64\masm64rt.inc

    .code

; ¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤

entry_point proc

    LOCAL clp :QWORD                                    ; command line pointer
    LOCAL rvl :QWORD

    call GetCommandLine
    mov clp, rax

    conout "----------------",lf
    conout "Raw command line",lf
    conout "----------------",lf
    conout clp,lf,lf

    mov clp, rvcall(cmd_tail)

    conout "----------------",lf
    conout "Command tail",lf
    conout "----------------",lf
    conout clp,lf,lf

    conout "----------------",lf
    conout "Testing 'exist'",lf
    conout "----------------",lf

    rcall exist,clp,lf
    conout str$(rax),lf

    waitkey

    .exit

entry_point endp

; ¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤

    end


This is the result on my Win10 64 Pro.

----------------
Raw command line
----------------
"K:\masm64_00\TestCL\TestCL.exe" K:\masm64_00\TestCL\TestCL.obj

----------------
Command tail
----------------
K:\masm64_00\TestCL\TestCL.obj

----------------
Testing 'exist'
----------------
1
Press any key to continue...

[hutch--]

Run directly from the console.

K:\masm64_00\TestCL>testcl makeit.bat
----------------
Raw command line
----------------
testcl  makeit.bat

----------------
Command tail
----------------
makeit.bat

----------------
Testing 'exist'
----------------
1
Press any key to continue...

[HSE]

Run directly from the console.

Never was a problem to run program from command line  .

Problem is to run program from explorer (like how is usual with qEditor).

[jj2007]

Converted the test piece to console so the results can be directly posted.

Doesn't work. Try my (very simple) code above to see the difference.

Hint: It works fine, of course, with e.g. C:\Masm32\QEditor.exe; but it fails with any path that has a space, because Windows has the bad habit of adding "quotes"

[hutch--]

Could you run the last example, I don't have anything as old as Win7 running but I need to see if the full command line returned by GetCommandLine() still has the second half quoted. On my Win10 64 Pro, it is returned without quotes.

jj,

I am trying to track down a variation between Win10-11 and old OS versions, not looking for someone elses code.

[hutch--]

As I still don't know what is happening win win7, try this.

    call cmd_tail                   ; get command tail
    mov pFile, rax                  ; store rax in variable
    cmp BYTE PTR [rax], 0           ; test if its empty
    je rfout                        ; bypass loading file if empty

    rcall szRemove,pFile,pFile,chr$(34)        ; < add this line

    rcall exist,pFile               ; check if file exists
    test rax, rax
    jnz @F

[jj2007]

jj,

I am trying to track down a variation between Win10-11 and old OS versions, not looking for someone elses code.

There is no difference between Win7 and Win10 for Explorer's habit to add quotes, but I can't speak for Win11.

[HSE]

It's not an OS problem, just explorer sorround strings with quotes.

From explorer:

Code: [Select]

----------------
Raw command line
----------------
"D:\masm32\projects\CodeEditEx\test\test.exe" "D:\masm32\projects\CodeEditEx\test\test.asm"

----------------
Command tail
----------------
"D:\masm32\projects\CodeEditEx\test\test.asm"

----------------
Testing 'exist'
----------------
0
Press any key to continue...

From command prompt:

Code: [Select]

----------------
Raw command line
----------------
test  test.asm

----------------
Command tail
----------------
test.asm

----------------
Testing 'exist'
----------------
1
Press any key to continue...
From explorer, removing quotes:

Code: [Select]

    mov clp, rvcall(cmd_tail)
    rcall szRemove,clp,clp,chr$(34)        ; < add this line


Code: [Select]

----------------
Raw command line
----------------
"D:\masm32\projects\CodeEditEx\test\test.exe" "D:\masm32\projects\CodeEditEx\test\test.asm"

----------------
Command tail
----------------
D:\masm32\projects\CodeEditEx\test\test.asm

----------------
Testing 'exist'
----------------
1
Press any key to continue...


[zedd151]

As I still don't know what is happening win win7, try this.

    call cmd_tail                   ; get command tail
    mov pFile, rax                  ; store rax in variable
    cmp BYTE PTR [rax], 0           ; test if its empty
    je rfout                        ; bypass loading file if empty

    rcall szRemove,pFile,pFile,chr$(34)        ; < add this line

    rcall exist,pFile               ; check if file exists
    test rax, rax
    jnz @F

  where's the rest of the code, or where to insert this?

Continued below...

[zedd151]

Okay, I inserted that code into CodeEditEx (Duh! I totally spaced out there, looking in the test code for where to insert)


Yurp! it works ok Windows 7 64 bit. 


excerpt from the modified CodeEditEx.asm
---------------------------------------------------------------
  ; --------------------------------------
  ; load file from command line if present
  ; --------------------------------------


    call cmd_tail                   ; get command tail
    mov pFile, rax                  ; store rax in variable
    cmp BYTE PTR [rax], 0           ; test if its empty
    je rfout                        ; bypass loading file if empty


    rcall szRemove,pFile,pFile,chr$(34)        ; < add this line


    rcall exist,pFile               ; check if file exists
    test rax, rax
    jnz @F
;  ...  code continues ...


-------------------------------------------------------------------------------------
Now will it work with spaces in the path? 


edited for paste error... whoops 

[hutch--]

Seems like its OS difference with older OS versions. If stripping quotes works, the problem is solved for old OS versions. One of the joys you get used to is function variation from one OS version to the next. 

[zedd151]

Seems like its OS difference with older OS versions.

All's well that ends well.    At least it didn't have to wait until next Christmas to be ready. 

[jj2007]

I made some tests with this code (attached, with test files):

Code: [Select]

include \masm64\include64\masm64rt.inc
.code
entry_point proc
  invoke GetCommandLine
  conout rax
  invoke MessageBox, 0, rv(GetCommandLine), chr$("GetCommandLine:"), MB_OK
  .exit
entry_point endp
end
Results:

a) Windows XP:

Code: [Select]

"C:\Masm64\Examples\ShowTheRawCommandLine.exe" "C:\Masm64\Examples\test with space.txt"
"C:\Masm64\Examples\ShowTheRawCommandLine.exe" C:\Masm64\Examples\test.txt
b) Windows 7-64:

Code: [Select]

"C:\Masm64\Examples\ShowTheRawCommandLine.exe" "C:\Masm64\Examples\test with space.txt"
"C:\Masm64\Examples\ShowTheRawCommandLine.exe" C:\Masm64\Examples\test.txt
c) Windows 10:

Code: [Select]

"C:\Masm64\Examples\ShowTheRawCommandLine.exe" "C:\Masm64\Examples\test with space.txt"
"C:\Masm64\Examples\ShowTheRawCommandLine.exe" C:\Masm64\Examples\test.txt
Unfortunately, I don't have a Win-11 machine at hand - can somebody test it, please?