Discussion for the 3 editors for MASM32.

[hutch--]

These are the collective tweaks done over the last while, mainly obscure and internal. Just overwrite the existing 3 in the MASM32 directory with these three.

Will have an updated ZIP file shortly.

[jj2007]

UniEdit, Open file: the second file type below "All files" looks a bit odd.

[hutch--]

I can't duplicate it on either Win7 64 or XP so I don't know why you are getting that effect.

[guga]

Very very nice toolbar images steve. Where did you got those ? I´m trying to find some pretty images for RosAsm´s toolbar, but no lucky so far. This ones you found are really nice. Do you have the link of them, so i can try to see if they have more that may be usefull ?

[Gunther]

No problems so far under Windows 7-64. Good job. :t

Gunther

[jj2007]

I can't duplicate it on either Win7 64 or XP so I don't know why you are getting that effect.

Tested only on XP, but it shows consistently the same odd symbols. Did you specify two words at the end of the filters?

[guga]

That´s odd...No Problem here on WinXp Sp3 for qeditor.


On uniedit, i´having the same problem as JJ said.

[hutch--]

This is what I have in the unicode RC file in the string table.

900,   "All Files\0*.*\0\0"

I get the string with the unicode version of GetStringW and it displays according to the specification on my XP and Win7 64 boxes but both use US English so there may be a version difference.

Guga,

The fancy icons and toolbar in Uniedit are done with Axialis Icon Workshop, one of the few decent tools I have bought for years. Get the professional version so that you can download all of the icon and image libraries as this gives you a massive range of components to create your own toolbars and icons with. Does nice PNG for web sites as well.

[hutch--]

See if this does the job, I added 4 more "\0" to the end of the string in the string table.

[jj2007]

Still the same problem.

> I get the string with the unicode version of GetStringW

LoadStringW will probably return one word-sized zero delimiter...

Can you post the relevant lines of code? Here is a test piece.

Code: [Select]

include \masm32\include\masm32rt.inc

.data
buffer db "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX", 0

.code
start:
  mov esi, offset buffer
  invoke LoadStringW, rv(GetModuleHandle, 0), 1, esi, sizeof buffer
  push esi
  .Repeat
lodsb
.if !al
mov byte ptr [esi-1], "_"
.endif
  .Until al=="X"
  pop esi
  invoke MessageBox, 0, esi, 0, MB_OK
  exit

end start
STRINGTABLE
BEGIN
   001,   "All files\0*.*\0\0\0\0\0\0\0\0\0\0\0\0"
END

IMHO it's a big fat bug in LoadString's way to handle C character escapes. Can be "healed" with and dword ptr [esi+2*eax], 0 directly after the LoadStringW invoke.

[hutch--]

This one should do it, write the bytes directly to the data section.

This is the change.


            ;;;; mov pbuf1, ptr$(buffer1)
            ;;;; invoke LoadStringW,hInstance,900,pbuf1,260


            mov pbuf1, ptr$(buffer1)
            mov pbuf1, uni$("All Files ....",0,"*.*",0,0)

[jj2007]

 :t

[hutch--]

Gratsie and thanks for the help, I had no way of testing it. depending on your sense of humour, one can imagine a Microsoft team full of too much good vino translating the US edition into other languages where someone did not understand the finer details and botched it. 

[Vortex]

Hi Hutch,

Very nice work :t

[guga]

Excellent work Steve. Working perfectly now.

Btw, i think i have "Axialis Icon Workshop" here somewhere in my DVDs. ´ll take a look at it. To try building a better toolbar images.