News:

Masm32 SDK description, downloads and other helpful links
Message to All Guests

Main Menu

Is this ugly coding?

Started by minor28, November 06, 2014, 03:01:21 AM

Previous topic - Next topic

qWord

Quote from: minor28 on November 07, 2014, 08:58:19 AMMy question remains. Is this ugly coding?
It is (bad style) programming.
MREAL macros - when you need floating point arithmetic while assembling!

Gunther

Quote from: qWord on November 07, 2014, 10:22:49 PM
It is (bad style) programming.

that's a bit exaggerated. But it's bad style. That's right.

Gunther
You have to know the facts before you can distort them.

Zen

MINOR28,
...At least you're not getting death threats,...
That's when you can be certain that your code is ugly,...
Zen

Magnum

Quote from: minor28 on November 06, 2014, 04:22:24 AM
It is an existing dll function that I use in some of my programs. Now I update this function and I need an additional parameter without having to modify the applications that already use it.

What does your solar calculations do ?

Solar calculations is a stand alone application to calculate solar data
on choosen places and choosen times.
Take care,
                   Andy

Ubuntu-mate-18.04-desktop-amd64

http://www.goodnewsnetwork.org

minor28

Solar calculations. Click on a place on the google maps and the latitude, longitude, time zone, daylight saving time, time, solar elevation and solar azimuth can be read on that place. I have an updated version not published yet.

Ugly was perhaps not the right word to use. I suppose it would have been "bad style". I had a feeling that it was not a common way to code, hence my question. I will take qWord's suggestion and write a new function.

Thank you

Vortex

Hi minor28,

No worries and no ugliness. With some modifications, your code will be fine. You mentioned about Solar calculations. Keep up the good work.