Hi, can anyone explain to me why it does not work ?
A code below is a part of wm_paint processing.
;---------------------------
mov EAX,IDI_APPLICATION
push EAX
xor EAX,EAX
push EAX
call LoadIcon
;---------------------------
push EAX
mov EAX,10;Y
push EAX
mov EAX,1;X
push EAX
push [EBP+@HDC]
call DrawIcon ; <--- here works fine !!!
;---------------------------
mov EAX,0
push EAX ;fuLoad
mov EAX,10h ;y height
push EAX ;cyDesired
mov EAX,10h ;x width
push EAX ;cxDesired
mov EAX,IMAGE_ICON
push EAX ;uType
mov EAX,OIC_WINLOGO
push EAX ;lpszName
xor EAX,EAX
push EAX ;hinst
call LoadImage ; <------ here returns NULL --- WHY ?
;---------------------------
push EAX
mov EAX,200;Y
push EAX
mov EAX,1;X
push EAX
push [EBP+@HDC]
call DrawIcon ; <---- then here is nothing too
The only things that jump out at me on first looking at this are you assigning values to the
cxDesired and
cyDesired parameters. According to MSDN:
Quote
cxDesired [in]
The width, in pixels, of the icon or cursor. If this parameter is zero and the fuLoad parameter is LR_DEFAULTSIZE, the function uses the SM_CXICON or SM_CXCURSOR system metric value to set the width. If this parameter is zero and LR_DEFAULTSIZE is not used, the function uses the actual resource width.
Since you're setting the
fuLoad parameter to zero, have you tried using zero for these?
GetLastError after call DrawIcon returns what?
Here's my self-contained routine that shows the last error. Very handy.
;====================================================================
; Displays last Windows system error (assuming there was one), using
; GetLastError(). Formats message and displays it using MessageBox().
;
; Returns last error code.
;====================================================================
ShowLastError PROC
LOCAL buffer[256]:BYTE
CALL GetLastError
MOV EDX, EAX
PUSH EAX
INVOKE FormatMessage, FORMAT_MESSAGE_FROM_SYSTEM or FORMAT_MESSAGE_IGNORE_INSERTS,
NULL, EDX, 0, ADDR buffer, SIZEOF buffer, NULL
INVOKE MessageBox, 0, ADDR buffer, NULL, MB_OK
POP EAX
RET
ShowLastError ENDP
Quote from: jj2007 on August 01, 2022, 09:51:17 AM
GetLastError after call DrawIcon returns what?
I add call GetLastError after call LoadImage it returns 0 and after call DrawIcon it returns 0 too. I watch it in ollydbg.
Without seeing complete code, I can't tell you what's wrong.
Hi Rockphorr,
you have to use LR_SHARED (0x00008000) for the fuLoad parameter since you try to load a system icon.
Quote from: Greenhorn on August 01, 2022, 09:58:05 PM
Hi Rockphorr,
you have to use LR_SHARED (0x00008000) for the fuLoad parameter since you try to load a system icon.
I add it. There is no effect.
See a full asm source below please.
Quote from: jj2007 on August 01, 2022, 09:55:19 PM
Without seeing complete code, I can't tell you what's wrong.
Ok! Here it is. See attachment.
mov eax, 7F05 ; <--- resource ID??? but no resource file
That is what I see...
Should be 2 icons in the window, correct?
Shows standard application icon and nothing further. Upon calling LoadImage for the second icon, "ERROR_RESOURCE_DATA_NOT_FOUND" reported by olly
ok I see.. 7F05 == OIC_WINLOGO
But LoadImage doesnt seem to know what that is
I then tried:
mov EAX, IDI_WINLOGO ;; which apparently is the same as OIC_WINLOGO
push EAX ;lpszName
mov EAX, hInstance
push EAX ;hinst
call LoadIcon
with the same result...
Windows 7 32 bit here btw
I would be tempted then to extract the wanted icon to file and create a resource file for it and do it that way. Unless there is something we are both not seeing
Quote from: quarantined on August 02, 2022, 04:04:57 AM
mov eax, 7F05 ; <--- resource ID??? but no resource file
That is what I see...
Should be 2 icons in the window, correct?
Shows standard application icon and nothing further. Upon calling LoadImage for the second icon, "ERROR_RESOURCE_DATA_NOT_FOUND" reported by olly
ok I see.. 7F05 == OIC_WINLOGO
But LoadImage doesnt seem to know what that is
I then tried:
mov EAX, IDI_WINLOGO
push EAX ;lpszName
mov EAX, hInstance
push EAX ;hinst
call LoadIcon
with the same result...
Windows 7 32 bit here btw
I would be tempted then to extract the wanted icon to file and create a resource file for it and do it that way. Unless there is something we are both not seeing
Yes, should be 2 icons in the window.
IDI_WINLOGO and OIC_WINLOGO are just the same value.
I use win95osr2 and ollydbg110, I cann't see "ERROR_RESOURCE_DATA_NOT_FOUND", my screenshot is in attachment.
mov EAX,IDI_APPLICATION
push EAX
; xor EAX,EAX
push hInstance ; <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
call LoadIcon
;---------------------------
push EAX
mov EAX,10;Y
push EAX
mov EAX,1;X
push EAX
push hdc
call DrawIcon
Better:
;---------------------------
push IDI_APPLICATION
push hInstance
call LoadIcon
;---------------------------
push EAX
push 10 ; Y
push 1 ; X
push hdc
call DrawIcon
;---------------------------
Even better:
;---------------------------
invoke LoadIcon, hInstance, IDI_APPLICATION
;---------------------------
invoke DrawIcon, hdc, 1, 10, eax
;---------------------------
Efficient:
invoke DrawIcon, hdc, 1, 10, rv(LoadIcon, hInstance, IDI_APPLICATION)
And, of course, IDI_APPLICATION is useless if there is no IDI_APPLICATION icon resource.
jj, IDI_APPLICATION works fine.
Its IDI_WINLOGO that does not work
My screenshot in zip
Quote from: jj2007 on August 02, 2022, 04:22:02 AM
mov EAX,IDI_APPLICATION
push EAX
; xor EAX,EAX
push hInstance ; <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
call LoadIcon
;---------------------------
push EAX
mov EAX,10;Y
push EAX
mov EAX,1;X
push EAX
push hdc
call DrawIcon
Better:
;---------------------------
push IDI_APPLICATION
push hInstance
call LoadIcon
;---------------------------
push EAX
push 10 ; Y
push 1 ; X
push hdc
call DrawIcon
;---------------------------
Even better:
;---------------------------
invoke LoadIcon, hInstance, IDI_APPLICATION
;---------------------------
invoke DrawIcon, hdc, 1, 10, eax
;---------------------------
Efficient:
invoke DrawIcon, hdc, 1, 10, rv(LoadIcon, hInstance, IDI_APPLICATION)
And, of course, IDI_APPLICATION is useless if there is no IDI_APPLICATION icon resource.
jj2007 thank you for your help, but it is not a problem. A problem is null handle that LoadImage rerurns.
Quote from: quarantined on August 02, 2022, 03:49:11 AM
mov eax, 7F05 ; <--- resource ID??? but no resource file
That is what I see...
Should be 2 icons in the window, correct?
Shows standard application icon and nothing further. Upon calling LoadImage for the second icon, "ERROR_RESOURCE_DATA_NOT_FOUND" reported by olly
Indeed. But this line works perfectly:
invoke DrawIcon, hdc, 100, 100, rv(LoadImage, hInstance, IDI_APPLICATION, IMAGE_ICON, 0, 0, LR_SHARED)
Quote from: Rockphorr on August 02, 2022, 04:35:55 AMjj2007 thank you for your help, but it is not a problem. A problem is null handle that LoadImage rerurns.
Use this:
invoke DrawIcon, hdc, 100, 100, rv(LoadImage, hInstance, IDI_APPLICATION, IMAGE_ICON, 0, 0, LR_SHARED)
Quote
Indeed. But this line works perfectly:
invoke DrawIcon, hdc, 100, 100, rv(LoadImage, hInstance, IDI_APPLICATION, IMAGE_ICON, 0, 0, LR_SHARED)
Yes of course it does. BUT IDI_APPLICATION does work, even with LoadImage. He is trying to display OIC_WINLOGO (with LoadImage) doesn't work. Also IDI_WINLOGO does not work with LoadIcon either.
The application in his zip should be displaying two images, but the second (OIC_WINLOGO or IDI_WINLOGO) returns the error and ultimately fails. That is the problem. NOT WITH IDI_APPLICATION which works with LoadImage as well as with LoadIcon. Hope you understand this better now.
Quote from: jj2007 on August 02, 2022, 05:00:34 AM
Quote from: Rockphorr on August 02, 2022, 04:35:55 AMjj2007 thank you for your help, but it is not a problem. A problem is null handle that LoadImage rerurns.
Use this:
invoke DrawIcon, hdc, 100, 100, rv(LoadImage, hInstance, IDI_APPLICATION, IMAGE_ICON, 0, 0, LR_SHARED)
paint.asm(119) : error A2136: too many arguments to INVOKE
paint.asm(119) : error A2006: undefined symbol : rv
paint.asm(119) : error A2114: INVOKE argument type mismatch : argument : 4
What .inc is need ?
Quote from: Rockphorr on August 02, 2022, 03:06:25 AM
Quote from: Greenhorn on August 01, 2022, 09:58:05 PM
Hi Rockphorr,
you have to use LR_SHARED (0x00008000) for the fuLoad parameter since you try to load a system icon.
I add it. There is no effect.
See a full asm source below please.
Try this.
;---------------------------
mov EAX,LR_SHARED or LR_DEFAULTSIZE
push EAX ;fuLoad
mov EAX,0h ;y height - if set to zero LR_DEFAULTSIZE must be set in fuLoad
push EAX ;cyDesired
mov EAX,0h ;x width - if set to zero LR_DEFAULTSIZE must be set in fuLoad
push EAX ;cxDesired
mov EAX,IMAGE_ICON
push EAX ;uType
mov EAX,OIC_WINLOGO
push EAX ;lpszName
xor EAX,EAX ; must be zero if lpszName is a system resource
push EAX ;hinst
call LoadImage
;---------------------------
Quote from: Greenhorn on August 02, 2022, 05:51:02 AM
Quote from: Rockphorr on August 02, 2022, 03:06:25 AM
Quote from: Greenhorn on August 01, 2022, 09:58:05 PM
Hi Rockphorr,
you have to use LR_SHARED (0x00008000) for the fuLoad parameter since you try to load a system icon.
I add it. There is no effect.
See a full asm source below please.
Try this.
;---------------------------
mov EAX,LR_SHARED or LR_DEFAULTSIZE
push EAX ;fuLoad
mov EAX,0h ;y height - if set to zero LR_DEFAULTSIZE must be set in fuLoad
push EAX ;cyDesired
mov EAX,0h ;x width - if set to zero LR_DEFAULTSIZE must be set in fuLoad
push EAX ;cxDesired
mov EAX,IMAGE_ICON
push EAX ;uType
mov EAX,OIC_WINLOGO
push EAX ;lpszName
xor EAX,EAX ; must be zero if lpszName is a system resource
push EAX ;hinst
call LoadImage
;---------------------------
i've tried it. A result is 1st icon only.
Don't know if this will help, but you can try it:
Run the attached program which displays (or is supposed to, anyhow) all the stock system icons. See if the icon you want shows up. (Look at the attached JPG to see what shows up on my computer for comparison.)
Maybe that icon isn't available on your system for some reason?
You are setting hInstance to 0 - or more accurately you are setting the parameter that requires hInst to 0. Try passing hInst / hInstance instead
or use GetModuleHandle, NULL and pass that value to the hInst / hInstance parameter of the LoadImage
Quote from: fearless on August 02, 2022, 07:20:04 AM
You are setting hInstance to 0 - or more accurately you are setting the parameter that requires hInst to 0. Try passing hInst / hInstance instead
or use GetModuleHandle, NULL and pass that value to the hInst / hInstance parameter of the LoadImage
hInstance must be zero if lpszName is a system resource
From Win32.hlp:
The LoadImage function loads an icon, cursor, or bitmap.
HANDLE LoadImage(
HINSTANCE hinst, // handle of the instance that contains the image
LPCTSTR lpszName, // name or identifier of image
UINT uType, // type of image
int cxDesired, // desired width
int cyDesired, // desired height
UINT fuLoad // load flags
);
Parameters
hinst
Identifies an instance of the module that contains the image to be loaded. To load an OEM image, set this parameter to zero.
Quote
IDI_WINLOGO
MAKEINTRESOURCE(32517) | Default application icon.
Windows 2000: Windows logo icon. |
So, IDI_WINLOGO = OIC_WINLOGO = 32517 should load the default application icon and it works for me.
Quote from: quarantined on August 02, 2022, 05:03:42 AMthe second (OIC_WINLOGO or IDI_WINLOGO) returns the error and ultimately fails. That is the problem. NOT WITH IDI_APPLICATION which works with LoadImage as well as with LoadIcon. Hope you understand this better now.
I perfectly understand this. But unless your OS is Windows 2000, IDI_WINLOGO won't work. Unless, of course... :tongue:
QuoteLoadIconA (https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-loadicona)
IDI_APPLICATION
MAKEINTRESOURCE(32512)
Default application icon.
...
IDI_WINLOGO
MAKEINTRESOURCE(32517)
Default application icon.
Windows 2000: Windows logo icon.
Quote from: jj2007 on August 02, 2022, 08:30:09 AM
Quote from: quarantined on August 02, 2022, 05:03:42 AMthe second (OIC_WINLOGO or IDI_WINLOGO) returns the error and ultimately fails. That is the problem. NOT WITH IDI_APPLICATION which works with LoadImage as well as with LoadIcon. Hope you understand this better now.
I perfectly understand this. But unless your OS is Windows 2000, IDI_WINLOGO won't work.
QuoteLoadIconA (https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-loadicona)
IDI_APPLICATION
MAKEINTRESOURCE(32512)
Default application icon.
...
IDI_WINLOGO
MAKEINTRESOURCE(32517)
Default application icon.
Windows 2000: Windows logo icon.
It seems that it is bypassed to the default application icon. The resource ID of the icon in user32.dll is 100.
LoadImage with IDI_WINLOGO loads the default application icon.
Quote from: jj2007 on August 02, 2022, 08:30:09 AM
I perfectly understand this. But unless your OS is Windows 2000, IDI_WINLOGO won't work. Unless, of course... :tongue:
Aha! You've found the missing link. I knew their had to be a (sort of) reasonable explanation to this. :toothy:
I guess I just learnt something today.
I forget, who here still uses Windows 2000 to test this?
Quote from: quarantined on August 02, 2022, 08:43:47 AMAha! You've found the missing link. I knew their had to be a (sort of) reasonable explanation to this. :toothy:
There is one, and it is fairly simple. The exe I posted above (paint.zip) works fine, it shows two icons, one loaded with IDI_APPLICATION, the other with IDI_WINLOGO:
invoke DrawIcon, hdc, 10, 1, rv(LoadImage, hInstance, IDI_APPLICATION, IMAGE_ICON, 0, 0, LR_SHARED)
invoke DrawIcon, hdc, 100, 100, rv(LoadImage, hInstance, IDI_WINLOGO, IMAGE_ICON, 0, 0, LR_SHARED)So, why does it work? Simply because
I loaded the respective resources:
#include "resource.h"
IDI_APPLICATION ICON "\\Masm32\\MasmBasic\\icons\\Smiley.ico"
IDI_WINLOGO ICON "\\Masm32\\MasmBasic\\icons\\Globe.ico"
01 RT_MANIFEST "\\Masm32\\MasmBasic\\Res\\XpManifest.xml"OP posts a snippet. After a while, he understands that complete code is needed. But he does not provide the RC file, or the required icons. Besides, he is a member of the Bare Metal Heros Club, alias the push push call brigade, so that his code is almost unreadable. All that adds together, and the result is chaos and confusion.
push EAX
mov EAX,10;Y
push EAX
mov EAX,1;X
push EAX
push hdc
call DrawIconWhen will he realise that
mov eax, 1
push eaxis just an unnecessary "verbose" way of doing
push 1?
When will he realise that in MASM you simply use invoke DrawIcon, hdc, 1, 10, eax?
Yes, JJ (although you got off on quite a tangent there in your criticism! even though I happen to agree with you: Just use INVOKE (fn), fer chrissakes!).
I just tried this (in Olly debug, didn't actually display it) and it worked (under Windows 7)--came back with a non-zero result, which must be a handle to the icon:
; Test LoadIcon():
INVOKE LoadIcon, NULL, IDI_WINLOGO
Try it.
invoke DrawIcon, hdc, 10, 10, rv(LoadIcon, hInstance, IDI_APPLICATION)
invoke DrawIcon, hdc, 50, 10, rv(LoadImage, hInstance, IDI_WINLOGO, IMAGE_ICON, 0, 0, LR_SHARED)
Works perfect, but I doubt that you see these icons when using 0 instead of hInstance. Here on Win7 it just shows then a boring default icon :cool:
Btw the use of NULL instead of hInstance makes also the WinMain LoadIcon fail:
invoke LoadIcon, hInst, 123 ; with NULL, you only get the boring grey default icon
mov wc.hIcon,eax
mov wc.hIconSm,eax
Wellll, you can't use your module's instance handle with LoadIcon() when loading standard icons as you wrote above; throws an error. Proven with the attached li'l app.
Doing the recommended thing (passing NULL for the instance handle) works fine.
Missing:
- the rc file
- the icon files
- my_masm32rt.inc
*** LoadIcon test.rc not found, will try rsrc.rc ***
*** Assemble, link and run LoadIcon test ***
*** Assemble using UAsm64 ***
Tmp_File.asm(7) : Error A2106: Cannot open file: "\masm32\include\my_masm32rt.inc" [ENOENT]
Tmp_File.asm(14) : Error A2091: Language type must be specified
Tmp_File.asm(67) : Error A2210: Syntax error: WC
Tmp_File.asm(70) : Error A2082: Must be in segment block
Tmp_File.asm(72) : Error A2082: Must be in segment block
Tmp_File.asm(74) : Error A2082: Must be in segment block
Tmp_File.asm(75) : Error A2082: Must be in segment block
Tmp_File.asm(77) : Error A2082: Must be in segment block
Tmp_File.asm(79) : Error A2082: Must be in segment block
Tmp_File.asm(80) : Error A2082: Must be in segment block
Tmp_File.asm(88) : Error A2210: Syntax error: MainWinHandle
Tmp_File.asm(90) : Error A2210: Syntax error: StatusHandle
Tmp_File.asm(91) : Error A2082: Must be in segment block
Tmp_File.asm(93) : Error A2210: Syntax error: S1Handle
Tmp_File.asm(94) : Error A2210: Syntax error: S2Handle
Tmp_File.asm(96) : Error A2210: Syntax error: NullInstIconHandle
Tmp_File.asm(97) : Error A2210: Syntax error: InstIconHandle
Tmp_File.asm(106) : Error A2082: Must be in segment block
Tmp_File.asm(107) : Error A2082: Must be in segment block
Tmp_File.asm(109) : Error A2178: Too many arguments to INVOKE
Tmp_File.asm(110) : Error A2160: INVOKE requires prototype for procedure
Tmp_File.asm(117) : Error A2082: Must be in segment block
Tmp_File.asm(118) : Error A2092: PROC, MACRO or macro loop directive must precede LOCAL
Tmp_File.asm(122) : Error A2160: INVOKE requires prototype for procedure
Tmp_File.asm(123) : Error A2082: Must be in segment block
Tmp_File.asm(126) : Error A2082: Must be in segment block
Tmp_File.asm(127) : Error A2082: Must be in segment block
Tmp_File.asm(128) : Error A2082: Must be in segment block
Tmp_File.asm(129) : Error A2082: Must be in segment block
Tmp_File.asm(132) : Error A2082: Must be in segment block
Tmp_File.asm(133) : Error A2160: INVOKE requires prototype for procedure
Tmp_File.asm(134) : Error A2082: Must be in segment block
Tmp_File.asm(135) : Error A2160: INVOKE requires prototype for procedure
Tmp_File.asm(137) : Error A2160: INVOKE requires prototype for procedure
Tmp_File.asm(138) : Error A2082: Must be in segment block
Tmp_File.asm(139) : Error A2082: Must be in segment block
Tmp_File.asm(140) : Error A2082: Must be in segment block
Tmp_File.asm(141) : Error A2160: INVOKE requires prototype for procedure
Tmp_File.asm(142) : Error A2082: Must be in segment block
Tmp_File.asm(143) : Error A2082: Must be in segment block
Tmp_File.asm(144) : Error A2082: Must be in segment block
Tmp_File.asm(149) : Error A2160: INVOKE requires prototype for procedure
Tmp_File.asm(150) : Error A2082: Must be in segment block
Tmp_File.asm(153) : Error A2160: INVOKE requires prototype for procedure
Tmp_File.asm(154) : Error A2082: Must be in segment block
Tmp_File.asm(155) : Error A2082: Must be in segment block
Tmp_File.asm(157) : Error A2160: INVOKE requires prototype for procedure
Tmp_File.asm(158) : Error A2082: Must be in segment block
Tmp_File.asm(159) : Error A2082: Must be in segment block
Tmp_File.asm(160) : Error A2082: Must be in segment block
Tmp_File.asm(163) : Error A2160: INVOKE requires prototype for procedure
Tmp_File.asm(163) : Fatal error A1113: Too many errors
*** Assembly error ***
Damnit. Sorry 'bout that. I keep forgetting to change my personal include file ("my_masm32rt.inc") to the generic one everyone else here uses. Attachment above fixed.
So JJ, what's with those .asc files in your zips? Is that the source file as used by your editor? Why would we want that file, when we have the .asm file?
No resources needed loading by that program; just uses LoadIcon, NULL, IDI_WINLOGO. Works.
Quote from: NoCforMe on August 02, 2022, 11:13:14 AM
Damnit. Sorry 'bout that. I keep forgetting to change my personal include file ("my_masm32rt.inc") to the generic one everyone else here uses. Attachment above fixed.
OK, now it assembles :thumbsup:
QuoteSo JJ, what's with those .asc files in your zips? Is that the source file as used by your editor? Why would we want that file, when we have the .asm file?
You can open them in WordPad (C:\Windows\System32\write.exe).
QuoteNo resources needed loading by that program; just uses LoadIcon, NULL, IDI_WINLOGO. Works.
It "works" because Windows gives you that ugly grey default icon that dates back to MS DOS times. Below you can see the difference. Hint: no luck with LoadIcon, NULL...
Rockphorr, the solution to your problem on the site wasm.in
jj2007, la tua soluzione รจ ottima!
Quote from: jj2007 on August 02, 2022, 12:20:42 PM
QuoteNo resources needed loading by that program; just uses LoadIcon, NULL, IDI_WINLOGO. Works.
It "works" because Windows gives you that ugly grey default icon that dates back to MS DOS times. Below you can see the difference. Hint: no luck with LoadIcon, NULL...
Wait, I'm confused. That picture you posted shows
exactly the icon I got with
INVOKE LoadIcon, NULL, IDI_WINLOGO
Not the "ugly grey default icon that dates back to MS-DOS times". I loaded
no resources. Just the code I gave here.
NirSoft icon viewer:
https://www.nirsoft.net/utils/iconsext.html
shell32.dll and imageres.dll names are in iconcache.db database.
hIcon1 = LoadIcon(NULL, IDI_WINLOGO);
hIcon2 = LoadImage(NULL, MAKEINTRESOURCE(OIC_WINLOGO), IMAGE_ICON, 0, 0, LR_DEFAULTSIZE | LR_SHARED);
Quote from: NoCforMe on August 02, 2022, 01:18:28 PM
Wait, I'm confused. That picture you posted shows exactly the icon I got with
INVOKE LoadIcon, NULL, IDI_WINLOGO
Not the "ugly grey default icon that dates back to MS-DOS times". I loaded no resources. Just the code I gave here.
I know it's confusing. There are two locations in a standard Windows program where to load icons:
A. in WinMain: mov wc.hIcon, rv(LoadIcon, ...
B. in the WM_PAINT handler: invoke DrawIcon, hdc, 10, 10, rv(LoadIcon, ...
The two locations behave differently. In WinMain, if you load an invalid icon, you get this:
(https://icon-library.com/images/windows-exe-icon/windows-exe-icon-25.jpg)
This is the ugly default icon for executables, and it dates back to the 20th Century - see also below the AltTab screenshot.
If you load an invalid icon in the WM_PAINT handler, you just see
nothing.
If you use LoadIcon,
hInstance..., Windows checks in this instance, i.e. in the resources of this exe, for a matching ICON.
If you use LoadIcon,
NULL..., Windows checks elsewhere, and finds, in most cases, the crappy grey default icon.
I attach a testbed for playing, 48 lines only - the absolute minimum for a Windows program. Pure Masm32 SDK ;-)
In Windows 7 x64
Thanks to Mikl, I found that i forget
push hIcon
call GetLastError
pop hIcon
so i lost handle when it was.
this is working code
;---------------------------
mov EAX,LR_SHARED
push EAX ;fuLoad
mov EAX,32 ;y height
push EAX ;cyDesired
mov EAX,32 ;x width
push EAX ;cxDesired
mov EAX,IMAGE_ICON
push EAX ;uType
;xor EAX,EAX
mov EAX,OIC_WINLOGO
push EAX ;lpszName
xor EAX,EAX
;mov EAX,hInstance
push EAX ;hinst
call LoadImage
;---------------------------
push EAX
mov EAX,100;Y
push EAX
mov EAX,1;X
push EAX
push [EBP+@HDC]
call DrawIcon
;---------------------------
Quote from: Rockphorr on August 03, 2022, 02:05:04 AM
mov EAX,LR_SHARED
push EAX ;fuLoad
mov EAX,32 ;y height
push EAX ;cyDesired
Can you explain, in a few words, the logic of your approach? Why don't you use
push LR_SHARED ; fuLoad
push 32 ; cyDesired
?
Quote from: jj2007 on August 03, 2022, 02:29:48 AM
Quote from: Rockphorr on August 03, 2022, 02:05:04 AM
mov EAX,LR_SHARED
push EAX ;fuLoad
mov EAX,32 ;y height
push EAX ;cyDesired
Can you explain, in a few words, the logic of your approach? Why don't you use
push LR_SHARED ; fuLoad
push 32 ; cyDesired
?
Or better yet, as you suggested earlier, just dispense with all this push-push-call crap and use INVOKE as [insert name of deity here] intended:
INVOKE LoadImage, 0, OIC_WINLOGO, IMAGE_ICON, 32, 32, LR_SHARED
It does
exactly the same thing as the mess you have and is much more readable, understandable and maintainable.
Quote from: NoCforMe on August 03, 2022, 03:37:35 AM
Quote from: jj2007 on August 03, 2022, 02:29:48 AM
Quote from: Rockphorr on August 03, 2022, 02:05:04 AM
mov EAX,LR_SHARED
push EAX ;fuLoad
mov EAX,32 ;y height
push EAX ;cyDesired
Can you explain, in a few words, the logic of your approach? Why don't you use
push LR_SHARED ; fuLoad
push 32 ; cyDesired
?
Or better yet, as you suggested earlier, just dispense with all this push-push-call crap and use INVOKE as [insert name of deity here] intended:
INVOKE LoadImage, 0, OIC_WINLOGO, IMAGE_ICON, 32, 32, LR_SHARED
It does exactly the same thing as the mess you have and is much more readable, understandable and maintainable.
I prefer a code style look like inside the debugger. For more readable, understandable and maintainable are C++.
OK.
Did you try my suggestion?
INVOKE LoadIcon, NULL, IDI_WINLOGO
Works for me. Tell us what you get from this.
JJ; I think you're mistaken about the icon being displayed. When I run my little program on my Windows 2000 machine I get the following, which you can see is different from the icon you showed in your previous post. This is the "ugly gray boring Windows icon", not that other one, which is one of the newer shell icons. Yes?
From WindowsXP things changed, themes arrived.
Just check MS documentation.
Yes, I know that. That's what I'm saying: what I just posted is the old W2K look. The other pics are from newer (Win7 in my case) versions. The difference is obvious.
Quote from: NoCforMe on August 03, 2022, 05:45:10 AM
what I just posted is the old W2K look. The other pics are from newer (Win7 in my case) versions. The difference is obvious.
I have no access to a W2K machine, but I believe you, of course. So instead of the crappy grey icon, you get this colourful icon... but it doesn't change the rule that with LoadIcon, hInstance... you get an icon from the embedded resources of your own exe, while with LoadIcon, NULL... you get some default icon as a friendly gift from Windows ;-)
Quote from: jj2007 on August 02, 2022, 08:04:41 PMThere are two locations in a standard Windows program where to load icons:
A. in WinMain: mov wc.hIcon, rv(LoadIcon, ...
B. in the WM_PAINT handler: invoke DrawIcon, hdc, 10, 10, rv(LoadIcon, ...
The two locations behave differently. In WinMain, if you load an invalid icon, you get this:
(https://icon-library.com/images/windows-exe-icon/windows-exe-icon-25.jpg)
This is the ugly default icon for executables, and it dates back to the 20th Century - see also below the AltTab screenshot.
If you load an invalid icon in the WM_PAINT handler, you just see nothing.
If you use LoadIcon, hInstance..., Windows checks in this instance, i.e. in the resources of this exe, for a matching ICON.
If you use LoadIcon, NULL..., Windows checks elsewhere, and finds, in most cases, the crappy grey default icon.
I attach a testbed for playing, 48 lines only - the absolute minimum for a Windows program. Pure Masm32 SDK ;-)
Quote from: Rockphorr on August 03, 2022, 04:36:01 AMI prefer a code style look like inside the debugger.
Have fun :thumbsup:
No problem for 100 line proggies, but once you reach the 1,000 lines, you will have a lot of fun. No arg count, no arg checks, that's a recipe for numerous lovely bugs :biggrin:
Quote from: jj2007 on August 03, 2022, 06:42:04 AM
Quote from: NoCforMe on August 03, 2022, 05:45:10 AM
what I just posted is the old W2K look. The other pics are from newer (Win7 in my case) versions. The difference is obvious.
I have no access to a W2K machine, but I believe you, of course. So instead of the crappy grey icon, you get this colourful icon... but it doesn't change the rule that with LoadIcon, hInstance... you get an icon from the embedded resoures of your own exe, while with LoadIcon, NULL... you get some default icon as a friendly gift from Windows ;-)
Quite right, old chap. What we're still not sure of is what, exactly, the OP wants. Do they want the "generic" icon or something specific to their executable? In any case, they now have no excuse for not being able to load
something, since I've shown that you can use
LoadIcon() with a NULL hInstance to load ... something.
BTW, that "crappy" icon isn't gray, it's green. And it is a "new" one, not one that dates back to the 20th century.
Quote from: NoCforMe on August 03, 2022, 06:56:15 AMBTW, that "crappy" icon isn't gray, it's green. And it is a "new" one, not one that dates back to the 20th century.
Well, it looks grey to me, and it looks old to me :biggrin:
Most probably, I hate it because I associate it with "something went wrong with the resource file" :tongue:
(https://icon-library.com/images/windows-exe-icon/windows-exe-icon-25.jpg)
Btw there is also a short Icon Explorer thread (http://masm32.com/board/index.php?topic=8295.0) (warning: it's MasmBasic :eusa_boohoo:)
(http://www.jj2007.eu/pics/IconExplorer.png)
Quote from: jj2007 on August 03, 2022, 02:29:48 AM
Quote from: Rockphorr on August 03, 2022, 02:05:04 AM
mov EAX,LR_SHARED
push EAX ;fuLoad
mov EAX,32 ;y height
push EAX ;cyDesired
Can you explain, in a few words, the logic of your approach? Why don't you use
push LR_SHARED ; fuLoad
push 32 ; cyDesired
?
It is my dos legacy code style.
A full solution is in attachment .
It looks awesome on Windows 95. See screens.zip --- I write it for W95 and it is enought for me.
Thanks You all for your help!
Regards.
QuoteIt is my dos legacy code style.
Bzzzzzt! Bad answer. So you're coding as if you're still writing for the 8088, where you couldn't push constants (or do a lot of other things). So basically you're wearing blinders, saying "La la la la la" while you ignore all the advances that have been made since those days.
Get with the program. You already know basic X86 assembler, so you just need to learn a few new tricks. Believe me, life will be a lot easier.
BTW, congrats on your program working. We expect to see great things from you now.