Newbie questions I know...
What I want to do, is change the color of a static control (to show it has been 'selected')
Once selected, press number on keyboard/keypad to 'enter' a number to be written to the static control.
Once a number has been written, revert background color to its original
Seems there is no way to do what I intend simply using WM_XXXXXXXX messages. I had created a colored static control, but
could not set the text with a call to SetWindowText. (that code has been recycled)
So thereofore I know I will need to do what is required using device contexts, DrawText, etc. But exactly how can this be accomplished without too much aggravation?
Just need to be pointed in the right direction, I dont expect anyone to write the code for me.
Attempting to write a sudoku game (Not sudoku solver - that would be much later)
The basic code is here:
Source for succesful demonstration of static control with colored background and (black) text in my last post in this thread
WM_CTLCOLORSTATIC is your friend here:
Recipe for Delicious Colored Text
---------------------------------
How to present text (in a static control used for output) in a color other than basic black.
1. Set the color:
$colorDkRed EQU 192
$highlightColor EQU $colorDkRed
2. Create a color and a brush that color of the (dialog, window) background:
BkColor DD ?
BkBrush HBRUSH ?
INVOKE GetSysColor, COLOR_BTNFACE ;Color of (default) dialog background.
MOV BkColor, EAX
INVOKE CreateSolidBrush, EAX
MOV BkBrush, EAX
3. Store the handle of the control we want to colorize:
ChordLenOutHandle HWND ?
INVOKE GetDlgItem, hWin, $chordLenOut ;If it's in a dialog.
MOV ChordLenOutHandle, EAX
4. Catch the WM_CTLCOLORSTATIC message (in the parent window proc of the control):
MOV EAX, uMsg
CMP EAX, WM_INITDIALOG
JE do_init
. . .
CMP EAX, WM_CTLCOLORSTATIC ;Look for controls we want to display in diff. colors.
JE doClr
5. Handle the message:
; Look for handles of controls where we want different color text.
; lParam = handle of control that sent message:
doClr: MOV EAX, lParam
CMP EAX, ChordLenOutHandle
JE setclr
CMP EAX, ArcAngleOutHandle
JNE dodefault
setclr: INVOKE SetTextColor, wParam, $highlightColor ;wParam = HDC.
INVOKE SetBkColor, wParam, BkColor
; Return with background brush:
MOV EAX, BkBrush
RET
This code is for a dialog, but it could just as easily be used for any window that "owns" controls (i.e., the parent of child static controls).
Nice thing here is you don't have to mess with device contexts here, except to use the pre-packaged one that Windows passes you in wParam.
Keep in mind that you have to set the background color (by returning that brush) as well as the foreground color of the control, so you'll probably want to match the existing background of the static control so it doesn't look funny.
BTW, you can do the same thing for an edit control by handling WM_CTLCOLOREDIT.
(This is a "recipe" that I wrote for myself some time ago to do just what you want to do.)
Quote from: NoCforMe on August 14, 2022, 06:24:20 AM
(This is a "recipe" that I wrote for myself some time ago to do just what you want to do.)
Thanks, NoCforMe. I'll work on it and post what I come up with.
I'm on my iPad right now, but I'll check it out when I'm back at my computer.
Giving your code a quick look, I'm not sure it is what I'm after. What I want to do is change the background color of a static control when left clicked. Then a flag would be set indicating that the control is selected.
Once selected, I would then press a number on the keyboard and then write that number onto the static control that was selected after which I unset the 'selected' flag. Upon returning I want the background color to revert to original. Don't need to change the text color from black.
I might just revert to using bit maps to do my bidding. But I'll still experiment with CTLCOLORSTATIC in the meantime...
Since we are dealing with device context probably means handling WM_PAINT msgs.?..
The code I showed you will do exactly what you want it to. You don't have to change the color of the text; that's just what's usually done with this message. It will change the background color to whatever you want, using both SetBkColor() and by setting the background brush that you return.
The only thing I'm not sure of is being able to catch a mouse click on the control; for that you'll probably have to subclass the control. (But since you're smarter than a box of rocks, that shouldn't be a problem.) You could also handle that by catching WM_RBUTTONDOWN in the parent window proc, then doing your own "hit test" to see if the click was over that static control (also not rocket surgery).
If it would turn out to be more complex than it should (which it sounds like it might), as I said I'll just use bit maps. But thanks again for trying. I'll still play with this a bit before giving up though. I might have to find a sharper tool in the shed to do it though. :tongue:
Believe me, using bitmaps would be a much harder way to do this simple task. Not a sharper tool in this case. (Unless you want to change the imagery of your statics.)
If you want an interactive control, a static control is not the right control to use. a "BUTTON" class control set to the BS_BITMAP style will do what you need with 2 bitmaps and a subclass to switch between the two.
Hutch is right; if you want the control to respond to mouse clicks, then a button would be the way to go.
You may not need to use bitmaps, however: there's another CTLCOLOR message you can use, WM_CTLCOLORBTN. (See, they covered all the controls here with that functionality.) You can use this to set the background color. You wouldn't even need to subclass the control.
The only reason I can see for using bitmaps is if you wanted something besides a plain colored background for the rectangle.
If you do use this message, you'll need to create the button with the "owner draw" style (BS_OWNERDRAW), which means that you are now responsible for drawing all aspects of the control. Not that hard to do.
Quote from: hutch-- on August 14, 2022, 09:23:35 AM
If you want an interactive control, a static control is not the right control to use.
I know your line of thinking, but if using SS_NOTIFY is or'ed in the window style, will enable interactivity similar as if it were a button.
Quote from: NoCforMe on August 14, 2022, 10:29:42 AM
... there's another CTLCOLOR message you can use, WM_CTLCOLORBTN
I've already had issues with WM_CTLCOLORxxx messages...
Quote...with the "owner draw" style (BS_OWNERDRAW), which means that you are now responsible for drawing all aspects of the control. Not that hard to do.
This is where the 'box of rocks' side of me comes in... :undecided: I don't have any experience with using BS_OWNERDRAW, or a whole lot of experience working with device contexts in general.
Anyway, I'll figure it out eventually. I've found some examples with what I think might be useful techniques for doing what I endeavor to do. I'm experimenting as I'm writing this... I'll keep you guys posted with any progress or lack thereof. :cool:
Quote from: swordfish on August 14, 2022, 02:41:26 PM
Quote from: NoCforMe on August 14, 2022, 10:29:42 AM
... there's another CTLCOLOR message you can use, WM_CTLCOLORBTN
I've already had issues with WM_CTLCOLORxxx messages...
So what issues have you had? That's one of the easier message classes to implement responses to. Maybe we can help you through this.
Quote from: NoCforMe on August 14, 2022, 04:15:01 PM
Quote from: swordfish on August 14, 2022, 02:41:26 PM
Quote from: NoCforMe on August 14, 2022, 10:29:42 AM
... there's another CTLCOLOR message you can use, WM_CTLCOLORBTN
I've already had issues with WM_CTLCOLORxxx messages...
So what issues have you had? That's one of the easier message classes to implement responses to. Maybe we can help you through this.
Thats alright. Currently I'm trying a different approach...
Here's my nonconformist approach... :biggrin:
Static control as the displayed 'cell'
Custom colored static control as the 'selection highlight' colored background
Only displaying one cell for this test. Once filled up, will have a 9x9 grid of cells. Have to write code so that only one cell can be selected at a time also disallow invalid cell entries following sudoku rules...
Looks like were off to the races (sharp tool speaking - lol)
Source for succesful demonstration of static control with colored background and (black) text in my last post in this thread
How about just making a bitmap and update it as grid ?
The WM_CTLCOLORBTN only works on the button border, not the face of the button. You solve this with BS_BITMAP on a "BUTTON" class control and if you want to have the button appearance change, you create a subclass and switch the two bitmaps.
Quote from: hutch-- on August 14, 2022, 06:22:05 PM
The WM_CTLCOLORBTN only works on the button border, not the face of the button.
Buttons... buttons? We don't need no stinkin' buttons... :undecided:
Static control + WS_NOTIFY = nearly a button, but without simulated movement. I had been talking about static controls myself.
You can get that functionality with a direct CreateWindowEx and you can do anything with it.
Quote from: NoCforMe on August 14, 2022, 04:15:01 PM
So what issues have you had? That's one of the easier message classes to implement responses to. Maybe we can help you through this.
Okay, I found one of the few times that I have used WM_CTLCOLORSTATIC. (took me some time to find it...)
When you first asked, I had forgotten exactly the issue I had in the past. Then I found the source that this dialog came from.
The problem there is while the background color change works,
there is a white border around the black text.Source for succesful demonstration of static control with colored background and (black) text in my last post in this thread
My last post gave me an idea. Suppose I put a transparent static control over the colored static control (when text is desired)?
I'm going to try that later when I have a little spare time, have to do some work in the yard...
Edit to add: Would have been a lot easier if there was such a thing as SS_SETTEXTCOLOR and SS_SETBKCOLOR. :biggrin:
If I get this straightened out, I should make a self contained static control where both the text and background colors can be chaged without much hassle. :cool:
Quote from: TimoVJL on August 14, 2022, 06:00:42 PM
How about just making a bitmap and update it as grid ?
I'm not sure exactly what you mean...
Quote from: swordfish on August 15, 2022, 01:26:59 AM
Quote from: TimoVJL on August 14, 2022, 06:00:42 PM
How about just making a bitmap and update it as grid ?
I'm not sure exactly what you mean...
In memory bitmap used for painting window is normal technique for games if window size is fixed.
In an old PC Magazine was an example of it ?
Use SetBkMode(hDC, TRANSPARENT); for transparent text. It should work with STATIC windows too.
EDIT:
Under WM_CTLCOLORSTATIC is place for SetBkMode and wparam gives hDC for it.
Quote from: TimoVJL on August 15, 2022, 01:45:48 AM
Use SetBkMode(hDC, TRANSPARENT); to transparent text.
Ok, thanks for the tips. Will look into that at some point...
*********** Here is the latest test piece *********
Color static control with dynamic color change ability. (click on static control to 'highlight' it)
Shows the issue with white around the text when it is 'highlighted'
In the first couple of attempts, forgot about calling InvalidateRect <----- caused a bit of head scratching
Source for succesful demonstration of static control with colored background and (black) text in my last post in this thread
Source with awful white border around text below
Quote from: TimoVJL on August 15, 2022, 01:45:48 AM
Under WM_CTLCOLORSTATIC is place for SetBkMode and wparam gives hDC for it.
:biggrin: I almost missed your edit. I will look into that later. Still doing some work in the yard. First day its not going to rain for at least two weeks, tomorrow as well. I should be able to try that after a little while but right now I gotta go back to the chores
Just for kicks, I added "invoke SetBkMode, wParam, TRANSPARENT"
voila! You're a genius. Well a few more notches up the genius ladder than me that is. :tongue:
And I thought I would have to use DrawText, and other GDI functions
As this has been resolved, I will no longer post any replies here
Quote from: swordfish on August 15, 2022, 04:33:22 AM
As this has been resolved, I will no longer post any replies here
Don't make promises you can't keep.
Seriously, I figured this would be the problem you had: trying (unsuccessfully) to match the background color of the text. Which you nicely resolved.
Thing to keep in mind here is that you are setting two different background colors: one is the background color of the text, the other is the background color of the control itself (via the returned brush). If the two don't match, you get the ugliness you observed.
Partial success: It works, but it does not behave like a normal pushbutton.
For your inspiration, here (http://masm32.com/board/index.php?topic=6483.msg112159#msg112159) is a multi-button program I am currently working on. Warning, it's not Campus stuff. Button background colour is actually a bit too complicated for the Campus IMHO.
If you create a static control as mentioned here and or the window style with SS_BITMAP, then SS_NOTIFY has NO effect meaning WndProc does not receive any WM_COMMAND message when left clicking on the static control. Else if SS_BITMAP is not or'ed with the static control window style, then WM_COMMAND messages will be received by WndProc as long as an ID is specified when creating the static control or is assigned through another method.
Also, SS_BITMAP does not play well with SetWindowText for the control. It could be that the bitmap is drawn after the text is written to the static control thereby covering the text but I have no way of knowing that for certain.
Just a little FYI for anyone interested.
Quote from: zedd151 on August 22, 2022, 11:32:53 PM
If you create a static control as mentioned here and or the window style with SS_BITMAP, then SS_NOTIFY has NO effect meaning WndProc does not receive any WM_COMMAND message when left clicking on the static control.
Are you sure about that? MSDN (https://docs.microsoft.com/en-us/windows/win32/controls/stn-clicked?redirectedfrom=MSDN) says nothing about that in their documentation of the
STN_CLICKED notification (which of course doesn't necessarily mean anything, since they're famous for omitting stuff).
Not challenging you, just curious. If you know this from experience then that's good enough for us. I haven't played with this enough to know for sure, but it wouldn't be hard to set up a testbed to check this out.
STN_CLICKED I have never used. Frankly never new it exist. I usually used WM_COMMAND. :toothy:
I'll try STN_CLICKED later.
It is sent through
WM_COMMAND:
QuoteParameters:
wParam
The LOWORD contains the identifier of the static control. The HIWORD specifies the notification code.
lParam
Handle to the static control.
(the notification code is
STN_CLICKED)
Quote from: NoCforMe on August 23, 2022, 04:10:37 AM
It is sent through WM_COMMAND:
.....
(the notification code is STN_CLICKED)
Who would have thought? I just learnt something new. I wonder why no one mentioned this earlier in this thread. :tongue: Might have saved some time. At any rate at some point I will post here several examples of using a clickable static control. For contrast I will also post a couple of examples that don't work as might be expected. I'm currently working on another project though so it may take a little while.
Glad you learnt something.
If you want to change the color of your static on being clicked (and forget bitmaps, puleeze!), you still need to handle WM_CTRLCOLORSTATIC as described earlier; you can't do that directly from STN_CLICKED, as you have no access to the control's DC then. But it's easy peasy.
I'll cook up a testbed soon as I take a break from my other current project.
Quote from: NoCforMe on August 23, 2022, 06:06:56 AM
I'll cook up a testbed soon as I take a break from my other current project.
Ok, lets see who finishes their current project first. :cool:
I can tell you right now it ain't gonna be me ...
Quote from: NoCforMe on August 23, 2022, 08:44:42 AM
I can tell you right now it ain't gonna be me ...
lol. I am kinda making slow progress here as well.
OK, I took enough of a break from my other project (a frustrating one!) to put together this li'l static control testbed. It shows that for a regular (text)-type static, the control will respond to mouse clicks (via ST_CLICKED) and behave much like a button. Also shows how easy it is to change colors via WM_CTLCOLORSTATIC. Look ma, no subclassing!
The top-left cell responds to clicks (check the status bar when you do). The other one just sits there. When I get a little more time I'll put a couple bitmap statics in, see how they work.
[later, in another part of the forest]
I put in 3 bitmap statics (SS_BITMAP). This totally demolishes what somebody here said, that such statics wouldn't respond to mouse clicks. See for yourself. Works fine. One of them even flips the BMP when clicked on.
(style = SS_BITMAP | SS_NOTIFY)
WinUser.h
#define STN_CLICKED 0
#define STN_DBLCLK 1
#define STN_ENABLE 2
#define STN_DISABLE 3
:biggrin:
> This totally demolishes what somebody here said
A STATIC class control is just that, STATIC. If you do as much work on the base control to bypass its characteristics, you may as well do it properly with CreateWindowEx() with its own WNDCLASSEX structure. When you use predefined classes for Windows, you get those basic characteristics defined in the class, if you want to create a custom control, its done with a CreateWindowEx with code of your choice in the WNDCLASSEX structure and a WndProc style procedure for message processing.
You can play games like this but you are doing it for the practice, not performance.
Quote from: hutch-- on August 23, 2022, 07:17:33 PMYou can play games like this but you are doing it for the practice, not performance.
Valid point :biggrin:
Well, all I know is that Micro$oft, in all their wisdom, has endowed the static class of control with interactivity in the form of STN_CLICKED notifications, so hey, who are we not to take advantage of that? Who cares if it doesn't have all the functionality of a button? Works fine in this application. Just hoping I don't get a visit in the middle of the night from the Coding Police.
STN_CLICKED is interesting, too. I have been fighting for some days now with the NM_CUSTOMDRAW notification, and would appreciate help on this. The attached code is pure Masm32 SDK (and confused - apologies :rolleyes:)
My problem: Setting the background colour of the right pushbutton works fine, but SetTextColor doesn't work (but GetLastError=0).
From the tests I've made it seems that (on Win 7 at least) the text is set somewhere between the CDDS_PREPAINT and CDDS_POSTPAINT notifications. But SetTextColor doesn't work in any of the stages :sad:
Comment out, in line 222, the mov eax, CDRF_DODEFAULT to see what happens when CDDS_POSTPAINT is active. Btw returning CDRF_SKIPDEFAULT from the prepaint event suppresses the painting of the text, but it also suppresses important functions.
See FreeBasic's kcvinu (also a Masm32 member but not active), How to change the back color of a control at runtime ? (https://www.freebasic.net/forum/viewtopic.php?p=281393&sid=cf46cdf458b34ee4354b4177fbf620ac#p281393):
QuoteTo change the fore color, Just use three functions.
SetBkMode
SetTextColor
DrawText
And then return CDRF_NOTIFYPOSTPAINT.
If you returned any other values, the color won't change.
So there is no need to use BS_OWNERDRAW style.
I can't confirm that so far :cool:
Quote from: jj2007 on August 24, 2022, 06:51:40 AM
SetTextColor doesn't work (but GetLastError=0).
include \masm32\include\masm32rt.inc
WinMain proto
CreateMain proto :dword, :dword, :dword, :dword
CenterMain proto :dword, :dword, :dword
WndProc proto :dword, :dword, :dword, :dword
.data
hInstance dd 0
hWnd dd 0
ww dd 800
wh dd 600
h11 dd 0
selected dd 1
statClass db "STATIC", 0
Class db "Window_CLASS", 0
DispName db "Untitled", 0
.code
cell proc par:dword, x:dword, y:dword, id:dword
local cn:dword, ws:dword, hi:dword, hndl:dword, hfnt:dword
mov eax, hInstance
mov hi, eax
lea eax, statClass
mov cn, eax
mov ws, WS_VISIBLE
or ws, WS_CHILD
or ws, SS_CENTER
or ws, SS_NOTIFY
invoke CreateWindowEx, 0, cn, 0, ws, x, y, 64, 64, par, id, hi, 0
mov hndl, eax
fn RetFontHandle, "tahoma", 56, 400
mov hfnt, eax
invoke SendMessage, hndl, WM_SETFONT, hfnt, 0
mov eax, hndl
ret
cell endp
WinMain proc
local msg:MSG
invoke CreateMain, 0, addr Class, addr WndProc, 0
mov hWnd, eax
invoke cell, hWnd, 4, 4, 211 ;; create static window standard "STATIC" class
mov h11, eax
fn SetWindowText, h11, "8" ;; set text into static control for demonstration of issue
invoke CenterMain, hWnd, ww, wh
invoke ShowWindow, hWnd, SW_SHOWNORMAL
invoke UpdateWindow, hWnd
invoke SetWindowText, hWnd, addr DispName
StartLoop:
invoke GetMessage, addr msg, 0, 0, 0
cmp eax, 0
je ExitLoop
invoke TranslateMessage, addr msg
invoke DispatchMessage, addr msg
jmp StartLoop
ExitLoop:
invoke ExitProcess, 0
ret
WinMain endp
WndProc proc hWin:dword, uMsg:dword, wParam:dword, lParam:dword
.if uMsg == WM_COMMAND
.if wParam == 211
.if selected == 0 ;; if cell not selected, select it
mov selected, 1
invoke InvalidateRect, h11, 0, TRUE
.elseif selected == 1 ;; if cell is selected, deselect it
mov selected, 0
invoke InvalidateRect, h11, 0, TRUE
.endif
.endif
.elseif uMsg==WM_CTLCOLORSTATIC
.if selected == 0 ;; check if cell is selected
invoke SetBkMode, wParam, TRANSPARENT
invoke SetTextColor, wParam, 00FF0000h ;; SetTextColor
invoke CreateSolidBrush, 00FFD0E0h ;; set color accordingly
ret
.elseif selected == 1
invoke SetBkMode, wParam, TRANSPARENT
invoke SetTextColor, wParam, 000000FFh ;; SetTextColor
invoke CreateSolidBrush, 00FFFFFFh ;; set color accordingly
ret
.endif
.elseif uMsg == WM_CLOSE
invoke PostQuitMessage, 0
return 0
.endif
invoke DefWindowProc, hWin, uMsg, wParam, lParam
ret
WndProc endp
CreateMain proc hI:dword, cn:dword, wp:dword, ic:dword
local wc:WNDCLASSEX, hIcon:dword, rct:RECT
mov hIcon, 0
cmp ic, 0
jz @f
invoke LoadIcon, hI, ic
mov hIcon, eax
@@:
mov wc.cbSize, sizeof WNDCLASSEX
mov wc.style, CS_BYTEALIGNWINDOW
mrm wc.lpfnWndProc, wp
mov wc.cbClsExtra, 0
mov wc.cbWndExtra, 0
mrm wc.hInstance, hI
mov wc.hbrBackground, COLOR_BTNFACE+2
mov wc.lpszMenuName, 0
mrm wc.lpszClassName, cn
mrm wc.hIcon, hIcon
invoke LoadCursor, 0, IDC_ARROW
mov wc.hCursor, eax
mrm wc.hIconSm, hIcon
invoke RegisterClassEx, addr wc
invoke CreateWindowEx, 528, cn, 0, 0CF0000h, 0, 0, 0, 0, 0, 0, 0, 0
ret
CreateMain endp
CenterMain proc hWin:dword, wd:dword, ht:dword
local rct:RECT, x:dword, y:dword
invoke SystemParametersInfoA, SPI_GETWORKAREA, 0, addr rct, 0
mov eax, rct.right
sub eax, wd
shr eax, 1
mov x, eax
mov eax, rct.bottom
sub eax, ht
shr eax, 1
mov y, eax
invoke MoveWindow, hWin, x, y, wd, ht, TRUE
ret
CenterMain endp
end WinMain
You're welcome. :cool:
You could try to modify the code to fit what you need to do
Quote from: Swordfish on August 24, 2022, 07:04:11 AMYou're welcome. :cool:
You could try to modify the code to fit what you need to do
Nice code but far from what I want to achieve. A static control does not give the feedback that a user expects from a pushbutton.
Quote from: jj2007 on August 24, 2022, 07:11:28 AM
A static control does not give the feedback that a user expects from a pushbutton.
Yes you are right I guess.
But have you tried implementing for your button, the same way as has been done for the static in my example?
Check my code, swordfish. I am using the NM_CUSTOMDRAW notification, which is more complicated but the official M$ way to do it.
I have been looking at it, wondering why overcomplicate it if what you want to do can be done easier?
From the link you posted jj:
> P.S.: If I add a BS_COMMANDLINK style to the pXpButton3 button in Josep Roca's example, it doesn't change at all.
and in the code you attached:
invoke CreateWindowExW, 0, uc$("button"), uc$("Button"),
WS_CHILD or WS_VISIBLE or WS_BORDER or BS_COMMANDLINK or BS_TEXT or BS_MULTILINE,
9, 9, 96, 32, hWnd, 110, wcx.hInstance, NULL ; we have added an edit control
so, have you tried removing 'BS_COMMANDLINK' ? (not sure what does or is for, btw)
Quote from: Swordfish on August 24, 2022, 07:27:18 AM
I have been looking at it, wondering why overcomplicate it if what you want to do can be done easier?
A pushbutton has a defined behaviour. Show me a static control that behaves exactly like a pushbutton.
Quote from: Swordfish on August 24, 2022, 07:04:11 AM
mov ws, WS_VISIBLE
or ws, WS_CHILD
or ws, SS_CENTER
or ws, SS_NOTIFY
Hate to carp here (it doesn't have anything to do w/the question at hand), but this is so clunky. Why not just
mov ws, WS_VISIBLE or WS_CHILD or SS_CENTER or SS_NOTIFY
KISS.
Quote from: jj2007 on August 24, 2022, 06:51:40 AM
STN_CLICKED is interesting, too. I have been fighting for some days now with the NM_CUSTOMDRAW notification, and would appreciate help on this. The attached code is pure Masm32 SDK (and confused - apologies :rolleyes:)
JJ, I feel your pain here. I spent literally a whole day battling with NM_CUSTOMDRAW (for a listview), and finally just gave up in disgust.
First of all, the interface is just plain horrible. All those draw stages and states, and their ill-defined behaviors. (MSDN is only of limited help here, just enough to get you started and then very frustrated!) I did find a lot of stuff online, some of which was helpful in explaining how to actually use this stuff, but in the end I was never able to get it to work. (In fairness, some of the trouble was with the listview control itself, which is another can o'worms.)
I'll go back over what I did get to work and post it here later.
One thing: I glanced at the code you posted and noticed that you're mostly dealing with the "post-paint" stages. I never tried using these, only the "pre-paint" ones. Are you sure these are what you want? What exactly are you trying to do with your control? Can you clearly map out the sequence of events that should happen to render them the way you want?
I'm asking because I was never really able to figure that out for my code, so I was pretty much just floundering, trying this, trying that.
Quote from: NoCforMe on August 24, 2022, 07:52:38 AM
mov ws, WS_VISIBLE
or ws, WS_CHILD
or ws, SS_CENTER
or ws, SS_NOTIFY
KISS.
To quickly see the list :tongue: And you complain about coding police :badgrin:
Reply #45 is for jj btw (I added to it while you guys were posting)
Then we have this:
Quote from: jj2007 on August 24, 2022, 07:44:01 AM
A pushbutton has a defined behaviour. Show me a static control that behaves exactly like a pushbutton.
AAnnnd, I never mentioned that YOU should use static in place of a button. Even though WE were discussing static controls here, but I digress on that point.
Well then how about
mov ws, WS_VISIBLE or \
WS_CHILD or \
SS_CENTER or \
SS_NOTIFY
Hey, saves you 3 whole instructions! Woo hoo. (The line continuation character is your friend here.)
Quote from: NoCforMe on August 24, 2022, 07:56:11 AMI glanced at the code you posted and noticed that you're mostly dealing with the "post-paint" stages. I never tried using these, only the "pre-paint" ones.
Here are the four interesting stages (others are ITEM-specific, for listviews etc):
CDDS_PREPAINT equ 00000001h
CDDS_POSTPAINT equ 00000002h
CDDS_PREERASE equ 00000003h
CDDS_POSTERASE equ 00000004hNow it seems that the posterase stage is never triggered. I tried googling "CDDS_POSTERASE" and stumble over my own posts in the FreeBasic forum (https://freebasic.net/forum/viewtopic.php?p=288629); which probably means that nobody uses this.
The sequence I see is
CDDS_PREERASE
CDDS_PREPAINT
... text happens here ...
CDDS_POSTPAINT - only if prepaint returns CDRF_NOTIFYPOSTPAINT
Note this: (https://docs.microsoft.com/en-us/windows/win32/api/commctrl/ns-commctrl-nmcustomdraw)
QuoteWhen the dwDrawStage member equals CDDS_PREPAINT and CDDS_PREERASE, some controls send the CDDS_PREERASE message first and expect the return value to indicate which subsequent messages will be sent
Quote
Hey, saves you 3 whole instructions! Woo hoo. (The line continuation character is your friend here.)
That code is old code from my little "Basic Window" template. If it ain't broke don't fix it. If it is broke, blame M$. :tongue:
Quote from: jj2007 on August 24, 2022, 08:42:04 AM
Here are the four interesting stages (others are ITEM-specific, for listviews etc):
CDDS_PREPAINT equ 00000001h
CDDS_POSTPAINT equ 00000002h
CDDS_PREERASE equ 00000003h
CDDS_POSTERASE equ 00000004h
Keep in mind that you have to return certain values at certain stages to trigger certain events. (It's all in the MSDN documentation (https://docs.microsoft.com/en-us/windows/win32/controls/about-custom-draw).)
Quote from: NoCforMe on August 24, 2022, 08:54:56 AM
Quote from: jj2007 on August 24, 2022, 08:42:04 AM
Here are the four interesting stages (others are ITEM-specific, for listviews etc):
CDDS_PREPAINT equ 00000001h
CDDS_POSTPAINT equ 00000002h
CDDS_PREERASE equ 00000003h
CDDS_POSTERASE equ 00000004h
Keep in mind that you have to return certain values at certain stages to trigger certain events. (It's all in the MSDN documentation (https://docs.microsoft.com/en-us/windows/win32/controls/about-custom-draw).)
Apart from M$'s bad language ("the dwDrawStage member equals CDDS_PREPAINT
and CDDS_PREERASE" - impossible), you must dig deep to find out how to get all four stages; and even then, no luck with setting the text colour :sad:
I attach a version showing the four stages in action.
One small thing that might help: Look at the actual values for the draw stages (CDDS_xxx) in windows.inc. Some of them are combinations of others.
One thing I did was log all the various stages, etc., in the NM_CUSTOMDRAW notifications.
Quote from: NoCforMe on August 24, 2022, 09:38:27 AM
One thing I did was log all the various stages, etc., in the NM_CUSTOMDRAW notifications.
Quote from: jj2007 on August 24, 2022, 09:27:14 AM
I attach a version showing the four stages in action.
Jochen, I know we have had our disagreements but also I know that you know your stuff when it comes to writing code. (At least most of the time :tongue: )
It seems that either the function(s) that you are trying to use are either buggy in their internals, or need to be used with exact parameters or you're missing a crucial step, or something of that nature.
Anyway I would like to know how this button your working on is supposed to work and what does it do. Have you considered any other methods to achieve the same goal? There is usually more than one way to skin a cat after all. Or is this just an exercise on how to implement custom drawn buttons?
I've been scouring the internet looking for additional info regarding custom drawn controls will post link(s) if I find anything that might be useful for your research. The only thing I found (searching custom drawn vs. owner drawn) other than MSDN is --> link (https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=&cad=rja&uact=8&ved=2ahUKEwjWsbOH-975AhWMZTABHfgwDKIQFnoECBIQAQ&url=https%3A%2F%2Fcodexpert.ro%2Fblog%2F2013%2F02%2F22%2Fcustom-draw-vs-owner-draw-controls%2F&usg=AOvVaw1eUvn07nwj3Fm8cqE2gYcU) , seems just basic stuff there no examples. Found some MFC stuff in another search quite sure you dont want that though.
Guys, this is a system defined bitmap button example.
http://masm32.com/board/index.php?topic=10178.0 (http://masm32.com/board/index.php?topic=10178.0)
If you really want "science", you use this technique but create the two bitmaps dynamically using GDI. Create two bitmaps of the right size then write text to both bitmaps. Then you can have button change when clicked, you can have whatever change in appearance you require.
Its not exactly amateur hour to code this but if you needed it, it can be done. An alternative is to only set one bitmap to the button if you don't want and change on it being clicked.
Another option is to create a window with CreateWindowEx with a hollow brush then write text and perhaps a border to it in whatever colour you want. All it takes is the usual creative genius and knowing how to do it.
Quote from: Swordfish on August 24, 2022, 04:59:45 PMAnyway I would like to know how this button your working on is supposed to work and what does it do.
As already shown in the example above: a coloured pushbutton. Everything works fine, even the rounded corners; the only missing bit is the text colour. And that's what's annoying me: SetTextColor should work, according to the documentation, but it doesn't. I've tried all stages, and it just refuses to function. SetBkMode works fine, for example :sad:
Just for fun, attached a button, 42 lines of pure Masm32 SDK code.
And here is the point: In Win10, the button text is blue, and the word "Button" is not bold :sad:
Quote from: hutch-- on August 24, 2022, 07:36:10 PMuse this technique but create the two bitmaps dynamically using GDI
Interesting idea :thumbsup:
Btw GetFontHandle (in your example): is that a regular Win32 API function, or is it part of the Masm64 SDK?
Its just a wapper around a CreateFont API. Saves the extra typing.
; ¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤
font_handle proc facename:QWORD,fHgt:QWORD,fWgt:QWORD
invoke CreateFont,fHgt,0,0,0,fWgt,0,0,0,DEFAULT_CHARSET, \
OUT_DEFAULT_PRECIS,CLIP_DEFAULT_PRECIS, \
PROOF_QUALITY,DEFAULT_PITCH,facename
ret
font_handle endp
; ¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤
Ok, thanks for clarifying. GetFontHandle appears in Microsoft docs (https://docs.microsoft.com/en-us/cpp/mfc/reference/cfontholder-class?view=msvc-170#getfonthandle), but as "CFontHolder::GetFontHandle", that's why I asked.
Quote from: jj2007 on August 24, 2022, 07:58:32 PM
...the only missing bit is the text colour. And that's what's annoying me: SetTextColor should work, according to the documentation, but it doesn't. I've tried all stages, and it just refuses to function. SetBkMode works fine, for example :sad:
It doesn't work when creating/drawing it? Then try another method beside the messy looking custom functions.
@hutch, we hear you loud and clear. We know what bitmap buttons are, but they are not the solution to every button issue imo. I use them or at least something akin to the bitmap button examples in the Masm32 SDK for various projects already. For me the original intent of this topic has been solved and works for me. In my Tic Tac Toe game I use an alternative method yet. By getting the mouse coordinates and using BitBlt to change/insert bitmaps by clicking on predefined squares. Always more than one way to skin a cat. :biggrin:
jj is off on a tangent in creating a custom drawn button which is much different than what the topic was about and what you propose.
Anyway hutch, I asked in a PM for this topic to be moved out of the Campus for a reason. Since it has devolved from its original purpose, probably not Campus material... :undecided:
Quote from: Swordfish on August 25, 2022, 12:15:01 AMjj is off on a tangent in creating a custom drawn button which is much different than what the topic was about and what you propose.
Anyway hutch, I asked in a PM for this topic to be moved out of the Campus for a reason. Since it has devolved from its original purpose, probably not Campus material... :undecided:
Agreed. But check your original question - you basically asked for a pushbutton with special features ;-)
Quote from: jj2007 on August 25, 2022, 01:30:16 AM
Agreed. But check your original question - you basically asked for a pushbutton with special features ;-)
Not to split hairs here, I never even mentioned 'pushbutton' or even 'button'. Even the topic title mentions what my intentions were i.e., 'static control'. I specifically did not want the pushbutton effect, so opted for using a static control, WM_CTRLCOLORSTATIC, SS_NOTIFY to achieve the original goal - just to clarify again. What I missed though was setting background mode to TRANSPARENT. oops
I will no longer post in this thread (again - I've said that before). :tongue:
:biggrin:
> Anyway hutch, I asked in a PM for this topic to be moved out of the Campus for a reason. Since it has devolved from its original purpose, probably not Campus material...
And I ignored it for a reason, a topic does not get moved on request when it remains in the right place. Playing with variations of creating buttons is exactly Campus material. This ain't no rocket science. :tongue:
Quote from: hutch-- on August 25, 2022, 05:52:35 AM
This ain't no rocket science. :tongue:
Fair enough.
And I just said I will not be posting further here. You were just tempting me to post a reply.
:tongue:
*snip*
After further testing found the code I was testing was faulty. Oops.
In dialog static window SS_NOTIFY SS_BITMAP combination send messages.
SS_ICON sends too.
Quote from: TimoVJL on August 28, 2022, 07:49:08 PM
In dialog static window SS_NOTIFY SS_BITMAP combination send messages.
SS_ICON sends too.
Actually it's just SS_NOTIFY that enables messages; SS_BITMAP or SS_ICON have nothing to do with it. (Works for non-bitmap or -icon controls as well.)
Here is a playable version of Tic Tac Toe (http://masm32.com/board/index.php?topic=10292.msg112854#msg112854)
Instead of a big ol' "O" I get two thin vertical lines. Missing bitmap or something?
Quote from: NoCforMe on September 02, 2022, 11:20:31 AM
Instead of a big ol' "O" I get two thin vertical lines. Missing bitmap or something?
Yes program uses "Segoe UI Emoji" font. :rolleyes:
So, same issue here.
I'm not going to install MasmBasic just to change the font. :undecided:
Nor am I going to look for or download that font either.
So now I can't play. I guess I'll have to hurry and finish my Tic Tac Toe game. :biggrin:
Quote from: swordfish on September 02, 2022, 12:19:33 PM
Quote from: NoCforMe on September 02, 2022, 11:20:31 AM
Instead of a big ol' "O" I get two thin vertical lines. Missing bitmap or something?
Yes program uses "Segoe UI Emoji" font. :rolleyes:
Indeed, but that works fine on both Win7-64 and my standard Win10 installation - see below. Strange :rolleyes:
QuoteI guess I'll have to hurry and finish my Tic Tac Toe game. :biggrin:
Yessss :thumbsup:
"Segoe UI Emoji" comes within MS office packages ?
Segoe UI Emoji font family (https://docs.microsoft.com/en-us/typography/font-list/segoe-ui-emoji)
JJ,
What have you zipped that file with, neither Slimjet or Chrome download a valid zip file.
Quote from: TimoVJL on September 02, 2022, 07:13:25 PM
"Segoe UI Emoji" comes within MS office packages ?
Segoe UI Emoji font family (https://docs.microsoft.com/en-us/typography/font-list/segoe-ui-emoji)
That would explain something; however, on my Win10 machine I don't have the Office package. But I routinely install the free MS Word viewer (https://filehippo.com/download_word-viewer/) to make my RichEdit controls 20x faster, so that could be the reason why it works for me.
Quote from: hutch-- on September 02, 2022, 07:38:42 PM
What have you zipped that file with, neither Slimjet or Chrome download a valid zip file.
Works fine here, on two machines. You had the same problem some weeks ago - might be related to Australia being distant?
Quote from: hutch-- on September 02, 2022, 07:38:42 PM
JJ,
What have you zipped that file with, neither Slimjet or Chrome download a valid zip file.
Please try again (http://masm32.com/board/index.php?topic=10292.msg112869#msg112869), Hutch
I solved it, it was a PNG file with a ZIP extension. My Winrar would not open it as it was not an archive file.
P#1 P#2
r0c0 r2c2
r0c2 r0c1
r2c0 r1c0
r1c1 player won
Does anybody know a sequence that allows player #2 to win?
I codee the last game of this type back in the early 90s so I am a bit rusty here but from memory the options are deterministic and exhaustive. If it uses a logic where each of the 9 squares can be turned on but not off with either a nought or cross, then the testing can only be one of a limited number of combinations. Whoever makes the first move has the advantage but the second player can always force a draw.
Effectively, 8 combinations for either noughts or crosses so only 16 checks of 3 locations to determine a winner or a draw.
Quote from: jj2007 on September 02, 2022, 09:58:38 PM
P#1 P#2
r0c0 r2c2
r0c2 r0c1
r2c0 r1c0
r1c1 player won
Does anybody know a sequence that allows player #2 to win?
If P#1 first and second move are on a diagonal and P#1 third move is perpendicular to both his first and second moves, P#1 always wins, regardless of what blocking moves P#2 makes...since there exist more than one place where P#1 can win after P#1s third move, and P#2's second move. (More than one blocking move)
Its known in scientific circles as "The Tic Tac Toe Paradox"
TM :tongue:
Unless P#2 cheats of course. :badgrin:
More concise explanation. If P1 first three moves are on 3 corners of the grid, by this time there are two places he can win (after P2's first two moves). No matter which corners P1's pieces are in, and regardless of P2's moves.
So therefore it is a great advantage of being the first player in a round. So maybe winner plays next game first, is not a very good idea (at least from losing players perspective)
So maybe the starting player for each round should alternate regardless who won previous round? Then actually the game is pointless, if both players know what 'best moves' to make for their first three moves. First player would always win in that scenario - no matter which side plays first.
But still makes a good coding exercise.
Edited for clarity and articulation. :biggrin:
I just found out something funny. When I was playing around with static controls here, there was one time where I created a static control in a window, but the static control did not appear in the window. I spent a good half hour or more, scrutinizing the code and running it in olly.
Earlier today I had a similar issue. I was floored when I found out the cause....
I had forgotten I had 'or SS_BITMAP' in the window style. Apparently the static is created with a transparent background in that instance or same color as main window. :rolleyes: Oops.
Sounds like code written by the Invisible Man.