It seems to be all the rage to create yet another editor for assembly code, so here's mine.
This is what I accomplished in a couple sittings over one day. It's not an editor yet, no open or save, but you can check out some features. Everything on the tool list at the right is implemented; try it out. You'll see what those buttons do.
"Cubbyholes"? That's my idea for a set of "bins" where you can stash bits of text and do the following by clicking on a button (4 buttons/bin):
- Paste the text into the editor
- Search the editor text in either direction
This would solve the frustrating problem of Notepad (and many, if not most, other editors) of only being able to hold one item at a time either on the clipboard or as a search term. I regularly want to be able to look for and paste 3 or 4 bits of text at a time.
This is just a fun project at this point; no delusions about making a "real" editor out of it. (For one thing, it's just a basic Win32 edit control with a bunch of fancy stuff attached to it.) OTOH, who knows? I could probably come up with something a whole lot better than Notepad if I stick to it.
I'd appreciate any comments about the interface design, and suggestions for improvement. Not talking about the appearance so much as the functionality and behavior. Thanks!
In case anyone's wondering, that tool list is based on a listbox, using custom draw and notifications, and some attached child controls (buttons). So the listbox cells act as buttons. One thing that isn't so good is that there's no feedback when you click on a cell to insert its text. Maybe buttons would be better? But it does make for nice easy programming. I could "flash" the cell (change FG & BG colors) momentarily to indicate it being clicked. Let me know your ideas.
Quote from: NoCforMe on September 03, 2022, 06:54:23 AM"Cubbyholes"? That's my idea for a set of "bins" where you can stash bits of text and do the following by clicking on a button (4 buttons/bin):
- Paste the text into the editor
- Search the editor text in either direction
This would solve the frustrating problem of Notepad (and many, if not most, other editors) of only being able to hold one item at a time either on the clipboard or as a search term. I regularly want to be able to look for and paste 3 or 4 bits of text at a time.
MS Office has the multiple clipboard feature. Sounds good, actually, I might steal the idea :biggrin:
Re multiple search terms, in RichMasm you just hit Ctrl F, then arrow up (or down) to scroll through the last 9 search terms used. They are stored with the document, so when you reopen it, these 9 search strings are still there. Another feature: select any word and hit F3 to find all matches.
Btw I can't see the caption of your editor, and there is no way to move it into visibility. Congrats, you have a nice high resolution monitor! You may consider this:
invoke SystemParametersInfo, SPI_GETWORKAREA, 0, addr rc, 0
Quote from: NoCforMe on September 03, 2022, 06:54:23 AMIt seems to be all the rage to create yet another editor for assembly code...
In keeping with the trend, I'll release in the next day or so "SaMe editor" - otherwise knows as "Still another Masm editor" :biggrin:
Or then again, maybe not.I do have code though, for a coupla editors...
Quote from: jj2007 on September 03, 2022, 07:10:56 AM
Btw I can't see the caption of your editor, and there is no way to move it into visibility. Congrats, you have a nice high resolution monitor! You may consider this:
invoke SystemParametersInfo, SPI_GETWORKAREA, 0, addr rc, 0
Thanks. That sounds like just the thing. Easily done.
Quote from: swordfish on September 03, 2022, 07:44:53 AMIn keeping with the trend, I'll release in the next day or so "SaMe editor" - otherwise knows as "Still another Masm editor"
I recommend TinyIDE - a 7,168 byte editor for *.asm, *.asc and *.rtf files (http://masm32.com/board/index.php?topic=10254.0). Source included, 1,100 lines of purest Masm32 SDK :thumbsup:
Quote from: jj2007 on September 03, 2022, 08:52:14 AM
Quote from: swordfish on September 03, 2022, 07:44:53 AMIn keeping with the trend, I'll release in the next day or so "SaMe editor" - otherwise knows as "Still another Masm editor"
I recommend TinyIDE
Thanks, but...
Oh, yeah I've got SimplEd. A dialog box based richedit editor. Have made a lot of additions and enhancements to it, mostly for formatting code in my particular (peculiar?) style. Another one that is the base code for one of my plugin builder (for qeditor) programs, and a coupla two or three more editors that are less noteworthy unless I've already sent them to the circular file so to speak.
I may post those that I have code for still, at some point after I make it ready. I.e., add commenting for the most part, and format it to be readable by most* and make it user-friendly. I was only kidding about the SaMe editor. :tongue:
Can't remember which one, but one of my editors highlights (change text color) whatever string is searched for when it's found. It doesn't support .rtf so the color change is only visible until file is closed. At some point I experimented with code highlighting. Registers and variables. Don't think I have that anymore though.
Do you actually like Qeditor? I just tried it. Seems clunky, weird. Tried a bunch of the "tools", most of which offer no explanation of how they work (tried swapping 32-bit registers, it kept telling me that "x is not in selection" WTF???
All in all, it smells like a hobbyist-built project (yeah, like a lot of my stuff) with a lot of clever doodads hanging off it but maybe not the best user interface. Thing is, I don't try to pass off my creations as high-quality, untuitively useful tools.
So you can add plugins to it? How does that work?
Quote from: NoCforMe on September 03, 2022, 09:46:33 AMSo you can add plugins to it? How does that work?
Basically, you write a DLL that gets loaded by qEditor, with access to some essentials, such as the handle of the riched control. See also COM interface plugin (http://com%20interface%20plugin) (same principle, but for another editor).
Quote from: NoCforMe on September 03, 2022, 09:46:33 AM
Do you actually like Qeditor? I just tried it. Seems clunky, weird. Tried a bunch of the "tools", most of which offer no explanation of how they work (tried swapping 32-bit registers, it kept telling me that "x is not in selection" WTF??
For the 'Swap 32 bit registers' plugin and most others, you're supposed to select the code you want to change first; then select the 'Swap 32 bit registers' (or other) from the menu; then select whatever registers you want to swap; then click the 'swap' button in the case of 'Swap 32 bit registers'. And yes I like qeditor.
edit = typos
David,
Code editors are like girlfriends, you pick what you like if it works for you. QE is a pure ASCII editor, programmable menus up to the limit of screen space, a scripting engine that actually works and it can routinely open files over 100 megabytes. Like any tool, you need to learn how it works but it does what I wrote it to do, create and edit assembler code. The programmable menus give you access to as many other tools as you need and it is FAST. :tongue:
The new 64 bit version will do most of the same thing but will open over 700 megabyte files.
Here's a new version. This is mainly to show how "cubbyholes" might work. (I couldn't think of a better name for them.) There are 5 slots which can hold text. The 4 buttons are for copy, paste, search down and search up. Only the 1st buttons work; they just copy some text into the cubbyhole to prove the concept works.
The idea is you can select text, then click on the Copy button to put that text in the cubbyhole. Then you can paste it by clicking that button, or search in either direction with the other 2 buttons. It's a lot of buttons, yes, but everything's right there on screen without having to open dialogs or menus.
This marks my first-ever use of Unicode. The odd characters in the buttons are Unicode (the three-line character is officially known as the "trigram for heaven", from the I Ching, I guess).
I'm not ready to go full Unicode; I'm too used to typing
ButtonClassname DB "button", 0
where I had to do this to get a Unicode window (with CreateWindowExW() ):
ButtonClassname DB 'b',0,'u',0,'t',0,'t',0,'o',0,'n',0,0,0
Not ready for that yet. Yeah, I know there are macros for this stuff, or I could roll my own. But it's a pain in the ass.
Yes, I know there's a problem with the resizing code here; the status bar gets covered up. We're working on it here at NoCforMe Laboratories, GmbH. (Resizing is tricky!)
Here's your unicode string:ButtonClassname DW 'b','u','t','t','o','n', 0, 0 ; UNICODE == unicorn. :biggrin:
DW instead of DB. edit to add --> I just tested it, it works.
I like "cubby holes". It sounds better than "pigeon holes", for instance.
Ah, 10 points to you. Didn't think of that. Probably how the macro would work. (You only need one pair of zeroes at the end.)
A plugins might help to make those UNICODE strings, as masm don't support those strings in native way, like asmc, UAsm and poasm.
Quote from: TimoVJL on September 03, 2022, 09:57:50 PM
A plugins might help to make those UNICODE strings, as masm don't support those strings in native way, like asmc, UAsm and poasm.
Did someone say 'plugin'? Hehe. :biggrin: Good idea, I think I'll make one for converting ascii to unicode. :cool:
Time to break out my PluginBuilder. :cool:
Z,
Be a bit more ambitious, conversion from ascii to unicode will only handle the same characters set as ascii, see if you can add the capacity for real unicode which would be a lot more useful.
Quote from: hutch-- on September 04, 2022, 12:00:22 AM
see if you can add the capacity for real unicode which would be a lot more useful.
For a one-off like in NoCforMe's example, this method is fine - which brings to mind...
NoCforMe, why on earth do you need a single Unicode string, if you don't mind my asking??
Quote from: swordfish on September 03, 2022, 07:30:07 PM
Here's your unicode string:ButtonClassname DW 'b','u','t','t','o','n', 0, 0 ; UNICODE == unicorn. :biggrin:
DW instead of DB. edit to add --> I just tested it, it works.
I prefer editor that can keep this in source:
"一二三四五六七八九十百千萬"
VS editor detects unicode characters asks if save as Unicode source file or not and losing it
you can use only numbers,but its easier to debug when cjk unicode is many thousands to see if its the right character and not wrong because of typo when entering 16bit hexadecimal number
also I dislike need to use the annoying syntax 'a','b','c','d','e','f',0 when I want good old string syntax "abcdef",0 indepent of ascii or unicode
otherwise I like use Qeditor,but I doubt I need to use 700mb,maybe open a video file in hex?
Quote from: daydreamer on September 04, 2022, 12:28:32 AM
I prefer editor that can keep this in source:
"一二三四五六七八九十百千萬"
Me too :thumbsup:
Quote from: swordfish on September 03, 2022, 07:30:07 PM
Here's your unicode string:ButtonClassname DW 'b','u','t','t','o','n', 0, 0 ; UNICODE == unicorn. :biggrin:
DW instead of DB. edit to add --> I just tested it, it works.
I like "cubby holes". It sounds better than "pigeon holes", for instance.
Hi swordfish,
You can try the WSTR macro to easily define Unicode strings.
include \masm32\include\masm32rt.inc
.data
WSTR mystr,"This is a UNICODE string."
.code
start:
invoke crt_wprintf,ADDR mystr
invoke ExitProcess,0
END start
Thank you, Vortex. I knew there was a macro for that, somewhere. But it's not really for me but for NoCforMe.
Thanks again.
I just slapped together that piece of code on the fly, as an example. I rarely if ever had the need for Unicode.
Quote from: swordfish on September 04, 2022, 12:23:07 AM
For a one-off like in NoCforMe's example, this method is fine - which brings to mind...
NoCforMe, why on earth do you need a single Unicode string, if you don't mind my asking??
Don't mind at all. In order to display Unicode characters in some controls (buttons), I had to do two things: encode the character strings as Unicode,
and encode the class name ("button") as Unicode, since I was using
CreateWindowExW() instead of
CreateWindowEx(). Unicode window to handle Unicode text. See, when you travel to the Unicode world, everything has to be in that "language", every string and character.
@NoCforMe, ok.
But why W version instead of A? Or was that just a coding exercise on your part?
Vortex posted a Unicode macro couple of posts above this one if you missed it.
Jochen, in your reply #7 you were going to give us a link to a "COM interface plugin", but the link wasn't given. Curious minds want to see it ...
Quote from: swordfish on September 04, 2022, 04:48:11 AM
But why W version instead of A? Or was that just a coding exercise on your part?
Because you need a Unicode ("W") window to display Unicode characters.
Somewhere I missed that part, where you wanted to display unicode. Sorry. :undecided:
I should've gone back and reread everything.
Quote from: NoCforMe on September 04, 2022, 04:48:59 AM
Jochen, in your reply #7 you were going to give us a link to a "COM interface plugin", but the link wasn't given. Curious minds want to see it ...
Oops (http://masm32.com/board/index.php?topic=6313.msg71823#msg71823)
Quote from: jj2007 on September 04, 2022, 07:32:18 AM
Oops (http://masm32.com/board/index.php?topic=6313.msg71823#msg71823)
Oop = Object oriented programming? :tongue:
:biggrin:
OOP(s) versus HOP (Hardware oriented programming). :tongue:
Here's the latest version (about 3 day's work so far) that can load and save files. (Be careful! don't want anyone to lose anything valuable because of this. It did work fine for me, but I'm still testing it.) Few more features added. A loooooong way to go before it's a real editor, if that ever happens ...
Let me know whatcha think. JJ, I smallerized it so it might fit your screen; your advice about getting the monitor work area is good, but it was all I could do at this point to make it resize reasonably. (You'll notice that you can shrink it vertically so that the listbox on the right disappears; not good.)
Note: I replaced the .zip with a version that increases the maximum text limit to 2 Mb.
Hi David,
Works fine here, the font is a bit small for my eyesight but its clean and clear. It will be interesting when you get more of it done.
Quote from: NoCforMe on September 05, 2022, 04:06:35 PMJJ, I smallerized it so it might fit your screen; your advice about getting the monitor work area is good, but it was all I could do at this point to make it resize reasonably. (You'll notice that you can shrink it vertically so that the listbox on the right disappears; not good.)
Works fine now :thumbsup:
Hutch--sorry 'bout that. I guess I need to work on the "adaptive" version for those with less than eagle-eye vision. (Kinda just joking, actually. Probably won't happen.)
So, idea: What would you think about an editor, such as mine here, that would be configurable by the user? I'm thinking about all those dingleberries I put in there, all the "inserts" you can use. Obviously they're tailored to the way I program, which is certainly not the way everyone else does. I was thinking about making a configuration editor that would let you put in the items you want to use. They could be stored in a text file and loaded with the editor. Would that be worth doing?
The only things that probably couldn't be configured are the "editable items", like PUSH/POP which have specific dialogs to deal with their editable elements (like choosing the register). Everything else could be done, though.
David,
What I do in both of my editors, QE and the new 64 bit one is to write a couple of settings files, one for binary and the other for test and between them you can store a lot of settings. I would recommend avoiding the registry as you lose portability if you put settings in the registry. It makes sense to put the settings files in the same directory as the editor as you can routinely keep track of them when the editor is started from other directories or drives.
Simple programmable menus are easy enough to do but complex ones that start multiple file types are nightmares to code and you have to build it into the editors base architecture. It can be done but its a lot of work and even more testing.
Local ini-files are usable in network usage, as they can share predefined paths and settings.
My previous life factory used programs from local network and nothing didn't installed for user / user group / working point ...
It was always easy to make a local copy of program or shortcut with own settings.
Oh, I know how to do this. Planning on it, actually. The configuration file (a plain text file, naturally, not binary, so easily edited) will reside in the same folder as the executable. The executable will locate the file by getting its home folder (using GetModuleFileName() ), read it and populate its internal structures.
I'm even going to have a built-in configuration editor in the program so you don't have to edit the config file. Write the values to the config file (mostly text strings). I've done this before, and it works well.
For inspiration (http://masm32.com/board/index.php?topic=10130.0) :cool:
My preferred format for this type of file is
configItem = configValue
Easily parsed and edited.
Sections can be headed by
[sectionName]
Useful API functions
WritePrivateProfileString (https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-writeprivateprofilestringa)
Quote from: NoCforMe on September 07, 2022, 05:58:52 AM
My preferred format for this type of file is
configItem = configValue
Easily parsed and edited.
Sections can be headed by
[sectionName]
Not so far from my format (http://masm32.com/board/index.php?topic=10130.0) ;-)
*** The first line can be edited manually ***
crtDate=06.09.2022
crtTime=23:41:46
modTime=06.09.2022, 23:44:20 ; this is the time of the last modificationI haven't thought of the [sections], though (you can add them manually, of course). Apart from readability, are their other good reasons to have them?
Yes, and it's not because of readability, and it's also why I can't use the suggested Write/GetPrivateProfileString(): there will be sections, and within these sections multiple items with the same subsection heading, like so:
[inserts]
[insert]
displayText="PUSH/POP"
insertText= [expanded form that'll get inserted]
[insert]
displayText="CreateFileEx"
insertText= [expanded form]
etc. ...
I could just have pairs of strings (display/insert), but I prefer to make it a bit more formal and have a subheading for them. Easy to do in any case.
I've also done this in the past:
[inserts]
insert (
displayText="PUSH/POP"
insertText="<expanded text>"
)
insert (
dsplayText="CreateWindowEx"
insertText="<expanded text>"
)
etc. ...
but I think I'll make it a bit simpler this time. After all, this isn't really a programming language.
I've been creating and parsing such files since the 1980s, so it's not difficult for me.
For an .ini file I could use the form you suggested. This is a .cfg file, not an .ini file. (The .ini will have stuff like the last window size, the selected font, etc.)
Oh, and of course because this is an ASM tool, all comments in my config/initialization files are preceded by ';'.
Quote from: NoCforMe on September 07, 2022, 08:21:04 AM
[inserts]
[insert]
displayText="PUSH/POP"
insertText= [expanded form that'll get inserted]
[insert]
displayText="CreateFileEx"
insertText= [expanded form]
etc. ...
Look like JSON could be a good format.
Quote from: NoCforMe on September 07, 2022, 08:21:04 AMThis is a .cfg file, not an .ini file.
Do you have an example where cfg and ini behave differently?
Yes, my own software.
Config files are for user-configurable stuff; in the case of this editor, it's (most of) the content of the "tool list" on the right, mostly insertable text. For instance, if you click on "CreateFileEx", you get a template for that function. The "goodies" dialog has a bunch more stuff.
Initialization files are for stuff used internally by the program: window size, selected font, etc.
Quote from: NoCforMe on September 07, 2022, 09:18:34 AM
Yes, my own software.
Config files are for user-configurable stuff; in the case of this editor, it's (most of) the content of the "tool list" on the right, mostly insertable text. For instance, if you click on "CreateFileEx", you get a template for that function. The "goodies" dialog has a bunch more stuff.
Initialization files are for stuff used internally by the program: window size, selected font, etc.
What I mean, David, is: what is the difference when working with them?
Wiki ini file (https://en.wikipedia.org/wiki/INI_file#Example):
; last modified 1 April 2001 by John Doe
[owner]
name = John Doe
organization = Acme Widgets Inc.
[database]
; use IP address in case network name resolution is not working
server = 192.0.2.62
port = 143
file = "payroll.dat"Wiki cfg file (https://en.wikipedia.org/wiki/Configuration_file#MS-DOS):
DOS=HIGH,UMB
DEVICE=C:\DOS\HIMEM.SYS
DEVICE=C:\DOS\EMM386.EXE RAM
DEVICEHIGH=C:\DOS\ANSI.SYS
FILES=30
SHELL=C:\DOS\COMMAND.COM C:\DOS /E:512 /PThe ini file has the [owner] and [database] sections, but apart from this minor detail, I can't see a difference, format-wise.
See also the formats table here (https://github.com/intel/cve-bin-tool/issues/832), comparing various config file formats.
David,
While putting strings into a text file makes sense, rather than have to convert numbers both ways, having a structure of your own design with as many numbers as you wish to preserve as structure members is fast to load, save and internally process. This is why I use a binary file for numbers that must be preserved.
Quote from: jj2007 on September 07, 2022, 09:27:48 AM
What I mean, David, is: what is the difference when working with them?
The ini file has the [owner] and [database] sections, but apart from this minor detail, I can't see a difference, format-wise.
No, you're right: format-wise they're very similar. Can use most of the same parsing code.
Quote from: hutch-- on September 07, 2022, 09:50:24 AM
While putting strings into a text file makes sense, rather than have to convert numbers both ways, having a structure of your own design with as many numbers as you wish to preserve as structure members is fast to load, save and internally process. This is why I use a binary file for numbers that must be preserved.
Thanks for the suggestion. Since it's so trivially easy to convert numbers either way, I prefer to use plain text. Conversion time isn't an issue (for me, anyhow). But I'm sure your way would work well for someone in a different situation.
Quote from: NoCforMe on September 07, 2022, 10:00:19 AM
Since it's so trivially easy to convert numbers either way, I prefer to use plain text.
With Windows native ini-files
GetPrivateProfileInt (https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getprivateprofileint)
Here's the latest and greatest, for anyone who's still following this project.
This version is fully configurable by the user, at least so far as the items in that listbox (the "tool list", I call it) goes. There's an attached configuration file that's read on startup; the tool list is populated from this file. All seems to work well at this point. I'll be posting some source code soon.
There are 3 sections to the tool list:
- "[Inserts]" (click on the listbox item and that item gets inserted into the edit text)
- "[Goodies]" (click on the "Goodies" listbox item and a dialog opens; click on any item in the mcListbox* control to select it.
- "[Cubbyholes]": hold text for copying/pasting/searching
The sections can be arranged in any order, so you can have the "cubbyholes" where you prefer them. Currently the listbox doesn't scroll; that's coming soon, to be able to handle a long list.
Currently you can copy and paste. Search is not yet implemented. (That'll happen when I switch to a RichEdit control.) Select text, click one of the "C" buttons to copy text to the cubbyhole; click the "P" button to paste that text. (This is separate from the edit control's cut/copy/paste functionality, which works as well.)
You need to have the config file in the same folder as the program (the program should find it wherever you run it from). If there's a parsing error, only the cubbyholes will be created. You can play around with the config file, add the items you like (there's a text file explaining the config file format, which is pretty simple).
I'm particularly happy with my parser here: it's robust, simple (no spaghetti tangle of conditionals & jumps), and handles text well: it preserves the content of your "insert" text: CR, LF, tabs all come through. Allows embedded quotation marks in text (use double double-quotes, like "This ""text"" has embedded quotes"). And it allows comments! (starting with ';', since it's an ASM editor).
* The mcListbox (multi-column listbox) is my custom control used in the Goodies dialog. Still under development but works well.
Works fine :thumbsup:
- What's the difference between inserts and goodies? I can't see any...
- The exit dialogue is dangerous. In RichMasm, I use "Save changes?", with Yes (default), No, and Cancel. Given that the exit/close key is VK_ESCAPE, and an Escape in that dialog means Cancel, it has never ever failed me: You need to say explicitly NO to lose your data.
My 2cts ;-)
Quote from: jj2007 on September 10, 2022, 06:35:44 AM
- What's the difference between inserts and goodies? I can't see any...
Basically their location. The idea is to put more commonly-used items in the listbox itself, and have numerous other items in the Goodies dialog. Otherwise you're right, they're just insert items.
Quote
- The exit dialogue is dangerous. In RichMasm, I use "Save changes?", with Yes (default), No, and Cancel. Given that the exit/close key is VK_ESCAPE, and an Escape in that dialog means Cancel, it has never ever failed me: You need to say explicitly NO to lose your data.
Good point. I was actually wondering about that as I was clicking "yes" on that dialog when testing.
Yikes.
I tried adding a vertical scrollbar to the listbox, so you can have more stuff than will fit on-screen. What a disaster! Run the attached version and try scrolling and see what happens.
Anyone have any idea what's going on here? Keep in mind that the listbox has a lot of children (the cubbyhole buttons). But it should take care of them, right? If you click somewhere when the control looks all messed up it'll redraw itself correctly.
This looks unworkable to me, unfortunately.
Yes, something is seriously messed up.
Btw C P I understand, but what are the ? :arrow_down: and ? :arrow_up: good for? Ok, fine :thumbsup:
Re inserts & goodies, in RichMasm I have:
a) "fast inserts" like e.g. typing .rep<space>inc ecx
b) the AutoCode menu: one click to insert a piece of formatted code (your goodies require three clicks - too many for my taste)
Most of the time I use the typing. It's definitely faster, but one must memorise the shortcut.
Search down and search up (currently unimplemented). That's where I was hoping to use that magnifying-glass character we were playing with before. Something that looks like "find".
Regarding that horrible scrolling action, I guess I could consider handling scrolling myself, since I've already got the listbox subclassed. Maybe using ScrollWindowEx() (https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-scrollwindowex)? (Although isn't this what Windoze is already doing behind the scenes?) It has an option (SW_SCROLLCHILDREN) to scroll children along with the window.
More weirdness; check out the attached .exe. Click on the scrollbar buttons (I'm only handing SB_LINEUP and SB_LINEDOWN) and watch the parade of buttons. I used the SW_SCROLLCHILDREN flag with ScrollWindowEx(), and boy does it scroll them children, but not the parent. Not quite what I had in mind.
Does anyone have a clue what's going on here, and how I could possibly scroll this control (listbox)? I can't be the only person in the world who ever tried to do this. Time to look on the interwebs (CodeGuru, Stack Overflow, etc.) I guess.
Here's an idea: all the trouble seems to be with those damned buttons; the listbox itself scrolls fine and dandy. So how about if I somehow intercept the listbox scroll messages and explicitly move the buttons by hand, hopefully synchronizing them with the listbox? It would be a pain in the butt, but could it work?
I've been thinking about this: if I could figure out how far the listbox has been scrolled, I could move all the buttons by that amount. But how do I know when and how far the listbox has been scrolled? WM_VSCROLL doesn't tell me that.
Why are these buttons kids of a listbox? They should be independent controls imho...
I don't think so, JJ, for a couple reasons: by making them children of the listbox, I can easily get all their messages (BN_CLICKED) through the (subclassed) listbox proc. (You don't even need to set BS_NOTIFY to get these.) Otherwise I'd have listen to all 16 or 20 buttons individually. Also, how would you move them, or even place them in the control to start with? No, I'm sure this is the right approach. It's just that scrolling that's a problem.
Progress.
I solved the messed-up-buttons-scrolling-with-the-listbox issue by sidestepping it. (I never did solve the problem of scrolling the listbox with the buttons attached to it as its children.) Instead, the cubbyholes are now in a static control container that's always at the top (yeah, it would be nice to make its position configurable, but too bad for that). The listbox, if there is one (assuming the config file is present and was parsed correctly) starts below it. And it all works! The listbox even scrolls correctly (try resizing the window vertically and see what happens).
Phew! I went through so many gyrations to get this to work. When I first created a static window and put the buttons inside it, they worked OK, except they had an ugly white border around them where the edge wasn't getting painted the background color of the static. I tried catching WM_CTLCOLORBTN and passing a brush the color of the background; no go. (All the while I was scouring the web for advice. Found lots of stuff on Code Project and Stack Overflow and others, but nothing that worked.)
Then I tried going the owner-draw route. Ugh. What a goddamn can of worms that is. At first I could only get the ugly pre-Vista looking buttons--remember, all square? Then I started delving into ... oh nooooooo ... themes. That's really a squirming, festering can o'worms. I was actually able to get to the same point I was before I started: buttons with the new look (no text, since I'd have to draw that myself) but still with the damned white border! And of course, to use any of the theme stuff you have to find the right DLL, use LoadLibrary() and GetProcAddress(), and then a bunch of push-push-calls because nobody ever got around to adding this stuff to our Masm32 libraries, even though it's been, what? 10-12 years ago that this stuff came out?.
Oh, and I almost forgot that at one point I was wrestling with the "theme" stuff (OpenThemeData() specifically), just couldn't get it to work at all, when it dawned on me that maybe those functions need Unicode names, not ANSI; sure enough, that was the problem.
Then I found a little something that worked: in addition to catching WM_CTLCOLORBTN, you need to catch NM_CUSTOMDRAW notifications (which is odd, since it's no longer an owner-draw control); when the dwDrawStage = CDDS_PREERASE (and the moon is in the right phase and it's a month with an "R" in it), you do a FillRect() of the button using the background color. Which fixes it. No owner-draw needed, just a little subclassing.
What a mess Win32 is ...
Anyhow, try this version out. I promise I'll start making some substantive progress soon (switching to a RichEdit control so I can add search and replace, which no self-respecting editor can be without).
Works fine :thumbsup:
Some points for consideration:
- I like the idea of a multiple clipboard, but I'll rarely need more than one extra copy
- Are the up/down arrows for searching for each cubby hole really needed? For comparison, see another solution below; to start a search, either type the word in the Find box, or select a word in the main window and hit F3.
- The listbox has [Inserts] on top, but when you scroll down, it disappears.
- Goodies at the end does not show unless you scroll down.
IMHO both Inserts and Goodies should be separate push buttons. Another solution is to put the Insert into a menu: thus, no listbox claiming precious space. The bookmarks below to the right cost space, too, but in my experience they are a better investment than a menu of inserts that I need only occasionally.
My 2cts ;-)
All good points. I'm going to have to wait until I actually start using it to see what I like. Like a saying (title of a song): You won't know until you find out.
"[Inserts]" at the top is just a heading. You could put Goodies at the top by editing the .cfg file. (Someday there'll be a built-in config editor ...)
I've been busy. Here's the latest version. It has:
- Printing (you can select a different font for printing, in Format--> Printer Font)
- Full search & replace (you can also search from the "cubbyholes")
- Bookmarks (well, one set; use menu icons at top)
- Uppercasing/lowercasing (menu icons)
Still lots of unfinished stuff:
- Save/restore to .ini file (under construction)
- Print formatting: margins, header & footer
- Turn word wrap on/off
- Put filename in window title bar
- Popup context menu in edit window
The .ini file will save the current font (face, size, etc.), and the window size & position.
It's got to be smarter than the stupid stupid scheme used by Notepad. Drives me nuts: even if you have multiple instances open, if you change the font in one and close it, even though there are several more open, it changes the font to what you had the next time you open a new instance. Stupid.
My idea: keep track of how many instances are open, and only save the .ini values when the last one is closed. (There could even be some options to control how this works.)
Bookmarks: The bitmaps are pretty fugly, I know; my meager attempts at hand-antialiasing. And there's only one set: I was thinking of something like the Cubbyholes for multiple bookmark setting/going-to buttons.
I learned a lot about RichEdit controls coding this.
I've actually been using the editor, and I kind of like it. Takes some getting used to (I've been using Notepad for far, far too long ...) And of course I can't really use it yet to develop itself, since I can't make a new .exe while the old one is open.
So let me know if you have any brilliant ideas on how to improve this. Also, play around with the configuration file, add some stuff of your own.
Hi David,
It seems to run OK on my Win10. The "Inserts" list works OK but the font is being clipped by the container. You may have to specify a font size that fits the line spacing.
Hutch, thanks. If you have a spare moment (!!!), could you maybe post a quick screen shot? Trying to remove as much fugliness from this as possible. (Chrome is so important, dontcha think?)
:thumbsup:
- printing works fine
- word wrap doesn't
- bookmarks apparently not (?)
- statusbar should be reset ("bookmark set" and "Printing page 5" remain forever)
Quote from: jj2007 on September 21, 2022, 09:45:30 AM
- word wrap doesn't
- bookmarks apparently not (?)
- statusbar should be reset ("bookmark set" and "Printing page 5" remain forever)
Word wrap "TBD". Pardon our dust.
Bookmarks should work: first one sets it (status bar says so), second one jumps to it.
Yes, that damn status bar. Need to figure out when to clear it.
Thanks for the QC check.
I've fixed some of the issues you pointed out, JJ. Plus added a bunch more stuff. That works! (Well, at least with my limited testing.)
New stuff:
- Expanded bookmarks! Four of 'em. These are really handy.
- A find dialog which opens from the menu or with Ctrl+F. F3 does a "find again" (need to fix it so F3 opens the dialog initially if it hasn't already been.)
- Printing header works; you can put in date, time, filename, page #, just like Notepad (same syntax). Footer not implemented yet (you can fill it in, it just does nothing.) Soon.
- I clear the status bar anytime the user makes a selection in the edit window.
- Filename shown in title bar
Oh, and I saved the best for last: it now writes an .ini file that saves important stuff: font faces & sizes, window size & position, print header & footer, etc. Will always write the file in its "home" directory, no matter where you run the program. (This needs tested, but works for me fine so far.)
Still lots on the to-do list: Print margins (ugh), open files from command line, popup editing context menu, and I promise I'll get that word-wrap option done. Soon.
I'm sure someone will find a bug or three. Still in all, I'm pretty happy with it.
There's no .ini file in the zip, but it'll write one the first time you close it.
I'll post my code soon for those who are interested. (Source file is now ~170 Kb)
(Note: .exe has been updated with fixes for problems found by JJ below)
Quick and dirty:
- on first launch, it looks like in the attached image, and the font is 1 point tiny (ok on second launch)
- dragging a file over the exe doesn't work - commandline ignored
- compare bookmarks Goto to RichMasm behaviour
- bookmarks are gone when you reopen the file
- in the find dialog, cancel doesn't work
Sorry 'bout that: standards have been dropping here at NoCforMe Laboratories, GmbH; I had to fire the person who was supposed to have tested this release. (Just kidding.)
Fixed the tiny window problem (I was checking for the wrong return value after trying to open the .ini file, and never tested it without the file), and the no Cancel in the find dialog (that's what happens when you have two buttons both set to IDOK).
I hadn't planned on saving bookmarks, as they'd have to be tracked to a particular file. Do you reload yours in your editor? How do you save them? I probably won't do that.
Planning on having opening files from command line Real Soon NowTM. Updated .exe in previous post up there.
Quote from: NoCforMe on September 24, 2022, 07:47:44 PMI hadn't planned on saving bookmarks, as they'd have to be tracked to a particular file. Do you reload yours in your editor? How do you save them? I probably won't do that.
For *.asc files, I save them embedded in the rtf code, i.e. they are permanent.
For plain test *.asm files, they are generated on opening the file, i.e. individually set bookmarks are lost when closing the file.
Note your current version doesn't adjust the bookmark position when the user inserts text.
Quote from: jj2007 on September 24, 2022, 09:11:48 PM
Note your current version doesn't adjust the bookmark position when the user inserts text.
Yes, I noticed that and it bothers me too; the bookmark changes position when text is added or deleted. I use
EM_GETSEL to get the current selection or position. But that position has got to change as the text in the control changes. How do you "anchor" a bookmark to a particular piece of text?
I suspect a lot of the functionality you have in your application is because you're actually exploiting a lot more of the capabilities of RichEdit. For me, it's just a convenient place to hold ANSI text. At least so far ...
Something else I noticed is that the character count I get from RichEdit (using
EM_GETTEXTLENGTHEX) isn't accurate. (And I am using the
GTL_PRECISE flag.) Close, but no cigar. I think it's because of how the control counts line endings (CR/LF). The number is definitely different from the actual file size.
Quote from: NoCforMe on September 24, 2022, 09:44:57 PMHow do you "anchor" a bookmark to a particular piece of text?
Hidden text, plus a table that gets adjusted when EN_CHANGED occurs.
Quote from: NoCforMe on September 24, 2022, 09:44:57 PMSomething else I noticed is that the character count I get from RichEdit (using EM_GETTEXTLENGTHEX) isn't accurate.
RichMasm:
movi tlex.flags, GTL_PRECISE or GTL_NUMCHARS ; this combi 5,000x faster than with either GTL_USECRLF or GTL_NUMBYTES!Internally, the richedit control uses CR, not CRLF.
For ASCII / ANSI / text source code needs a common style for bookmarks in commented text.
Quote from: TimoVJL on September 24, 2022, 11:30:32 PM
For ASCII / ANSI / text source code needs a common style for bookmarks in commented text.
What do you mean, exactly? Can you give an example?
OK, you know what? I've decided: I ain't going to expand bookmarks to do what you're discussing (tracking changes). That's far beyond the scope of what we here at NoCforMe, GmbH had hoped to accomplish with this project. Good enough is good enough; going to a bookmark will at least get you in the neighborhood of where you were when you dropped it.
If this were a commercial product then I'd look into more accurate bookmark targeting. But it's not.
Newest version opens file from command line ("open with" from Explorer) or from file dropped on shortcut.
Please be careful if you use this. I've tested it, have never crashed it, but I'd hate for anyone to lose important files.
Comments always appreciated.
Works fine :thumbsup:
Quote from: NoCforMe on September 25, 2022, 02:27:27 PM
Newest version opens file from command line ("open with" from Explorer) or from file dropped on shortcut.
Please be careful if you use this. I've tested it, have never crashed it, but I'd hate for anyone to lose important files.
Comments always appreciated.
It would be nice if you could consider adding version information and a changelog. So we(and you?) can track EdASM's development history.
Well, my development process isn't anywhere near that formal. However, I do have a change log of sorts in the source, which I'm going to post here soon, probably later today.
Thanks for your interest.
David,
Put the version number/data in the about box, easy way to track different versions.
Bingo. That's exactly my level of version control.
Quote from: hutch-- on September 28, 2022, 11:28:33 AMPut the version number/data in the about box, easy way to track different versions.
Indeed, an absolutely clear, non-ambiguous way to "number" your software. Compare that to the nightmare of Firefox or recent MASM versions :cool:
You mean you don't appreciate Version 18.302.90001.1.B3.X.27895? Makes me feel so much more secure ...
As promised, here's the full "package" (compile-able) with source, for those who want to take a look under the hood.
It's actually not finished, of course (will it ever be?), but it is fully functional and robust (have never crashed it).
Have fun with it. And if you use it, be sure to customize the "inserts" and "goodies" to your liking.
This looks amazing!
I remember those handdrawing pictures.
Looks good so far. :thumbsup:
Tmp_File.asm(58) : Error A2106: Cannot open file: "..\mcListbox\mcLB.inc" [ENOENT]
Tmp_File.asm(494) : Error A2106: Cannot open file: "DLG_Find.inc" [ENOENT]
Tmp_File.asm(512) : Error A2106: Cannot open file: "DLG_PageSetup.inc" [ENOENT]
Tmp_File.asm(1316) : Error A2160: INVOKE requires prototype for procedure
Tmp_File.asm(3232) : Error A2102: Symbol not defined : MLB_ITEM
Tmp_File.asm(3962) : Error A2230: Invalid operand for SIZEOF: $findReplBufferSize
Tmp_File.asm(3962) : Error A2147: Too few arguments to INVOKE: GetDlgItemTextA
I owe you one, JJ. Ugh. Updated package in posting above. I keep forgetting about all those include files ...
I'm hoping those operand/argument errors are just due to the missing files.
DLG_Find.inc is still missing.
; Get replacement text to start:
INVOKE GetDlgItemText, hWin, $replaceEdit, OFFSET ReplTextBuffer, SIZEOF $findReplBufferSize
I get an error with UAsm ("Error A2230: Invalid operand for SIZEOF" - correct), but ML version 15 has no problem with SIZEOF $findReplBufferSize. It firmly believes that the size of an equate can be 256 :rolleyes:
tmp$ CATSTR <TheSize=>, %(SIZEOF $findReplBufferSize)
% echo tmp$
Quote from: jj2007 on October 01, 2022, 08:49:00 AM
DLG_Find.inc is still missing.
Updated version in post above.
Quote
; Get replacement text to start:
INVOKE GetDlgItemText, hWin, $replaceEdit, OFFSET ReplTextBuffer, SIZEOF $findReplBufferSize
Interesting. Assembles fine here with ML.exe, but it sure looks wrong. Fixed in zip in post above.
Line 1316, INVOKE InitmcLB, InstanceHandle, produces a linker error: Unresolved external symbol '_InitmcLB@4'
I commented it out, and it works now. It seems you are using a library somewhere that contains InitmcLB :rolleyes:
mcLB.inc: InitmcLB PROTO hInst:HINSTANCE
Oy.
That's the initialization routine for my mcListbox custom control, which is in mcLB.obj (and there's a PROTO in mcLB.inc). Dunno why you're getting a link error. I'll have to look into this.
The program will work without that, but you won't be able to open the Goodies dialog.
Quote from: NoCforMe on October 01, 2022, 09:25:39 AM
Oy.
That's the initialization routine for my mcListbox custom control, which is in mcLB.obj (and there's a PROTO in mcLB.inc). Dunno why you're getting a link error. I'll have to look into this.
The program will work without that, but you won't be able to open the Goodies dialog.
Problem solved:
INVOKE InitmcLB, InstanceHandle ;
OPT_DebugL mcLB.objI hit F6, and that works in 99% of all cases - but RichMasm didn't know that an object file should be linked.
WinMain PROC
LOCAL msg:MSG, brush:HBRUSH, wX:DWORD, wY:DWORD, gpRect:RECT
LOCAL xPos:DWORD, ncm:NONCLIENTMETRICS, buffer[256]:BYTE
INVOKE InitmcLB, InstanceHandle ; OPT_DebugL mcLB.obj
INVOKE LoadLibrary, OFFSET RichEditDLLname ; OPT_Arg1 EdAsm.ini
Aha. That's why I included my "make" file, makeEdAsm.bat.
Executable only attached below (source available if anyone wants it).
It's getting closer. Added an "about" window which has a version #, couple other small refinements.
Still need:
- Popup context menu for editing (copy/paste, etc.)
- Finish printing stuff (setting margins: ugh!, footer)
- Finally get word wrap on/off put in (JJ's shaking his head ...)
- And when I do that I could put in line #s, which would help with tracking down assembly errors
Like they say: 90% done, with 90% to go ...
... a few months later ...
Lots more stuff in this program now. But there's something that's got me mystified: a hotkey that doesn't work.
I've put in a bunch of hotkeys that do work: Ctrl-O for open, Ctrl-S for save, Ctrl-P for print, etc.
But I just added a feature that lets you view "extra" files in a separate window, handy for looking at other source files. It works from the menu, AND the hotkey works BUT ONLY IF the cursor is over some non-client part of the window, like the title bar: it never works if the cursor is in the edit window. The other ones work no matter where the cursor is.
Here's my hotkey structure:
;***** Keyboard accelerators: *****
KBaccelerators LABEL DWORD
ACCEL <FCONTROL or FVIRTKEY, 'N', $menuNewFile>
ACCEL <FCONTROL or FVIRTKEY, 'O', $menuOpenFile>
ACCEL <FCONTROL or FVIRTKEY, 'S', $menuSaveFile>
ACCEL <FCONTROL or FVIRTKEY, 'P', $menuPrint>
ACCEL <FCONTROL or FVIRTKEY, 'F', $menuFindText>
ACCEL <FCONTROL or FVIRTKEY, 'R', $menuReplaceText>
ACCEL <FCONTROL or FVIRTKEY, 'T', $menuViewExtraFile>
ACCEL <FVIRTKEY, VK_F3, $menuFindAgain>
$numKBaccels EQU ($ - KBaccelerators) / SIZEOF ACCEL
Like I say, they ALL work, EXCEPT the "$menuViewExtraFile" one, and I just can't figure out why.
I've tried every letter in the alphabet, of course avoiding the ones that are used by RichEdit (this page of José Roca's (http://www.jose.it-berater.org/richedit/iframe/index.htm) was helpful in finding all the RichEdit shortcut keys). Makes no difference what letter I use, it just doesn't trigger a response.
It's not a big deal, but it's quite annoying. I guess I'll just put another button on the menu bar or something ...
You are right, it doesn't work with RichEd, and that is strange, because even a single "a" works fine, see attached testbed.
QuoteSetAccels Alt F4, F1: MyHelp
SetAccels Ctrl F1, Ctrl F2, Ctrl F3, Ctrl T, Alt T, Ctrl B
SetAccels Alt F1
SetAccels Shift F1
SetAccels a, B, c, D
SetAccels Ctrl O: CtrlOpen
SetAccels Ctrl VK_SPACE: MyConSpace, x: LowercaseX, X: UppercaseX
SetAccels Ctrl Z: NoUndo
All work fine, except Ctrl T and Alt T. You will have to subclass the control to catch WM_CHAR & friends. I made a quick test with WM_KEYDOWN, and that works fine :cool:
Btw the normal edit control behaves exactly the same.
Sorry, a basic mistake on my end. Had nothing whatever to do with accelerators at all.
The problem was in my wrapper routine for GetOpenFileName(). One of the elements of the OPENFILENAME structure, lpstrFile, is suppposed to either contain a null-terminated filename for initializing the dialog or a NULL. Since the routine I was calling from used a local variable to set that element (I usually use a global, and it's always initialized) that wasn't initialized, it contained garbage. Hence GetOpenFileName() never fired.
It was weird: It would work maybe one out of ten times, when it just happened that there was a NULL in that local variable.
I found the problem by putting MessageBeep() in various places.
Someday maybe I'll have made all these mistakes at least once ...
Here's the current version. It's stable, has most (not all, of course) of the features I want, and has been tested by daily use by me for the last couple months.
Latest addition is an "extra file" viewer that pops up a file (any type, could even be binary) in a window for quick reference (can be multiple instances). These windows are "always on top", so if they get in the way you can minimize (or close) them.
it comes with both .cfg and .ini files; the .cfg sets up some features of the interface ("cubbyholes" and "goodies"--you'll see what those are), can be edited by hand (ASCII text file) and is only read by the editor. The .ini contains things like window sizes and is both read and written by the program. If for some reason the program comes up at a crazy size or location on your screen, just delete the .ini file so it'll use its default size and position, which are reasonable. (You can also edit this file if need be, but only when the program isn't running.)
I'll post the source package later. Not feeling at all proprietary about this, but the source .asm file is now 193KB, so it's getting a bit hefty.
As always, let me know what you think.
Works fine :thumbsup:
I like the inserts. What's the difference to "goodies"?
What I would miss most: the build button that feeds the current text to a batch file.
Minor suggestion: F3 for next match down, Shift F3 for next match up.
:thumbsup:
Font color don't work, and there is no way to change background.
Quote from: jj2007 on January 16, 2023, 09:34:44 PM
Works fine :thumbsup:
I like the inserts. What's the difference to "goodies"?
Thanks. They're just an extension of the inserts shown in the listbox out front. You can add lots more of them here, since they appear in a "mcListbox" (my custom control). All of them are easily customizable by editing the .cfg file.
Quote
What I would miss most: the build button that feeds the current text to a batch file.
I've been thinking about that, moving closer to becoming an IDE. Working on parsing batch files ...
Quote
Minor suggestion: F3 for next match down, Shift F3 for next match up.
That'll go on the to-do list. Along with word wrap ...
Oh, and I'm thinking of maybe chucking bookmarks, since they don't work any near as nicely as yours do, since you're actually using the RichEdit control to store them. They're still useful in my editor, but they move around if you add text before them.
Quote from: HSE on January 16, 2023, 10:24:16 PM
:thumbsup:
Font color don't work, and there is no way to change background.
I've put in no such options. What font and background colors do you want to change, the edit control? I could do that.
Quote from: NoCforMe on January 17, 2023, 04:47:55 AM
Quote from: HSE on January 16, 2023, 10:24:16 PM
Font color don't work
I've put in no such options.
... then somebody else do that :biggrin: :biggrin: :biggrin:
Well, again, what colors do you want changed? I assume you mean the edit window, right? I could do that pretty easily.
Quote from: NoCforMe on January 17, 2023, 05:28:59 AM
Well, again, what colors do you want changed?
I don't want nothing. Just taking a look to what you are doing. :thumbsup:
Quote from: NoCforMe on January 17, 2023, 04:46:51 AMyou're actually using the RichEdit control to store them
Yes, that's the trick: a hidden 3-character code consisting of two "magic" chars plus one indicating the length of the bookmark text:
°B1Init
Add the constant 3 to 1 to obtain 4 chars, i.e. Init
It would be easy to implement for plain text asm files, if on loading the file you hide these codes, and on building a source you send only the visible text to the batch file. However, the source would look strange in QEditor, so exchanging sources would require an "export without bookmarks" option.
A difficult choice, but I swear I couldn't live without bookmarks. For hello world proggies, you don't need them, of course, but beyond a thousand lines they are a must :cool:
So for my editor, which now uses an ANSI RichEdit control, if I switched to the Unicode flavor, could I still deal just with ANSI text so far as loading and saving files goes? If I put in those special characters, would they be invisible in the edit window?
Yes and yes
I was going to hold off on this, but I put a kewl new feature into EdAsm, plus fixed a tiny but annoying problem, so I wanted to get this out there.
The feature is in the "extra file" viewer. Use the menu button, Ctrl-E or the menu to open a file to view. Pick a non-ASCII file.
The problem: for a while now I've noticed that the app seems to creep towards the right side of the screen; I found myself getting irritated and resizing the window without really thinking about it. Well, today I definitely noticed that happening, so I closed the app, looked at the window X- and Y-positions in the .ini file, fired it up again, closed it again, looked at the .ini: sure enough, those positions were being incremented by 1 every time! (The positions written to the .ini file come from GetWindowRect() at the time the program exits, which of course were both +1.)
Turns out the problem was in this code after creating all the windows but before entering the message loop:
; Make main window recalculate its size taking all controls into account:
cfgOK: MOV EAX, MainWindowW
INC EAX
MOV EDX, MainWindowH
INC EDX
INVOKE SetWindowPos, MainWinHandle, NULL, 0, 0, EAX, EDX, SWP_NOMOVE
The reason for that (incrementing X and Y) was to force a resize of everything (through WM_SIZE), otherwise the edit window didn't cover all the area it should unless you (the user) manually resized the window. That's been working, but the side effect is that the main window grows by (1,1) every time you use the program. Not good.
I fixed it by adding this:
; Make main window recalculate its size taking all controls into account:
cfgOK: MOV EAX, MainWindowW
INC EAX
MOV EDX, MainWindowH
INC EDX
INVOKE SetWindowPos, MainWinHandle, NULL, 0, 0, EAX, EDX, SWP_NOMOVE
; Need to hit that again (above code was causing window-size "creep" in .ini file):
INVOKE SetWindowPos, MainWinHandle, NULL, 0, 0, MainWindowW, MainWindowH, SWP_NOMOVE
hitting it again with SetWindowPos(), this time with the original size. It works, but it's obviously a kluge and a waste of a Win32 API call. What's happening it that things aren't getting sized properly in the first place, before WM_SIZE is issued. I need to go back and find out what's really wrong and fix it. Someday.
Quote from: NoCforMe on January 17, 2023, 04:05:59 PMforce a resize of everything (through WM_SIZE)
That sounds odd, I can't remember having seen that. Normally, you receive at least two WM_SIZE messages very early in the process:
# wParam lParam uMsg
msg 10 00670001 02D80FF4 WM_SIZE
msg 31 00000000 00CA025E WM_SIZEDiscard the first one (1=SIZE_MINIMIZED). The second one (0=SIZE_RESTORED) has width and height of the main window's client area, and that's the moment when you can adjust your child windows.
Thanks, but I'm already doing that:
;==================================
; WM_SIZE handler:
;==================================
do_size:
CMP wParam, SIZE_MINIMIZED
JE zero_exit ;Skip resizing on minimization.
Any other ideas?
Dang. As soon as I posted that I saw the problem, why it didn't work. Going to fix it and try it out now.
[later] Tried it, didn't work. I changed the test for minimized to
CMP WORD PTR wParam, SIZE_MINIMIZED
but only because I got scared after seeing the value you showed for WM_SIZE(wParam), which was 00670001. Which makes no sense, since according to MSDN (I'm sorry, "Microsoft Learn" these days), wParam is "The type of resizing requested. This parameter can be one of the following values:". Says nothing about a high word and a low word. So where does that "0067" come from?
In any case, didn't work even after looking for the real SIZE_MINIMIZED. So for now I'm not going to sweat it and let my kluge-y fix alone.
So did you try my new feature?
Well, I fixed my resizing problem by an elegant, if a little sneaky, method: I created my main window with zero size (width=height=0). Then when WM_SIZE kicks in it is forced to resize, since the new size ≠ old size. Easy peasy.
Quote from: NoCforMe on January 18, 2023, 11:21:40 AMI got scared after seeing the value you showed for WM_SIZE(wParam), which was 00670001. Which makes no sense
Right, there is a glitch in my code, and wParam is indeed zero. Apologies :sad:
(I am currently fighting like hell with the buggy msftedit.dll...)
Good luck with that.
(https://images.newscientist.com/wp-content/uploads/2015/12/mg22830501.100-1_800.jpg?width=1200)
Yeah, it's about that big :thumbsup:
RichMasm is now running more or less fine on Win7 with Sys32\msftedit.dll, but on Win10...
- with the Office12 dll, it hangs for one big (2.7 MB) source
- with the original Win10 msftedit.dll it works, but it loads very, very slowly
- with the Win7-64 msftedit.dll it works fine, a factor 5 (!) faster than the Win10 dll.
It's really a shame that Micros*t neglects the only control that is/should be able to use formatted text :sad:
I added an update to the Microsoft page (https://learn.microsoft.com/en-us/answers/questions/1123169/em-exsetsel-bug-in-msftedit-dll-richedit50w?page=1&orderBy=Helpful#answers) :biggrin:
So based on your experience, how would you judge Micro$oft's interest/alacrity in fixing problems running under Windows 7 (which is, after all, an officially obselete OS)?
I get a sense from reading Raymond Chen's blog that they (Microsoft) are not as callous and cavalier as many people make them out to be, that they really do have an interest in maintaining backwards compatibility, seeing as there's just so much "legacy" use of their software. How this actually translates into action is another question altogether.
(And of course today's news is that they just laid off 10,000 people, about 5% of their workforce.)
Good question, David :thumbsup:
What I see with the RichEdit control is that the team around Murray Sargent is working hard on adding new exotic features, such as LaTeX-style math display, but have little contact to users like us. They have a serious bug in the Win7 version? Nobody noticed, maybe. Or, other theory: they noticed and fixed the bug (dll size increased by factor 3, dll speed decreased by a factor 5) for Win10 but didn't bother to include it into a Win7 update.
There is an old saying: don't assume bad intentions if incompetence could be the cause :cool:
For those of you who thought my editor was dead and buried, it's baaaaaaaack ...
New version (2.7) has some nice features:
- Added a text tagging panel. This is for open/close tags, like HTML. It'll add tags around selected text (like <b>text</b>). Tag text is saved in the .ini file.
- Improved parsing (tokenization, actually) for cubbyhole & tag text: text can now contain embedded quotation marks, which are preserved in the .ini file (any double quotes are doubled in the .ini file, then converted back to single double quotes, if that makes sense).
- Line numbering (turn on and off from the Format menu). There's also a goto line # command (from the Edit menu or Ctrl-G).
That's it. Complete source attached. Have fun playing with it.
Good!
I wait for text-inserts tuning.
:thup:
Quote from: Rockphorr on August 02, 2023, 06:54:03 AMGood!
I wait for text-inserts tuning.
:thup:
OK, I guess. But what is that ("text-inserts tuning")?
If it's something good then I must have it in my editor.
Quote from: NoCforMe on August 15, 2023, 07:01:28 AMQuote from: Rockphorr on August 02, 2023, 06:54:03 AMGood!
I wait for text-inserts tuning.
:thup:
OK, I guess. But what is that ("text-inserts tuning")?
If it's something good then I must have it in my editor.
I think [inserts] menu should be linked with ini-file like so:
[CreateFint()]
INVOKE CreateFont,
fontHeight, ;font height
0, ;avg. width (usually 0)
0, ;"escapement"
0, ;orientation
FW_NORMAL, ;weight
FALSE, ;italic
FALSE, ;underline
FALSE, ;strikeout
ANSI_CHARSET, ;char. set
OUT_DEFAULT_PRECIS, ;output precision
CLIP_DEFAULT_PRECIS, ;clip precision
CLEARTYPE_QUALITY, ;quality
0, ;pitch & family
ADDR FontName ;name of font
And users can add own code to insert.
I found that it is exist in EdAsm.cfg. Needs configure button to edit and apply changes. Too far to use for user are "open folder" and "edit file" when no hints about where is it.
@ Rockphorr...
qeditor from the Masm32 SDK has similar functionality to that.
From a drop down menu, select an item (txt file), the text in the file selected will be inserted at the current caret position.
You can put a number of text files (*.txt) in a folder, and put an entry in "menus.ini" for that. :biggrin:
Do you mean something like that?
Quote from: zedd151 on October 06, 2023, 07:31:09 AM@ Rockphorr...
qeditor from the Masm32 SDK has similar functionality to that.
From a drop down menu, select an item (txt file), the text in the file selected will be inserted at the current caret position.
You can put a number of text files (*.txt) in a folder, and put an entry in "menus.ini" for that. :biggrin:
Do you mean something like that?
Thanks, Yes i mean it. And menuitem that opens for change it from the editor. These features are hidden so I need to discover a content of the editor folder.
After Windows 95 a distance to configure is right button click :)
Quote from: zedd151 on October 06, 2023, 07:31:09 AMqeditor from the Masm32 SDK has similar functionality to that.
From a drop down menu, select an item (txt file), the text in the file selected will be inserted at the current caret position.
Extremely clumsy but it works, indeed.
Quote from: Rockphorr on October 06, 2023, 07:26:06 AMI found that it is exist in EdAsm.cfg
For RichMasm, it's \Masm32\MasmBasic\Res\Keywords.ini - over 100 shortcuts. You type e.g.
cwx<space>, and you get
invoke CreateWindowExW, WS_EX_CLIENTEDGE, wChr$("edit"), NULL,
WS_CHILD or WS_VISIBLE or WS_BORDER or WS_VSCROLL or ES_MULTILINE,
9, 9, 500, 200, hWnd, 103, wcx.hInstance, NULL; we have added an edit control
mov hEdit, eax ; you may need this global variable for further processingYou type
.rep<space>, and you get a perfect .Repeat ... .Until loop, with a special char selected in the middle so that you can just continue typing
inc ecx or whatever. I use that feature all the time, and I couldn't live without it.
Quote from: Rockphorr on October 06, 2023, 07:26:06 AMI found that it [configuration file] is exist in EdAsm.cfg. Needs configure button to edit and apply changes. Too far to use for user are "open folder" and "edit file" when no hints about where is it.
Well, I won't argue with you; what you're describing is a configuration editor within the editor, which would definitely be a nice feature. Lotsa work to implement. I'll keep it in mind for when I finish other projects and maybe get bored ...
Quote from: Rockphorr on October 06, 2023, 07:26:06 AMNeeds configure button to edit and apply changes. Too far to use for user are "open folder" and "edit file" when no hints about where is it.
Well, your wish is my command. This new version has just what you asked for: a built-in configuration editor so you can add and change configuration items without having to edit a stupid configuration file (and figure out where the hell that file is!).
Choose "Configuration editor" from the File menu. Complete package including source attached.
The config editor incorporates my LM (list management) module, described in this thread (https://masm32.com/board/index.php?msg=126677).
Quote from: NoCforMe on February 15, 2024, 01:44:38 PMQuote from: Rockphorr on October 06, 2023, 07:26:06 AMNeeds configure button to edit and apply changes. Too far to use for user are "open folder" and "edit file" when no hints about where is it.
Well, your wish is my command. This new version has just what you asked for: a built-in configuration editor so you can add and change configuration items without having to edit a stupid configuration file (and figure out where the hell that file is!).
Choose "Configuration editor" from the File menu. Complete package including source attached.
The config editor incorporates my LM (list management) module, described in this thread (https://masm32.com/board/index.php?msg=126677).
More better !!! :thumbsup: :thumbsup: :thumbsup:
Quote from: NoCforMe on February 15, 2024, 01:44:38 PMThis new version has just what you asked for
After clicking Format/Editing font, Ok, another click into the main edit window closes the program without saving your edits. Do you use this editor for your daily coding?
Yes I do, but I've never done that. Urg, that's definitely a bug (doing that brought up OllyDbug). Thanks for the bug report; I'll have "my people" look at this right away.
Bug caught and fixed. Stupid mistake, trying to use a pointer in a register after a function call that trashed it. JJ, you the man of the hour. I owe you one.
Updated version (2.8) attached to this post.
Quote from: NoCforMe on March 07, 2024, 12:35:17 PMthat's definitely a bug
... and it's definitely fixed :thumbsup:
Good work :thumbsup:
Two minor points:
- I can't get in love with the cubby holes (you might at least add tooltips explaining how to use them)
- Instead of choosing the font size, you might wish to look at storing the zoom parameter, like SimpleEditor (https://masm32.com/board/index.php?topic=11754.0) does.
Quote from: jj2007 on March 07, 2024, 09:37:30 PMTwo minor points:
- I can't get in love with the cubby holes (you might at least add tooltips explaining how to use them)
I'll admit they're a bit odd. I've grown to like them very much, as I use this editor all the time now. Tooltips would be nice.
I'll also admit that my (fake) bookmarks aren't anywhere near as useful as yours, which stay put. But because I'm not using all the capabilities of the RichEdit control, it'd be very difficult for me to implement "real", (i.e., sticky) bookmarks. They're still semi-useful.
Quote- Instead of choosing the font size, you might wish to look at storing the zoom parameter, like SimpleEditor (https://masm32.com/board/index.php?topic=11754.0) does.
That would be another option. I've noticed that "zoom" factor inadvertently when I hit the wrong key and all of a sudden all my text is a different size ...
Quote from: NoCforMe on March 08, 2024, 05:56:12 AMI've noticed that "zoom" factor inadvertently when I hit the wrong key and all of a sudden all my text is a different size
Zoom happens when you hold Ctrl and play with the mousewheel.
SavZoom: push eax ; SaveSettings zoom
mov edx, esp ; this bloody message doesn't work
push eax ; most of the time, except on Close
invoke SendMessage, hRichEd, EM_GETZOOM, edx, esp
pop edx
pop ecx ; 0 if 100%
.if edx>50 && ecx!=curZoom ; sometimes it goes to edx=8, ecx=8 in rtf files
mov curZoom, ecx
SetIni$ "Zoom", Str$(ecx)
.endif
retnFor inspiration; EM_GETZOOM is the other useful message.
I'm a bit confused. According to Microsoft (https://learn.microsoft.com/en-us/windows/win32/controls/em-getzoom#parameters), EM_GETZOOM returns the zoom numerator and denominator in wParam & lParam:
QuoteParameters
wParam
Receives the numerator of the zoom ratio.
lParam
Receives the denominator of the zoom ratio.
which must mean that you pass
pointers to those variables, right?
LOCAL zoomNum:DWORD, zoomDenom:DWORD
INVOKE SendMessage, EditHandle, EM_GETZOOM, ADDR zoomNum, ADDR zoonDenom
Hi NoCforMe
From DebugCenter code
local dNumerator:DWORD, dDenominator:DWORD
SetObject xsi
;Remember the current RichEdit zoom factor
invoke SendMessage, [xsi].hEdit, EM_GETZOOM, addr dNumerator, addr dDenominator
.if eax != FALSE
mov [xsi].dZoomFactor, $32($invoke(MulDiv, dNumerator, ZOOM_BASE, dDenominator))
.endif
This works nicely.
Biterider
Quote from: NoCforMe on March 08, 2024, 06:52:20 AMwhich must mean that you pass pointers to those variables, right?
Right, that's what I do indeed.
Which wasn't at all clear from
Quotemov edx, esp
push eax
invoke SendMessage, hRichEd, EM_GETZOOM, edx, esp
What was edx set to previously? and how did esp get to be set to point to that other variable (except for 1 DWORD)? Anyhow, moving on ...
Try it out, it works. Olly is your friend :cool:
push eax ; wParam
mov edx, esp
push eax ; lParam
invoke SendMessage, hRichEd, EM_GETZOOM, edx, esp
pop edx ; wParam, either 0 (no zoom) or 100
pop ecx ; lParam, 10...200
No thanks, I'd rather be explicit rather than too clever by half:
INVOKE SendMessage, EditHandle, EM_GETZOOM, ADDR zoomNum, ADDR zoonDenom