This line compiles without problem:
invoke CreateWindowEx,WS_EX_CLIENTEDGE,addr ClassName,addr AppName,WS_OVERLAPPED+WS_CAPTION+WS_SYSMENU+WS_MINIMIZEBOX+WS_MAXIMIZEBOX+WS_VISIBLE,CW_USEDEFAULT,CW_USEDEFAULT,CW_USEDEFAULT,CW_USEDEFAULT,NULL,NULL,hInst,NULL
But if cut this long line for the sake of readability, I got error A2039:line too long
invoke CreateWindowEx, \
WS_EX_CLIENTEDGE, \
addr ClassName, \
addr AppName, \
WS_OVERLAPPED+WS_CAPTION+WS_SYSMENU+WS_MINIMIZEBOX+WS_MAXIMIZEBOX+WS_VISIBLE, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
NULL, \
NULL, \
hInst, \
NULL
But! If I only take fırst parameter near function name, again it compiles without problem:
invoke CreateWindowEx,WS_EX_CLIENTEDGE, \
addr ClassName, \
addr AppName, \
WS_OVERLAPPED+WS_CAPTION+WS_SYSMENU+WS_MINIMIZEBOX+WS_MAXIMIZEBOX+WS_VISIBLE, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
NULL, \
NULL, \
hInst, \
NULL
So, what is going on? And more importantly, what is the best assembly coding practice, in these kind of situations?
I removed the [Solved] as this forum is not a help desk. Our members help out where they can.
a) Post the complete source, please, and specify which assembler version throws the error.
b) Never, ever use + to combine flags; your WS_OVERLAPPED+WS_CAPTION+WS_SYSMENU+... is a no no
Try
invoke CreateWindowEx, \
WS_EX_CLIENTEDGE, \
addr ClassName, \
addr AppName, \
WS_OVERLAPPED or WS_CAPTION or WS_SYSMENU or WS_MINIMIZEBOX or WS_MAXIMIZEBOX or WS_VISIBLE, \
CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, \
NULL, NULL, hInst, NULL
Probably a limit how many "\" can be used
For window style, I usually put that in an equate and pass that...
wstyle equ WS_OVERLAPPED or WS_SYSMENU etc. for example
Then pass wstyle instead of the long string
Quote from: swordfish on September 14, 2022, 07:37:01 AM
Probably a limit how many "\" can be used
Nope. Wait until he posts complete code.
I am writing iczelions win32 tutorials samples in MASM64 SDK beta 2.
OPTION DOTNAME ; required for macro files
option casemap:none ; case sensitive
; _________________________________________________________________________
; MASM64 macros
include \masm64\include64\win64.inc ; main include file
include \masm64\macros64\vasily.inc ; main macro file
include \masm64\macros64\macros64.inc ; auxillary macro file
STACKFRAME ; create a default stack frame
; _________________________________________________________________________
; include files
include \masm64\include64\kernel32.inc
include \masm64\include64\user32.inc
include \masm64\include64\comctl32.inc
; _________________________________________________________________________
; libraries
includelib \masm64\lib64\kernel32.lib
includelib \masm64\lib64\user32.lib
includelib \masm64\lib64\comctl32.lib
; _________________________________________________________________________
; funtion prototypes
WndProc PROTO :HWND,:UINT,:WPARAM,:LPARAM
; _________________________________________________________________________
; constant variables
.const
IDC_PROGRESS equ 1
IDC_STATUS equ 2
IDC_TIMER equ 3
PBM_SETRANGE equ WM_USER+1
PBM_SETPOS equ WM_USER+2
PBM_DELTAPOS equ WM_USER+3
PBM_SETSTEP equ WM_USER+4
PBM_STEPIT equ WM_USER+5
; _________________________________________________________________________
; initialized variables
.data
ClassName db "CommonControlWin64Class", 0 ; the name of our window class
AppName db "x64 Common Control Demo", 0 ; the name of our window
ProgressClass db "msctls_progress32",0
Message db "Finished!",0
TimerID dq 0
; _________________________________________________________________________
; uninitialized variables
.data?
CommandLine LPSTR ?
hInstance HINSTANCE ?
hIcon HICON ?
hCursor HCURSOR ?
hProgress HANDLE ?
hStatus HANDLE ?
CurrentStep dq ?
.code
WinMainCRTStartup proc
invoke GetModuleHandle, NULL
mov hInstance, rax
invoke GetCommandLine
mov CommandLine, rax
invoke WinMain, hInstance, NULL, CommandLine, SW_SHOWDEFAULT
invoke ExitProcess, eax
ret
WinMainCRTStartup endp
WinMain proc hInst:HINSTANCE,hPrevInst:HINSTANCE,CmdLine:LPSTR,CmdShow:DWORD
LOCAL wcex:WNDCLASSEX
LOCAL msg:MSG
LOCAL hWnd:HWND
invoke LoadIcon, NULL, IDI_APPLICATION
mov hIcon, rax
invoke LoadCursor, NULL, IDC_ARROW
mov hCursor, rax
mov wcex.cbSize, sizeof WNDCLASSEX
mov wcex.style, CS_HREDRAW or CS_VREDRAW
lea rdi, WndProc
mov wcex.lpfnWndProc, rdi;offset WndProc
mov wcex.cbClsExtra, NULL
mov wcex.cbWndExtra, NULL
mov rax, hInst
mov wcex.hInstance, rax
mov rax, hIcon
mov wcex.hIcon, rax;hIcon
mov rbx, hCursor
mov wcex.hCursor, rbx;hCursor
mov wcex.hbrBackground, COLOR_APPWORKSPACE
mov wcex.lpszMenuName, NULL
lea rdi, ClassName
mov wcex.lpszClassName, rdi;offset ClassName
mov wcex.hIconSm, rax;hIcon
invoke RegisterClassEx, addr wcex
invoke CreateWindowEx,WS_EX_CLIENTEDGE, \
addr ClassName, \
addr AppName, \
WS_OVERLAPPED+WS_CAPTION+WS_SYSMENU+WS_MINIMIZEBOX+WS_MAXIMIZEBOX+WS_VISIBLE, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
NULL, \
NULL, \
hInst, \
NULL
mov hWnd, rax
invoke ShowWindow, hWnd, SW_SHOWNORMAL
invoke UpdateWindow, hWnd
.while TRUE
invoke GetMessage, addr msg, NULL, 0, 0
.if (rax == 0)
.break
.endif
invoke TranslateMessage, addr msg
invoke DispatchMessage, addr msg
.endw
mov rax, msg.wParam
ret
WinMain endp
WndProc proc hWnd:HWND, uMsg:UINT, wParam:WPARAM, lParam:LPARAM
.if uMsg==WM_CREATE
invoke CreateWindowEx, \
NULL, \
addr ProgressClass, \
NULL, \
WS_CHILD+WS_VISIBLE, \
100, \
200, \
300, \
20, \
hWnd, \
IDC_PROGRESS, \
hInstance, \
NULL
mov hProgress, rax
mov rax, 1000
mov CurrentStep, rax
shl rax, 16
invoke SendMessage, hProgress, PBM_SETRANGE, 0, rax
invoke SendMessage, hProgress, PBM_SETSTEP, 10, 0
invoke CreateStatusWindow, WS_CHILD+WS_VISIBLE, NULL, hWnd, IDC_STATUS
mov hStatus, rax
invoke SetTimer, hWnd, IDC_TIMER, 100, NULL
mov TimerID, rax
.elseif uMsg==WM_DESTROY
invoke PostQuitMessage, NULL
.if TimerID {} 0
invoke KillTimer, hWnd, TimerID
.endif
.elseif uMsg==WM_TIMER
invoke SendMessage, hProgress, PBM_STEPIT, 0, 0
sub CurrentStep, 10
.if CurrentStep==0
invoke KillTimer, hWnd, TimerID
mov TimerID, 0
invoke SendMessage, hStatus, SB_SETTEXT, 0, addr Message
invoke MessageBox, hWnd, addr Message, addr AppName, MB_OK+MB_ICONINFORMATION
invoke SendMessage, hStatus, SB_SETTEXT, 0, 0
invoke SendMessage, hProgress, PBM_SETPOS, 0, 0
.endif
.else
invoke DefWindowProc, hWnd, uMsg, wParam, lParam
ret
.endif
xor eax, eax
ret
WndProc endp
end
I used this way because I'm trying to stay true to the original
QuoteWS_OVERLAPPED+WS_CAPTION+WS_SYSMENU+WS_MINIMIZEBOX+WS_MAXIMIZEBOX+WS_VISIBLE
Which one is the "right" way; this or something else:
WS_OVERLAPPED or WS_CAPTION or WS_SYSMENU or WS_MINIMIZEBOX or WS_MAXIMIZEBOX or WS_VISIBLE
Thanks for posting complete code, BlueDevil. Here is my output:
*** assembling LineTooLong as Masm64 SDK source ***
*** linker options: [/entry:WinMainCRTStartup] ***
Assembling: Tmp_File.asm
*** linking LineTooLong.obj - no resources ***
*** success ***
No error message.
And yes, flags must be or'ed, not added, for obvious reasons.
Quote from: bluedevil on September 14, 2022, 07:45:53 AM
Which one is the "right" way; this or something else:
WS_OVERLAPPED or WS_CAPTION or WS_SYSMENU or WS_MINIMIZEBOX or WS_MAXIMIZEBOX or WS_VISIBLE
I've always used 'or' myself, which I believe is more proper.
So, where is the "line too long" error message? I can't see any, even when using...
invoke CreateWindowEx,\
WS_EX_CLIENTEDGE, \
... as in the example above where you claimed that the (unknown) assembler throws it.
Quote from: jj2007 on September 14, 2022, 07:57:02 AM
So, where is the "line too long" error message? I can't see any, even when using...
invoke CreateWindowEx,\
WS_EX_CLIENTEDGE, \
... as in the example above where you claimed that the (unknown) assembler throws it.
This is my makeit.bat file for this example
@echo off
set appname=TUTE18
del %appname%.obj
del %appname%.exe
REM \masm64\bin64\rc.exe /v %appname%.rc
REM \masm64\bin64\Cvtres.exe /machine:x64 DialogWithManifest.res
\masm64\bin64\ml64.exe /c %appname%.asm
\masm64\bin64\link.exe /SUBSYSTEM:WINDOWS /LARGEADDRESSAWARE %appname%.obj
dir %appname%.exe
pauseAnd here is the full output
Quote
C:\> makeit.bat
Microsoft (R) Macro Assembler (x64) Version 14.33.31629.0
Copyright (C) Microsoft Corporation. All rights reserved.
Assembling: TUTE18.asm
TUTE18.asm(146) : error A2039:line too long
Microsoft (R) Incremental Linker Version 14.33.31629.0
Copyright (C) Microsoft Corporation. All rights reserved.
LINK : fatal error LNK1181: cannot open input file 'TUTE18.obj'
Volume in drive C has no label.
Volume Serial Number is 4CC4-1770
Directory of C:\MASM64\MyProjects\Iczelion\TUTE18
File Not Found
Press any key to continue . . .
M$ Docs says (https://docs.microsoft.com/en-us/cpp/assembler/masm/ml-nonfatal-error-a2039?view=msvc-170)
Quote
line too long
A source-file line exceeded the limit of 512 characters.
If multiple physical lines are concatenated with the line-continuation character ( \ ), then the resulting logical line is still limited to 512 characters.
@jj
change here:
invoke CreateWindowEx,WS_EX_CLIENTEDGE, \
addr ClassName, \
addr AppName, \
WS_OVERLAPPED or WS_CAPTION or WS_SYSMENU or WS_MINIMIZEBOX or WS_MAXIMIZEBOX or WS_VISIBLE, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
NULL, \
NULL, \
hInst, \
NULL
mov hWnd, rax
to this:
invoke CreateWindowEx, \
WS_EX_CLIENTEDGE, \
addr ClassName, \
addr AppName, \
WS_OVERLAPPED or WS_CAPTION or WS_SYSMENU or WS_MINIMIZEBOX or WS_MAXIMIZEBOX or WS_VISIBLE, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
NULL, \
NULL, \
hInst, \
NULL
but not this:
Quote from: jj2007 on September 14, 2022, 07:57:02 AM
invoke CreateWindowEx,\
WS_EX_CLIENTEDGE, \
Quote
If multiple physical lines are concatenated with the line-continuation character ( \ ), then the resulting logical line is still limited to 512 characters.
I wonder if that includes all the formatting 'whitespace'.
In that case, try
invoke CreateWindowEx,WS_EX_CLIENTEDGE, addr ClassName, addr AppName, \
WS_OVERLAPPED or WS_CAPTION or WS_SYSMENU or WS_MINIMIZEBOX or WS_MAXIMIZEBOX or WS_VISIBLE, \
CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, \
NULL, NULL, hInst, NULL
mov hWnd, raxI don't have 64 setup on this computer at the moment, else I'd try it to verify that it works.
M$ Docs are pretty clear actually :/
I thought if there is a limitation on "invoke", but frankly the limitation is in ML itself. And yes is counts the white space!
Quote from: bluedevil on September 14, 2022, 09:00:02 AM
And yes is counts the white space!
I usually try to never exceed about 100 chars/line in my sources, using equates as I shown above or shorter variable names if possible to reduce line length. (So I don't have to scroll to see the rest of the line, no wordwrap used here) I rarely use a line continuation "/".
example:
MakeButton proc hWin:dword, bnx:dword, bsx:dword, x:dword, y:dword, hi:dword, id:dword
local hndl:dword
push esi
push edi
push ebx
push edx
push ecx
invoke CreateWindowEx, 0, bnx, 0, bsx, x, y, 64, 64, hWin, id, hi, 0
mov hndl, eax
...code continues...
This is just an example, you don't have to do it this way though. Yes I use 0 rather than NULL. Saves space and resolves to zero in either case anyway.
No error message, sorry :cool:
Microsoft (R) Macro Assembler (x64) Version 14.30.30705.0
Copyright (C) Microsoft Corporation. All rights reserved.
Assembling: LineTooLong.asm
Il volume nell'unità J è Acer
Numero di serie del volume: 2A34-6C3C
Directory di C:\Masm64\Members\blue_devil
14.09.22 01:31 3,072 LineTooLong.exe
1 File 3,072 byte
Hi bluedevil!
You can try to make line shorter defining for exampleMyStyle equ WS_OVERLAPPED or WS_ ...
HSE
This is what I use for a normal CreateWindowEx() window.
invoke CreateWindowEx,WS_EX_LEFT or WS_EX_ACCEPTFILES, \
ADDR classname,ADDR caption, \
WS_OVERLAPPED or WS_VISIBLE,\
lft,top,wid,hgt,0,0,hInstance,0
mov hWnd, rax
With the examples you posted, the following line,
WS_OVERLAPPED or WS_CAPTION or WS_SYSMENU or WS_MINIMIZEBOX or WS_MAXIMIZEBOX or WS_VISIBLE
can be put into a variable (or register) so that you only use the variable in the CreateWindowEx() function call which shortens the absolute line length.
Out of curiosity I decided to give this a whirl... So I installed Windows 7 64 bit so I could test a theory I had....
Assembled your code exactly as posted; named the source file test.asm :
C:\Users\Administrator\Desktop>set appname=test
C:\Users\Administrator\Desktop>del test.obj
C:\Users\Administrator\Desktop>del test.exe
C:\Users\Administrator\Desktop>REM \masm64\bin64\rc.exe /v test.rc
C:\Users\Administrator\Desktop>REM \masm64\bin64\Cvtres.exe /machine:x64 DialogW
ithManifest.res
C:\Users\Administrator\Desktop>\masm64\bin64\ml64.exe /c test.asm
Microsoft (R) Macro Assembler (x64) Version 14.33.31629.0
Copyright (C) Microsoft Corporation. All rights reserved.
Assembling: test.asm
C:\Users\Administrator\Desktop>\masm64\bin64\link.exe /SUBSYSTEM:WINDOWS /LARGEA
DDRESSAWARE test.obj
Microsoft (R) Incremental Linker Version 14.33.31629.0
Copyright (C) Microsoft Corporation. All rights reserved.
C:\Users\Administrator\Desktop>dir test.exe
Volume in drive C has no label.
Volume Serial Number is 5A5F-D2AF
Directory of C:\Users\Administrator\Desktop
09/13/2022 10:21 PM 5,120 test.exe
1 File(s) 5,120 bytes
0 Dir(s) 11,390,537,728 bytes free
C:\Users\Administrator\Desktop>pausePress any key to continue . . .
edit = used same batch file as posted, the first time had a slightly different batch file...
Seems to assemble here with no problems. Same ml64 version and linker version as yours, so that rules out a difference with jj's ml64 version (Macro Assembler (x64) Version 14.30.30705.0) I thought there could be a discrepancy between ml64 versions but it appears not in this case. So therefore I don't know what to tell you...
Quote from: swordfish on September 14, 2022, 02:46:13 PM
Seems to assemble here with no problems.
Thanks for confirming this :thumbsup:
Quote from: HSE on September 14, 2022, 09:37:49 AM
You can try to make line shorter defining for exampleMyStyle equ WS_OVERLAPPED or WS_ ...
Quote from: hutch-- on September 14, 2022, 10:18:19 AM
This is what I use for a normal CreateWindowEx() window.
invoke CreateWindowEx,WS_EX_LEFT or WS_EX_ACCEPTFILES, \
ADDR classname,ADDR caption, \
WS_OVERLAPPED or WS_VISIBLE,\
lft,top,wid,hgt,0,0,hInstance,0
mov hWnd, rax
With the examples you posted, the following line,
WS_OVERLAPPED or WS_CAPTION or WS_SYSMENU or WS_MINIMIZEBOX or WS_MAXIMIZEBOX or WS_VISIBLE
can be put into a variable (or register) so that you only use the variable in the CreateWindowEx() function call which shortens the absolute line length.
Guys, thank you for your replies and suggestions. I am also using that kind of clean code conventions while writing. You missed the point i have mentioned:
Quote from: bluedevil on September 14, 2022, 07:45:53 AM
I am writing iczelions win32 tutorials samples in MASM64 SDK beta 2.
I used this way because I'm trying to stay true to the original
QuoteWS_OVERLAPPED+WS_CAPTION+WS_SYSMENU+WS_MINIMIZEBOX+WS_MAXIMIZEBOX+WS_VISIBLE
@jj
How are you doing this? Code on your zip file also compiles on my machine right now!!!
Quote from: bluedevil on September 14, 2022, 06:54:09 PM
@jj
How are you doing this? Code on your zip file also compiles on my machine right now!!!
Zip your non-assembling source and post it here. I am curious, too.
bluedevil,
I will let you in on a well known piece of information, Iczelion was a personal friend of mine, we developed the early part of Win32 asm together. When he retired (life, wife, kids work etc ...) he passed the maintainance of his work to me, some of which I have tweaked but it was basically too old and had errors that needed to be rewritten. The problem back when they were written was that information was very hard to get.
Register preservation conventions.
Notation like using "or" rather than "+" and with Win64, the architecture is different. Trying to use push/call notation will run into many serious problems.
What you are after can be done in 64 bit and you can produce very similar looking code but at its lowest level, the architecture is very different. The calling convention is Win64 FASTCALL, stack alignment is critical yet there are many advantages with Win64, more efficient procedure calls with lower overhead, twice as many integer registers and 64 but data rather than 32 bit.
As WS_OVERLAPPED equ 0handWS_OVERLAPPEDWINDOW equ WS_OVERLAPPED OR WS_CAPTION OR WS_SYSMENU OR WS_THICKFRAME OR WS_MINIMIZEBOX OR WS_MAXIMIZEBOXwhere someone needs WS_OVERLAPPED ?
Quote from: bluedevil on September 14, 2022, 07:45:53 AMI used this way because I'm trying to stay true to the original
QuoteWS_OVERLAPPED+WS_CAPTION+WS_SYSMENU+WS_MINIMIZEBOX+WS_MAXIMIZEBOX+WS_VISIBLE
When Iczelion wrote this code about 20 (?) years ago (https://alt.lang.asm.narkive.com/IuMarut3/iczelion-s-tutorials-revisited), he did a brilliant job. However, he was young and probably had not yet been bitten by the "+ vs or" problem. It is not forbidden to improve Iczelion's code.
Windows.inc:
WS_OVERLAPPEDWINDOW equ WS_OVERLAPPED OR WS_CAPTION OR WS_SYSMENU OR WS_THICKFRAME OR WS_MINIMIZEBOX OR WS_MAXIMIZEBOX
WS_TILEDWINDOW equ WS_OVERLAPPEDWINDOW
WS_POPUPWINDOW equ WS_POPUP OR WS_BORDER OR WS_SYSMENU
...
WS_EX_OVERLAPPEDWINDOW equ WS_EX_WINDOWEDGE OR WS_EX_CLIENTEDGE
WS_EX_PALETTEWINDOW equ WS_EX_WINDOWEDGE OR WS_EX_TOOLWINDOW OR WS_EX_TOPMOST
...
LBS_STANDARD equ LBS_NOTIFY OR LBS_SORT OR WS_VSCROLL OR WS_BORDERUnrelated (WinExtra.inc):
ERROR_EXPECTED_SECTION_NAME equ APPLICATION_ERROR_MASKorERROR_SEVERITY_ERRORor0
ERROR_BAD_SECTION_NAME_LINE equ APPLICATION_ERROR_MASKorERROR_SEVERITY_ERRORor1
I woke up this morning with an odd but related notion. I always save my source code as ascii text since I use qeditor as my code editor. While saving as Unicode with a different editor then assembling it, would ml64 consider the line of text twice as long (in bytes) or is it counting characters? I seldom use Unicode, and use 64 bit code only rarely in comparison to the experience I have with 32 bit code.
This question is for hutch, jj or anyone else with much more experience with different situations than me regarding ml64, unicode or a combination of both.
This is posted from my iPad, will look into this when I get back to my computer. Now I wanna test this theory.
As a side note:
I played around with this code last night; indenting the argument lines further to the right, and produced the same error as bluedevil had gotten, but that was with more white space than in his posted code.
I can answer your question as soon as you make the effort to zip your source and post it here.
Quote from: jj2007 on September 14, 2022, 11:24:10 PM
I can answer your question as soon as you make the effort to zip your source and post it here.
My question, or are you addressing bluedevil? If you are responding to my question, it'll have to wait. I'm not in front of my computer at the moment. I'm away from home posting from my ipad. If I were at home I would test this myself. But since I'm out and about, I posted this little theory I had. :tongue:
Either way, I'm using the exact code as in post #4 in this thread other than changing + to ' or '. (Except for the mentioned white space experiment I had done)
Okay, my theory didn't quite work at all. Saved the file as uncode this is the response:
Could Not Find C:\Users\Administrator\Desktop\TUTE18.obj
Could Not Find C:\Users\Administrator\Desktop\TUTE18.exe
Microsoft (R) Macro Assembler (x64) Version 14.33.31629.0
Copyright (C) Microsoft Corporation. All rights reserved.
Assembling: TUTE18.asm
TUTE18.asm(1) : error A2044:invalid character in file
TUTE18.asm(2) : error A2008:syntax error : p
TUTE18.asm(7) : error A2109:only white space or comment can follow backslash
TUTE18.asm(9) : error A2109:only white space or comment can follow backslash
TUTE18.asm(11) : error A2109:only white space or comment can follow backslash
TUTE18.asm(14) : error A2008:syntax error : S
TUTE18.asm(19) : error A2109:only white space or comment can follow backslash
TUTE18.asm(21) : error A2109:only white space or comment can follow backslash
TUTE18.asm(23) : error A2109:only white space or comment can follow backslash
TUTE18.asm(29) : error A2109:only white space or comment can follow backslash
TUTE18.asm(31) : error A2109:only white space or comment can follow backslash
TUTE18.asm(33) : error A2109:only white space or comment can follow backslash
TUTE18.asm(39) : error A2008:syntax error : n
TUTE18.asm(44) : error A2008:syntax error : .
TUTE18.asm(45) : error A2008:syntax error : I
TUTE18.asm(46) : error A2008:syntax error : I
TUTE18.asm(47) : error A2008:syntax error : I
TUTE18.asm(49) : error A2008:syntax error : P
TUTE18.asm(50) : error A2008:syntax error : P
TUTE18.asm(51) : error A2008:syntax error : P
TUTE18.asm(52) : error A2008:syntax error : P
TUTE18.asm(53) : error A2008:syntax error : P
TUTE18.asm(58) : error A2008:syntax error : .
TUTE18.asm(59) : error A2008:syntax error : C
TUTE18.asm(60) : error A2008:syntax error : A
TUTE18.asm(61) : error A2008:syntax error : P
TUTE18.asm(62) : error A2008:syntax error : M
TUTE18.asm(63) : error A2008:syntax error : T
TUTE18.asm(68) : error A2008:syntax error : .
TUTE18.asm(69) : error A2008:syntax error : o
TUTE18.asm(70) : error A2008:syntax error : I
TUTE18.asm(71) : error A2008:syntax error : I
TUTE18.asm(72) : error A2008:syntax error : C
TUTE18.asm(73) : error A2008:syntax error : P
TUTE18.asm(74) : error A2008:syntax error : S
TUTE18.asm(75) : error A2008:syntax error : u
TUTE18.asm(77) : error A2008:syntax error : .
TUTE18.asm(79) : error A2008:syntax error : W
TUTE18.asm(81) : error A2008:syntax error : i
TUTE18.asm(82) : error A2008:syntax error : m
TUTE18.asm(84) : error A2008:syntax error : i
TUTE18.asm(85) : error A2008:syntax error : m
TUTE18.asm(87) : error A2008:syntax error : i
TUTE18.asm(88) : error A2008:syntax error : i
TUTE18.asm(90) : error A2008:syntax error : r
TUTE18.asm(92) : error A2008:syntax error : W
TUTE18.asm(94) : error A2008:syntax error : i
TUTE18.asm(96) : error A2008:syntax error : O
TUTE18.asm(97) : error A2008:syntax error : O
TUTE18.asm(98) : error A2008:syntax error : O
TUTE18.asm(100) : error A2008:syntax error : i
TUTE18.asm(101) : error A2008:syntax error : m
TUTE18.asm(102) : error A2008:syntax error : i
TUTE18.asm(103) : error A2008:syntax error : m
TUTE18.asm(105) : error A2008:syntax error : o
TUTE18.asm(106) : error A2008:syntax error : o
TUTE18.asm(107) : error A2008:syntax error : l
TUTE18.asm(108) : error A2008:syntax error : o
TUTE18.asm(109) : error A2008:syntax error : o
TUTE18.asm(110) : error A2008:syntax error : o
TUTE18.asm(111) : error A2008:syntax error : m
TUTE18.asm(112) : error A2008:syntax error : o
TUTE18.asm(113) : error A2008:syntax error : m
TUTE18.asm(114) : error A2008:syntax error : o
TUTE18.asm(115) : error A2008:syntax error : m
TUTE18.asm(116) : error A2008:syntax error : o
TUTE18.asm(117) : error A2008:syntax error : o
TUTE18.asm(118) : error A2008:syntax error : o
TUTE18.asm(119) : error A2008:syntax error : l
TUTE18.asm(120) : error A2008:syntax error : o
TUTE18.asm(121) : error A2008:syntax error : o
TUTE18.asm(122) : error A2008:syntax error : i
TUTE18.asm(124) : error A2042:statement too complex
TUTE18.asm(128) : error A2039:line too long
TUTE18.asm(136) : error A2008:syntax error : m
TUTE18.asm(138) : error A2008:syntax error : i
TUTE18.asm(139) : error A2008:syntax error : i
TUTE18.asm(141) : error A2008:syntax error : .
TUTE18.asm(142) : error A2008:syntax error : i
TUTE18.asm(143) : error A2008:syntax error : .
TUTE18.asm(144) : error A2008:syntax error : .
TUTE18.asm(145) : error A2008:syntax error : .
TUTE18.asm(146) : error A2008:syntax error : i
TUTE18.asm(147) : error A2008:syntax error : i
TUTE18.asm(148) : error A2008:syntax error : .
TUTE18.asm(150) : error A2008:syntax error : o
TUTE18.asm(152) : error A2008:syntax error : r
TUTE18.asm(154) : error A2008:syntax error : W
TUTE18.asm(156) : error A2008:syntax error : n
TUTE18.asm(158) : error A2008:syntax error : .
TUTE18.asm(159) : error A2042:statement too complex
TUTE18.asm(159) : error A2039:line too long
TUTE18.asm(170) : error A2008:syntax error : h
TUTE18.asm(172) : error A2008:syntax error : m
TUTE18.asm(174) : error A2008:syntax error : m
TUTE18.asm(175) : error A2008:syntax error : m
TUTE18.asm(176) : error A2008:syntax error : s
TUTE18.asm(178) : error A2008:syntax error : i
TUTE18.asm(179) : error A2008:syntax error : i
TUTE18.asm(181) : error A2008:syntax error : i
TUTE18.asm(182) : fatal error A1012:error count exceeds 100; stopping assembly
Microsoft (R) Incremental Linker Version 14.33.31629.0
Copyright (C) Microsoft Corporation. All rights reserved.
LINK : fatal error LNK1181: cannot open input file 'TUTE18.obj'
Volume in drive C has no label.
Volume Serial Number is 5A5F-D2AF
Directory of C:\Users\Administrator\Desktop
File Not Found
Press any key to continue . . .
So no it wouldn't work as unicode. Even I thought my notion was 'odd' after all. This proves its oddness. :toothy: ml64 doesn't like unicode source file.
The same but saved as ascii text
response:
Microsoft (R) Macro Assembler (x64) Version 14.33.31629.0
Copyright (C) Microsoft Corporation. All rights reserved.
Assembling: TUTE18.asm
Microsoft (R) Incremental Linker Version 14.33.31629.0
Copyright (C) Microsoft Corporation. All rights reserved.
Volume in drive C has no label.
Volume Serial Number is 5A5F-D2AF
Directory of C:\Users\Administrator\Desktop
09/14/2022 08:59 AM 5,120 TUTE18.exe
1 File(s) 5,120 bytes
0 Dir(s) 11,423,076,352 bytes free
Press any key to continue . . .Back to some semblence of normalcy. :biggrin:
ml64.exe handle only ASCII and UTF-8 without signature source files.
Quote from: TimoVJL on September 15, 2022, 01:16:03 AM
ml64.exe handle only ASCII and UTF-8 without signature source files.
I figured only ascii after I tested my "odd" notion that I had this morning while pondering the original problem.
Good to know for future reference.
ML64 does not support UNICODE text but there are a couple of method to include UNICODE text, in a resource file OR as DB data. The ANSI to UNICODE conversion will only do the first 256 characters but if you have genuine UNICODE from arabic or oriental sources, you need a method of storing it. A resource file works but its a bit clunky to use and DB format UNICODE is bulky and not editable.
Quote from: swordfish on September 14, 2022, 11:56:56 PM
Okay, my theory didn't quite work at all. Saved the file as uncode this is the response:
Strangely enough, when I open your Unicode source in RichMasm and hit F6, it assembles & runs just fine... but when I use the makeit.bat, I see lots of error messages :cool:
The reason is that RichMasm doesn't care whether it opens an Ascii or UTF-16 file, but for building the source it always exports Ascii or Utf-8 :cool:
Quote from: swordfish on September 15, 2022, 01:19:20 AMI figured only ascii
The Assembler has no idea what Utf-8 looks like; so it assumes "Ascii".
Quote from: jj2007 on September 15, 2022, 02:39:40 AM
Strangely enough, when I open your Unicode source in RichMasm...
When I posted the 'saved as unicode' version, it was just an experiment on my part. Not suggesting anyone else should use that (saving as unicode).
Quote from: swordfish on September 15, 2022, 01:19:20 AM
The Assembler has no idea what Utf-8 looks like; so it assumes "Ascii".
Good point is, that it don't mess with ANSI codebases, but i haven't tested it enough.
Quote from: swordfish on September 15, 2022, 03:03:38 AMWhen I posted the 'saved as unicode' version, it was just an experiment on my part. Not suggesting anyone else should use that (saving as unicode).
It was worth a test. I just checked with UAsm and AsmC, same as ML64: no luck with a Utf-16 source.
Quote from: TimoVJL on September 15, 2022, 03:41:01 AM
Quote from: swordfish on September 15, 2022, 01:19:20 AM
The Assembler has no idea what Utf-8 looks like; so it assumes "Ascii".
Good point is, that it don't mess with ANSI codebases, but i haven't tested it enough.
Save & build everything as Utf-8; then, if Windows asks for it, convert Utf-8 to Utf-16. It works.
Windows NT have been internally UNICODE since born, why ml/ml64 don't still accept that ?
I think its a case of what assemblers have generally been used for over a long period. The memory demand being just one of them. If you need to deal with text in a non european character set, UNICODE is very useful but if you are doing anything else, the 256 character set is half the size and a more efficient use of memory.
Quote from: hutch-- on September 15, 2022, 10:39:35 AM
I think its a case of what assemblers have generally been used for over a long period. The memory demand being just one of them. If you need to deal with text in a non european character set, UNICODE is very useful but if you are doing anything else, the 256 character set is half the size and a more efficient use of memory.
when I worked with 06xx arabic and hiragana and katakana I tested do storage of only the lower byte and add 0600 or where hiragana or katakana start
isnt that something similar to utf8 works?
probably invain when posting .zip in forum,it probably compress lots of 06 bytes
Quote from: jj2007 on September 14, 2022, 07:30:42 PM
Quote from: bluedevil on September 14, 2022, 06:54:09 PM
@jj
How are you doing this? Code on your zip file also compiles on my machine right now!!!
Zip your non-assembling source and post it here. I am curious, too.
OK I've solved your magic @jj. :D
You had shared this code:
invoke CreateWindowEx, \
WS_EX_CLIENTEDGE, \
addr ClassName, \
addr AppName, \
WS_OVERLAPPED or WS_CAPTION or WS_SYSMENU or WS_MINIMIZEBOX or WS_MAXIMIZEBOX or WS_VISIBLE, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
NULL, \
NULL, \
hInst, \
NULL
And this is my non-compiling code:
invoke CreateWindowEx,
WS_EX_CLIENTEDGE, \
addr ClassName, \
addr AppName, \
WS_OVERLAPPED or WS_CAPTION or WS_SYSMENU or WS_MINIMIZEBOX or WS_MAXIMIZEBOX or WS_VISIBLE, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
CW_USEDEFAULT, \
NULL, \
NULL, \
hInst, \
NULL
At first they seem equal but, i have added one more tab to each line. So this makes more than 512 chars. Remember what M$ Docs (https://docs.microsoft.com/en-us/cpp/assembler/masm/ml-nonfatal-error-a2039?view=msvc-170) said:
Quote
line too long
A source-file line exceeded the limit of 512 characters.
If multiple physical lines are concatenated with the line-continuation character ( \ ), then the resulting logical line is still limited to 512 characters.
Anyway, I got the situation. I will be more careful while coding and try not to exceed 512 chars.
Thanks everyone for your valuable comments.
Quote from: bluedevil on September 25, 2022, 05:44:54 AMAnyway, I got the situation. I will be more careful while coding and try not to exceed 512 chars.
Try UAsm64 (http://www.terraspace.co.uk/uasm.html#p2), its limit is 1004 chars ;-)
Quote from: jj2007 on September 25, 2022, 06:46:34 AM
Quote from: bluedevil on September 25, 2022, 05:44:54 AMAnyway, I got the situation. I will be more careful while coding and try not to exceed 512 chars.
Try UAsm64 (http://www.terraspace.co.uk/uasm.html#p2), its limit is 1004 chars ;-)
I am taking this as a note :D
BTW is it 1004 or 1024?
Quote from: bluedevil on September 25, 2022, 07:52:06 AM
BTW is it 1004 or 1024?
Strangely enough, it's 1004 :cool:
Funny enough, I have never found line length to be a problem that cannot easily be overcome. For Windows styles, OR them all to either a variable or register, instead of "ADDR whatever", use a pointer instead "pText". With quoted text, multiline layouts with a separate DB for each line allows very large text to be embedded in an exe file.
Quote from: jj2007 on September 25, 2022, 08:16:30 AM
Strangely enough, it's 1004 :cool:
You can rebuild UASM with longer lines, no restriction. Usually I set maximum line size to 2048 bytes, but my longer mesured line only was 1680 bytes.