A simple template demonstrating how elegant and efficient Assembly can be
include \masm32\include\masm32rt.inc ; **** load standard Masm32 includes ****
.data ; initialised data section
wc WNDCLASSEX <WNDCLASSEX, 0, WndProc, 0, 0, 1, 2, 3, COLOR_BTNFACE+1, 0, txClass, 4>
txClass db "Masm32GUI", 0 ; class name, will be registered below
msg MSG <>
.code
WinMain:
mov wc.hInstance, rv(GetModuleHandle, 0) ; rv ("return value") is a Masm32 macro
mov wc.hIcon, rv(LoadIcon, eax, IDI_APPLICATION)
mov wc.hIconSm, eax ; the rv macro returns results in eax
invoke RegisterClassEx, addr wc ; the window class needs to be registered
invoke CreateWindowEx, WS_EX_ACCEPTFILES, wc.lpszClassName, chr$("Hello World"), ; title
WS_OVERLAPPEDWINDOW or WS_VISIBLE, 120, 120, 300, 120, ; style, x, y, width, height
NULL, rv(LoadMenu, wc.hInstance, 100), wc.hInstance, NULL
.While 1
inc rv(GetMessage, addr msg, 0, 0, 0)
shr eax, 1
.Break .if Zero? ; 0 (OK) or -1 (error)
invoke TranslateMessage, addr msg
invoke DispatchMessage, addr msg
.Endw
invoke ExitProcess, msg.wParam
WndProc proc hWnd, uMsg, wParam:WPARAM, lParam:LPARAM
.if uMsg==WM_DESTROY
invoke PostQuitMessage, NULL
.endif
invoke DefWindowProc, hWnd, uMsg, wParam, lParam ; default processing
ret
WndProc endp
end WinMain
Impressive. But didn't you leave out the lines in the resource file? That menu didn't just appear out of thin air ...
Well, well... strictly speaking that isn't code :cool:
From WinMin examples:
#define WIN32_LEAN_AND_MEAN
#include <windows.h>
#include <shellapi.h>
#pragma comment(lib, "shell32.lib")
static LRESULT CALLBACK WndProc(HWND, UINT, WPARAM, LPARAM);
static void OnDropFiles(HWND hWnd, HDROP hDrop);
static TCHAR *szAppName = TEXT("WinFrame");
static TCHAR *szFrameClass = TEXT("cWinFrame");
static WNDCLASSEX wcx = {sizeof(WNDCLASSEX), CS_HREDRAW | CS_VREDRAW, 0, 0, 0,
0, 0, 0, (HBRUSH)COLOR_3DSHADOW, 0, 0, 0};
HWND g_hFrame;
HANDLE g_hInst;
void __cdecl WinMainCRTStartup(void)
{
ExitProcess(WinMain(GetModuleHandle(NULL),0,0,SW_SHOW));
}
int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPTSTR lpCmdLine, int nCmdShow)
{
MSG msg;
wcx.hInstance = hInstance;
wcx.lpfnWndProc = WndProc;
wcx.lpszClassName = szFrameClass;
wcx.hCursor = LoadCursor(NULL, IDC_ARROW);
if (!RegisterClassEx(&wcx))
return 0;
g_hInst = hInstance;
g_hFrame = CreateWindowEx(0, szFrameClass, szAppName,
WS_OVERLAPPEDWINDOW,
CW_USEDEFAULT, CW_USEDEFAULT,
CW_USEDEFAULT, CW_USEDEFAULT,
NULL, NULL, hInstance, NULL);
if(!g_hFrame) return 0;
ShowWindow(g_hFrame, nCmdShow);
DragAcceptFiles(g_hFrame, TRUE);
while(GetMessage(&msg, NULL, 0, 0))
{
TranslateMessage(&msg);
DispatchMessage(&msg);
}
DragAcceptFiles(g_hFrame, FALSE);
return msg.wParam;
}
static LRESULT CALLBACK WndProc(HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam)
{
switch(uMsg) {
// case WM_PAINT:
// case WM_CREATE:
case WM_DROPFILES: OnDropFiles(hWnd, (HDROP)wParam); return 0;
case WM_DESTROY:
PostQuitMessage(0);
return(0);
}
return DefWindowProc(hWnd, uMsg, wParam, lParam);
}
static void OnDropFiles(HWND hWnd, HDROP hDrop)
{
TCHAR szTmp[260];
int nCnt = DragQueryFile(hDrop, -1, 0, 0);
if (nCnt) {
int nLen = DragQueryFile(hDrop, 0, szTmp, sizeof(szTmp));
MessageBox(hWnd, szTmp, "File:", MB_OK);
}
}
Quote from: TimoVJL on November 20, 2023, 09:27:57 PMFrom WinMin examples:
72 lines of C code, nice :thumbsup:
With the right tools and libraries, one can do fantastic things:
GuiParas equ "Hello World", w200, h400, b LiteBlueGreen, icon Printer ; width+height, background colour
GuiMenu equ @File, &Open, &Save, &Print, -, E&xit, @Edit, Undo, Copy, Paste
include \masm32\MasmBasic\Res\MbGui.asm
Event DropFiles ; loads the Files$() array; use wRec$() to convert Utf8 file names to true Unicode
wMsgBox 0, wRec$(Join$(Files$())), "Files dropped:", MB_OK or MB_TOPMOST
StoreUtf8 "~tmpDropped.txt", Files$() ; write dropped filenames to a text file in Utf8 format
GuiEndSeven lines of code, purest Assembly (plus, it writes the filenames to disk, see attachment...) ;-)
Quote from: jj2007 on November 21, 2023, 11:42:36 PM...With the right tools and libraries, one can do fantastic things:
with that principle, just one line is enough ?
Those who have read Dr. Dobbs Magazine, knowns, what i am talking about :smiley:
Yeah, I think this whole "look what I can do in n lines of code!" business is far too overrated. After all, sometime in the future, after neural-machine links are perfected** and all, our code will reduced to this:
DWIM
which of course is the instruction for "do what I mean".
I especially think using macros in this way is cheating, as they compound their constituent "lines of code" (instructions) into one deceptive-looking "instruction":
mov wc.hInstance, rv(GetModuleHandle, 0) ; rv ("return value") is a Masm32 macro
should properly be expanded into what it really is, which is
invoke GetModuleHandle, 0
mov wc.hInstance, eax
(and if you're a purist, which I am not, you could even argue that "invoke" should be expanded into its push-push-call constituents)
** I sincerely hope I'm not still alive when that happens.
Quote from: NoCforMe on November 22, 2023, 08:53:08 AM(and if you're a purist, which I am not, you could even argue that "invoke" should be expanded into its push-push-call constituents)
That's exactly the point: where to draw the line? I find it silly to use push-push-call for CreateFont - it's so easy to count 13 instead of 14 args, and thus run into real problems because a stack imbalance often gets not noticed because of the stack frame.
So I use invoke CreateFont, ... 14 args ..., and the assembler will tell me if I counted wrong. Only that invoke is severely broken for the Masm64 SDK, it will not tell you that you missed an arg, or added one too many.
Of course, instead of using Recall (https://www.jj2007.eu/MasmBasicQuickReference.htm#Mb1172), I could paste a dozen lines of code to simulate
get text from a file and put it into an array. Will it make my code more readable? Will it make me happier because I demonstrate that I can
code pure assembly copy & paste?
I have over 4,000 sources in my Masm32 folder. I refuse to use "pure" Assembly.
Update: attached a rather bloated 37 lines window template, including a Gdi32 demo - enjoy :thup:
Wonder if guga can beat that with oneliner, with his multiple mnemonics on one line caps assembler ?
An example (https://tromp.github.io/tetris.html):
long h[4];t(){h[3]-=h[3]/3000;setitimer(0,h,0);}c,d,l,v[]={(int)t,0,2},w,s,I,K
=0,i=276,j,k,q[276],Q[276],*n=q,*m,x=17,f[]={7,-13,-12,1,8,-11,-12,-1,9,-1,1,
12,3,-13,-12,-1,12,-1,11,1,15,-1,13,1,18,-1,1,2,0,-12,-1,11,1,-12,1,13,10,-12,
1,12,11,-12,-1,1,2,-12,-1,12,13,-12,12,13,14,-11,-1,1,4,-13,-12,12,16,-11,-12,
12,17,-13,1,-1,5,-12,12,11,6,-12,12,24};u(){for(i=11;++i<264;)if((k=q[i])-Q[i]
){Q[i]=k;if(i-++I||i%12<1)printf("\033[%d;%dH",(I=i)/12,i%12*2+28);printf(
"\033[%dm "+(K-k?0:5),k);K=k;}Q[263]=c=getchar();}G(b){for(i=4;i--;)if(q[i?b+
n[i]:b])return 0;return 1;}g(b){for(i=4;i--;q[i?x+n[i]:x]=b);}main(C,V,a)char*
*V,*a;{h[3]=1000000/(l=C>1?atoi(V[1]):2);for(a=C>2?V[2]:"jkl pq";i;i--)*n++=i<
25||i%12<2?7:0;srand(getpid());system("stty cbreak -echo stop u");sigvec(14,v,
0);t();puts("\033[H\033[J");for(n=f+rand()%7*4;;g(7),u(),g(0)){if(c<0){if(G(x+
12))x+=12;else{g(7);++w;for(j=0;j<252;j=12*(j/12+1))for(;q[++j];)if(j%12==10){
for(;j%12;q[j--]=0);u();for(;--j;q[j+12]=q[j]);u();}n=f+rand()%7*4;G(x=17)||(c
=a[5]);}}if(c==*a)G(--x)||++x;if(c==a[1])n=f+4**(m=n),G(x)||(n=m);if(c==a[2])G
(++x)||--x;if(c==a[3])for(;G(x+12);++w)x+=12;if(c==a[4]||c==a[5]){s=sigblock(
8192);printf("\033[H\033[J\033[0m%d\n",w);if(c==a[5])break;for(j=264;j--;Q[j]=
0);while(getchar()-a[4]);puts("\033[H\033[J\033[7m");sigsetmask(s);}}d=popen(
"stty -cbreak echo stop \023;sort -mnr -o HI - HI;cat HI","w");fprintf(d,
"%4d from level %1d by %s\n",w,l,getlogin());pclose(d);}
Ugly as shit.
Quote from: jj2007 on February 21, 2024, 11:09:08 PMUpdate: attached a rather bloated 37 lines window template, including a Gdi32 demo - enjoy :thup:
how about refactor these 2 lines
invoke BeginPaint, hWnd, addr ps
mov hDC, eax
into singleliner?
using rv() marco?
Also the msg loop is a bit unusual...
usually I'm using this one:
.while TRUE
invoke GetMessage,addr msg,NULL,0,0
.BREAK .if !eax
invoke TranslateMessage,addr msg
invoke DispatchMessage,addr msg
.endw
Quote from: greenozon on March 12, 2024, 08:31:57 PMinto singleliner?
using rv() marco?
Your wish is my command, see attachment :biggrin:
Quote from: greenozon on March 12, 2024, 10:19:03 PMAlso the msg loop is a bit unusual...
.BREAK .if !eaxWhat happens with your code if GetMessage returns -1?
QuoteGetMessage function (https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getmessage)
Return value
Type: BOOL
If the function retrieves a message other than WM_QUIT, the return value is nonzero.
If the function retrieves the WM_QUIT message, the return value is zero.
If there is an error, the return value is -1. For example, the function fails if hWnd is an invalid window handle or lpMsg is an invalid pointer. To get extended error information, call GetLastError.
Compare to the code in Windows36lines:
inc rv(GetMessage, addr msg, 0, 0, 0)
shr eax, 1
.Break .if Zero? ; 0 (OK) or -1 (error)
jj, nice!!
going back to
>>If there is an error, the return value is -1. For example, the function fails if hWnd is an invalid window handle or lpMsg is an invalid pointer. To get extended error information, call GetLastError.
tell me, from the bottom of your heart,
what is the % of probability in your specific piece of (great) SW that this error might happen?
another idea/question to get -1 line ...
how about this:
it is possible to make 1 line instead of these 2?
wc WNDCLASSEX <WNDCLASSEX, 0, WndProc, 0, 0, 1, 2, 3, COLOR_BTNFACE+1, 0, txClass, 4>
txClass db "Masm32GUI", 0 ; class name, will be registered below
focus on txClass
Quote from: greenozon on March 13, 2024, 02:58:29 AMtell me, from the bottom of your heart,
what is the % of probability
Unless you have an extremely valid reason to ignore the documentation,
don't do it.Quote from: greenozon on March 13, 2024, 03:02:45 AMit is possible to make 1 line instead of these 2?
The txClass string is being used twice. You might use chr$(..) instead and save one line, but in contrast to MasmBasic's Chr$(..) (https://www.jj2007.eu/MasmBasicQuickReference.htm#Mb1143), the Masm32 SDK chr$() generates two entries for identical strings - therefore I would hate that :cool:
Quote from: sinsi on May 21, 2014, 03:01:57 PMWhen will GetMessage return -1? (http://blogs.msdn.com/b/oldnewthing/archive/2013/03/22/10404367.aspx)
Quote from: Raymond ChenBut don't worry, the standard message pump is safe. If your parameters are exactly
•a valid pointer to a valid MSG structure,
•a null window handle,
•no starting message range filter,
•no ending message range filter,
then GetMessage will not fail with -1.
Quote from: jj2007 on March 13, 2024, 04:07:19 AMThe txClass string is being used twice.
I've read the .asm code thrice and... I can't find the used twice case!?
Check the WNDCLASSEX structure:
Quotewc WNDCLASSEX <WNDCLASSEX, 0, WndProc, 0, 0, 1, 2, 3, COLOR_BTNFACE+1, 0, txClass, 4>
txClass db "Masm32GUI", 0 ; class name
...
invoke CreateWindowEx, WS_EX_ACCEPTFILES, wc.lpszClassName, chr$("Hi there") ...
However, you are right that it can be a one line shorter, see attachment :cool:
Quote from: sinsi on March 13, 2024, 05:48:56 AMIf your parameters are exactly
Exactly, Sinsi ;-)
(if not, it's called a
bug, and if you don't play the
shr eax, 1 trick, the program will most likely become an invisible zombie that must be manually killed in Task Manager)
Two things to cause an error, but you break for the error and a quit message. To be properly paranoid your code should jump to an error handler if the return code is -1.
He also warns against using any sort of filter, as another window (e.g. OLE, CBT) might use your window procedure, and since GetMessage is blocking it might have messages piling up that don't match your filter but other code relies on them being processed.
Quote from: sinsi on March 13, 2024, 07:32:29 AMyou break for the error and a quit message.
Yep, that's the intention. Here is a loop that is foolproof:
invoke CreateWindowEx, WS_EX_ACCEPTFILES, wc.lpszClassName, chr$("Hi there"), ; class, title
WS_OVERLAPPEDWINDOW or WS_VISIBLE, 120, 120, 240, 180, ; style, x, y, width, height
NULL, rv(LoadMenu, wc.hInstance, 100), wc.hInstance, NULL
.While eax
inc rv(GetMessage, addr msg, 0, 0, 0)
shr eax, 1
.Break .if Zero? ; 0 (OK) or -1 (error)
invoke TranslateMessage, addr msg
invoke DispatchMessage, addr msg
or eax, -1
.Endw
invoke ExitProcess, msg.wParamIf there is an error when creating the window, the loop will not be entered at all. The
or eax, -1 makes sure that the loop keeps going until WM_QUIT or an error occur. Back to 36 lines, unfortunately, but it's worth it - I checked, an error in CreateWindowEx will indeed create a zombie...
Sure, on purpose.
WS_EX_ACCEPTFILES
Quote from: TimoVJL on March 13, 2024, 10:22:15 PMSure, on purpose.
WS_EX_ACCEPTFILES
Indeed, using this style would require an appropriate handler, which is a bit beyond this simple template.
include \masm32\MasmBasic\Res\MbGui.asm
GuiControl MyEdit, "RichEdit", wCL$()
invoke SetWindowPos, hGui, HWND_TOPMOST, eax, eax, eax, eax, SWP_NOMOVE or SWP_NOSIZE
Event DropFiles ; load a dropped text or rtf file into the RichEdit control
SetWin$ hMyEdit=FileRead$(Files$(0))
GuiEndYou can test it with the attached Ansi, Utf16 and RTF files ;-)
the last DropFiles.exe looks interesting indeed!
it could handle .rtf (wow!)
but... the emoji's support is very limited, it was able to render a couple out of hundreds available...
Quote from: greenozon on March 13, 2024, 11:42:57 PMthe emoji's support is very limited, it was able to render a couple out of hundreds
Can you post some examples that didn't work?
It's easy
goto https://emojipedia.org/flags
then copy whatever you like, eg:
🏁
🚩
🎌
🏴
🏳�
🏳��🌈
🏳��⚧️
🏴�☠️
🇺🇳
and paste into the DropFiles.exe editor pane
or whatever emojis you like eg
😺😺😺
😱
😨
😰
😥
😓
No problem for SimpleEditor :cool:
(https://i.postimg.cc/kB2QgC9S/Emojis.png) (https://postimg.cc/kB2QgC9S)
Easy emojis in Windows 11
Windows+.
😁😊🤣😂❤️👍
Quote from: sinsi on March 14, 2024, 11:17:30 AM😁😊🤣😂❤️👍
Fine for Win10 & SimpleEditor (https://masm32.com/board/index.php?topic=11759.0) - if saved as rtf, see attachment :thumbsup:
Notepad and Notepad++ seem to save as normal text.
Hi Sinsi,
This is weird: what you sent is Utf8 code without a Utf8 BOM:
F0 9F 98 8A F0 9F A4 A3 F0 9F 98 82
So apparently, Notepad uses an autodetect mechanism that recognises these Utf8 codepoints. Interesting.
SimpleEditor uses a BOM, but when you build a project, it exports the code to Res\Tmp_file.asm in plain text format without BOM.
There it is (https://en.wikipedia.org/wiki/UTF-8):
QuoteWindows Notepad, in all currently supported versions of Windows, defaults to writing UTF-8 without a BOM (a change from the outdated/unsupported Windows 7 Notepad)
This reminds me of our lovely discussions with Utf8 hater Nidud ;-)
Since I am an expert for creating confusion, here is what happens when you write in your native codepage and then try to add emojis:
QuoteThe file contains Unicode characters that could be lost if the file were saved as a text file in ANSI characters. To preserve Unicode characters choose Undo, then select one of the Unicode options in the Encoding drop-down list. Continue?
Utf8 rocks, forget the old codepages :cool:
(https://i.postimg.cc/NydjDG6r/Not-Utf8-NP.png) (https://postimg.cc/NydjDG6r)
P.S., the page you are reading right now, btw, has a UTF8 BOM:
<meta charset="UTF-8">(https://upload.wikimedia.org/wikipedia/commons/9/97/Unicode_Web_growth.svg)
Quote from: greenozon on March 14, 2024, 08:13:20 AMIt's easy
goto https://emojipedia.org/flags
then copy whatever you like, eg:
🏁
🚩
🎌
🏴
🏳�
🏳��🌈
🏳��⚧️
🏴�☠️
🇺🇳
and paste into the DropFiles.exe editor pane
or whatever emojis you like eg
😺😺😺
😱
😨
😰
😥
😓
Heh; forget about JJ's application for the moment: a lot of those characters don't even render correctly in my web browser (Opera 95.0.4635.90, Windows 7 64 Pro):
(https://i.postimg.cc/GTy8WmQ0/Emojis.jpg) (https://postimg.cc/GTy8WmQ0)
Try smth more recent
eg Supermium 122
Vivaldi 6.6
etc
!
Sorry, not about to change my web browser!
the you are under super high risk rihgtnow!
if you still using geriatric build 109