It's work in progress, use at own risk and backup precious sources, but it's ready for some serious testing: I need feedback :thup:
Extract the exe to a folder and launch it. Make a copy of your biggest source, open it and hit F6. I am curious what kind of bugs you will discover ;-)
My motivation for writing this is that my usual Notepad replacement Explorer2 didn't add a Utf8 BOM and therefore screwed up some of the text files I am working on. So here it is, Notepad with some bells and whistles. The source is 413 lines, i.e. 1.5% of the RichMasm source, so don't expect too much.
sqlite3.c 8,59 MB opened nicely.
But Invalid menu handle in Window 7
Menues don't work until the second run (.ini files?)
I prefer to click on a menu before it shows :biggrin:
Can I change the font?
Active code page: 65001
["C:\asm\ODBC\ODBC.asm"] [/ID-117] []
'\Masm32\bin\UAsm64.exe' is not recognized as an internal or external command,
operable program or batch file.
POLINK: fatal error: File not found: 'tmp_file.obj'.
You had errors, sorry
Press any key to continue . . .
I tried to enter this forum topic but from time to time I"m hitting this kind of case:
(https://i.postimg.cc/ygnd6NGR/Screenshot-6.jpg) (https://postimg.cc/ygnd6NGR)
any ideas? (this happens to random pages here...)
Quote from: TimoVJL on March 06, 2024, 02:22:30 AMInvalid menu handle in Window 7
Confirmed, thanks.
Quote from: sinsi on March 06, 2024, 02:34:07 AMMenues don't work until the second run (.ini files?)
Yep, I got the order wrong, thanks :thumbsup:
QuoteI prefer to click on a menu before it shows :biggrin:
That's a matter of taste: I hate clicking for no reason. Many websites have now menus that work with hovering instead of clicking.
QuoteCan I change the font?
Which font? I can add that feature to the ini file if needed.
Btw Ctrl + mousewheel let's you zoom in or out (and the setting will be remembered).
Quote from: greenozon on March 06, 2024, 02:53:12 AMI tried to enter this forum topic but from time to time I"m hitting this kind of case:
That happens frequently. Just hit F5 :thumbsup:
Hello,
I tried the program you sent, and I encountered a few issues:
Firstly, the menu doesn't seem to work.
Secondly, when clicking on 'build batch,' I get a fatal error "Line ???: Array Erased Or undefined", then the program shuts down.
Lastly, the program doesn't compile code into 64-bit.
Hi mabdelouahab,
Thanks for testing this :thup:
> Firstly, the menu doesn't seem to work.
Version 2 should work, see attachment
> Secondly, when clicking on 'build batch,' I get a fatal error "Line ???: Array Erased Or undefined", then the program shuts down.
That is evidently a bug. In the executable's folder, do you see a buildSE.bat? Most probably you see it, but it wasn't there on first launch. Again, I got the order wrong, as Sinsi rightly noted.
> Lastly, the program doesn't compile code into 64-bit.
This is by design: the B button should show all batch files in the executable's folder. Put your 64-bit batch file there; note that the source will be Tmp_File.asm - see buildSE.bat for info.
I am grateful for examples of 64-bit batch files. As you know, we have several "toolchains" here, like Masm64 SDK, WinInc, ...
Hi JJ,
- background look like turquise
- There is no save
- Empty file admit to be saved as
- Open try to open same file in edition
HSE
small issue report:
click print icon
Cancel
msg box:
---------------------------
Print:
---------------------------
0 pages printed
---------------------------
OK
---------------------------
idea - do not show it
2) click on "B" button:
---------------------------
Fatal error:
---------------------------
Line ???: Array erased or undefined
---------------------------
OK
---------------------------
please explain what is that? (app crashed and closed up)
Quoteidea - do not show it
"0 pages printed" is a reassuring info that indeed the printer will not start spitting out empty sheets... but perhaps I'll follow your advice ;-)
Quote2) click on "B" button:
---------------------------
Fatal error:
---------------------------
Line ???: Array erased or undefined
This will work when you launch it the second time.
Quote from: HSE on March 06, 2024, 04:22:11 AM- background look like turquise
- There is no save
- Empty file admit to be saved as
- Open try to open same file in edition
1. I am working on it, there might be a bgcol=0FFFFFFh in the ini file.
2. Ctrl S works fine, but you are right, it should be explicit in the menu, too.
3.+4. I don't understand what you mean...?
Quote from: jj2007 on March 06, 2024, 03:57:36 AMIn the executable's folder, do you see a buildSE.bat? Most probably you see it, but it wasn't there on first launch
Hi jj
I've checked the executable's folder both after the first launch and again after running the program a second time, but I couldn't find the buildSE.bat file. It seems like it wasn't included in the version you sent me.
Quote from: jj2007 on March 06, 2024, 04:59:09 AM3.+4. I don't understand what you mean...?
3. Even if editor is empty, apparently can save something.
4. Open a file, and try to open another file
Quote from: mabdelouahab on March 06, 2024, 06:32:20 AMI've checked the executable's folder both after the first launch and again after running the program a second time, but I couldn't find the buildSE.bat file. It seems like it wasn't included in the version you sent me.
You are right, it was not included. Attached version 3 will do better.
@HSE:
- when opening a new file, and the old file had edits, you will be asked whether you want to save the edits
- you are right about not saving empty files
Quote from: sinsi on March 06, 2024, 02:34:07 AMCan I change the font?
Yessss - have a look at SimpleEditor.ini (edit with Notepad, not with SimpleEditor!)
Wellll, I downloaded the latest one (V3). JJ, I'd say this is not even an alpha, let alone a beta:
o When I navigated to the folder where the file I wanted to edit is, the file-selection dialog showed files first, then folders, the reverse of the normal order.
o The files shown in this dialog weren't sorted, making it hard to find the file you want.
o When I picked a file (a 0.28 Mb ASM source), I got a blank screen. Nothing. Nada.
o When I clicked on "Save as" the window turned black. Still no text.
I don't think I'd trust this for actual use just yet. In fact, it seems completely no-operative.
Windows 7 Pro SP1 here.
Open File dialog
- click on a column header to sort, there is a noticeable delay
- click on a filename, then change to another folder, get asked whether I want to create the file
(this only happened the first time)
- filename is already selected no matter which folder I go to
Edit
- When I do open a file the window is blank, ctrl-A shows the text is there.
OK, upon investigation of the ini file I found the culprit
bgcolRtf=000FFFFFFh
fgCol=000FFFFFFh
bgCol=000FFFFFFh
You've been Procol Harum'd :biggrin:
- each key counts as an edit? If I type a 4-letter word then ctrl-Z four times and exit, it asks me if I want
to save my 8 changes.
Build
- why do the buttons have a red cross?
- do I have to click the button and then a menuitem? Or is that only Build Batch?
- click Build Windows, nothing for a few seconds then a console window shows with the missing uasm message
Quote from: NoCforMe on March 06, 2024, 08:24:37 AMo The files shown in this dialog weren't sorted, making it hard to find the file you want.
They are sorted by date, most recent files on top.
This is by design.
Quote from: sinsi on March 06, 2024, 08:48:10 AMOpen File dialog
- click on a column header to sort, there is a noticeable delay
- click on a filename, then change to another folder, get asked whether I want to create the file
(this only happened the first time)
- filename is already selected no matter which folder I go to
It's a standard dialog, so the delay is not the program's fault, I guess. Thanks for the feedback, I'll try to find out whether there is a logical fault.
Quote- When I do open a file the window is blank, ctrl-A shows the text is there.
OK, upon investigation of the ini file I found the culprit
bgcolRtf=000FFFFFFh
fgCol=000FFFFFFh
bgCol=000FFFFFFh
You've been Procol Harum'd :biggrin:
Yes, I had the same experience; will be fixed asap :sad:
Quote- each key counts as an edit? If I type a 4-letter word then ctrl-Z four times and exit, it asks me if I want to save my 8 changes.
That's the current design. I might try to lower the edit count when getting a WM_UNDO message, but I have a suspicion that this might fail. RichEd, y'know...
The next version will check if the current text is shorter than the original text, and if it's below 90%, you'll get a warning "below 90% - do you really want to save", yesnocancel. This is a feature that saved me many times with RichMasm :cool:
QuoteBuild
- why do the buttons have a red cross?
- do I have to click the button and then a menuitem? Or is that only Build Batch?
- click Build Windows, nothing for a few seconds then a console window shows with the missing uasm message
No red cross here - what exactly do you see where? :rolleyes:
The
C and
W buttons do what their tooltip says. You need to click them, but hitting F6 will also work.
The
B button is special: when you click it, you get a popup menu with a list of the batch files present in the exe's folder.
Check buildSE.bat:
@echo off
REM #Desc=Default Windows or Console build
chcp 65001
...
If the
#Desc= string is present, you will see the description instead of the filename in the B button's popup menu.
There is another problem that I need to solve: if the batch file has a
pause, SimpleEditor will hang until you switch to the batch window and hit a key. I might use a thread for building, but will have to check the consequences.
Quote from: jj2007 on March 06, 2024, 11:17:06 AMQuote from: NoCforMe on March 06, 2024, 08:24:37 AMo The files shown in this dialog weren't sorted, making it hard to find the file you want.
They are sorted by date, most recent files on top. This is by design.
OK, your preference, definitely not mine. Is there a "sort by" option, or do you plan on including one?
Quote from: NoCforMe on March 06, 2024, 11:57:39 AMOK, your preference, definitely not mine. Is there a "sort by" option, or do you plan on including one?
Congrats that you are able to reliably spot the latest version from an alphabetical listing - I am too old for that.
Yes, there is a "sort by" option: just click into the header of the first column :thumbsup:
Quote from: jj2007 on March 06, 2024, 12:02:52 PMQuote from: NoCforMe on March 06, 2024, 11:57:39 AMOK, your preference, definitely not mine. Is there a "sort by" option, or do you plan on including one?
Congrats that you are able to reliably spot the latest version from an alphabetical listing - I am too old for that.
Yes, there is a "sort by" option: just click into the header of the first column :thumbsup:
Well, I'm too old for that too. And no, I can't "reliably spot the latest version" either. But that's not the way I work; I don't have multiple versions of files that differ alphabetically. Apparently you do; not saying my way is better, just that we have different ways of working.
All of which is to say that it might not be a good idea to assume that other people work the same way you do. Which is why it's nice to have options, like being able to sort a file list differently. BTW, is that sort option saved? or would you have to reset it every time you use your editor?
On a 4K monitor the program starts off taking up most of the screen, if it's run by itself it shows the open dialog, which is even bigger. No drama, but cancelling the dialog makes the main program snap and shrink to 1/4 size. A bit jarring on the eyes :biggrin:
One red cross for sir
(https://i.postimg.cc/bdp93Tty/Untitled.png) (https://postimg.cc/bdp93Tty)
Quote from: sinsi on March 06, 2024, 01:06:57 PMOn a 4K monitor the program starts off taking up most of the screen
4k is luxury :biggrin:
SimpleEditor should ideally save its size and position once you close it. Does that work?
QuoteOne red cross for sir
(https://i.postimg.cc/bdp93Tty/Untitled.png) (https://postimg.cc/bdp93Tty)
One blue circle for you - Windows at its best :badgrin:
This is Win10 - what's your version?
Version 4 attached to top post (https://masm32.com/board/index.php?topic=11754.0).
- colours are ok now
- dragging files from Explorer (or similar) on SE window works
- save edits logic improved
- search box has the focus on opening; hit Return, then use cursor down to scroll through the matches
- you can now edit SimpleEditor.ini in SE itself (before, you could save the ini file but it got immediately overwritten by SaveSettings...)
- editor warns if user tries to save a doc that is smaller than the original:
MsgBox hGui, Str$("Only %i% of initial text.\nSave nonetheless?", eax) , "Hi", MB_YESNOCANCEL or MB_DEFBUTTON3
Version 5 - see top post (https://masm32.com/board/index.php?topic=11754.0) :cool:
Inter alia, some of the Masm64 SDK examples (e.g. \Masm64\Examples\Simple\controls\controls.asm) should now work "out of the box" with the
B button. Let me know if it doesn't, please :thup:
It's not yet ready for a release version, but so far it works fine. Thanks for all your suggestions :thup:
SimpleEditor.ini:
QuoteWinZoomed=0
WinRect=485/0/1286/665
Zoom=110
ofSort=2
bgcolRtf=0FFFFFFh
fgCol=0FFFFFFh
bgCol=0
font=Lucida Console
Language=4
Red settings get adjusted whenever you close the program; blue settings can be edited using SimpleEditor.exe
For example,
ofSort=0 means OpenFile gets sorted alphabetically. Default is
ofSort=2, most recent files on top.
The discussion has moved to A simple editor for the Masm32 and Masm64 SDKs and the UAsm/JWasm WinInc package (https://masm32.com/board/index.php?topic=11759.0)
The source is currently at 435 lines, plus resources. If anybody is seriously interested to see it, please PM me. Building requires MasmBasic of 9 March (http://masm32.com/board/index.php?topic=94.0).
Release version 1 is online (https://masm32.com/board/index.php?topic=11759.0) - please test and give me feedback :thup:
Recent changes:
- six batch files for console/Windows for 1. Masm32, 2. Masm64 SDK and 3. UAsm+WinInc
- colours revisited, should be ok now
- dragging files from Explorer (or similar) on SimpleEditor window works
- save edits logic improved
- on load, search box has the focus (hit Return, then use cursor down to scroll through the matches)
- content of search box will be remembered on next launch
- you can edit SimpleEditor.ini in SE itself (mainly colours)
- editor warns if user tries to save a doc smaller than the original
- in case of crashes, editor will offer to recover the latest version (one open file will be remembered; think carefully before saving the recovery file!)
- File save as offers more formats (asc/rtf, plain test asm, Utf8 asm, Utf16 rc, ...)
- you may test File save as with the MasmBasic sample in Res\MiniGui.asc
The source is now at 415 lines.
Quote from: jj2007 on March 14, 2024, 06:24:23 AMRelease version 0 is will soon be online (https://masm32.com/board/index.php?topic=11759.0) - please test and give me feedback :thup:
pardon me but where is the download link for the editor itself... can't find it... sorry
Quote from: greenozon on March 14, 2024, 08:18:25 AMwhere is the download link for the editor itself
I made major changes and ran into a problem, which I am trying to solve in the next hours...
New version uploaded (https://masm32.com/board/index.php?topic=11759.0) - see reply #25 for a list of changes :thumbsup:
File menu opens when the mouse is anywhere from the leff edge to the letter U in the Language menu.
Language menu opens anywhere from the U to 1/4 the way over the New document button
Toolbar - does anyone actually use one? I cringe whenever I see someone typing in a document then grab the mouse and click (e.g. the next control rather than TAB). Hotkeys please.
Options? How do I set up assembler, linker etc?
More to come ☢️
sinsi, I couldn't agree with you more about toolbars, except for the print icon I find most of those icons cryptic and I have hover the mouse over them to hopefully get a hint at what it does, I simply avoid them if at all possible
Quote from: sinsi on March 14, 2024, 01:08:50 PMOptions? How do I set up assembler, linker etc?
By editing the default batch files :thup:
Res\SimpleEdC.bat
Res\SimpleEdW.bat
Res\BuildMasm64SdkC.bat
Res\BuildMasm64SdkW.bat
Res\BuildWinIncC.bat
Res\BuildWinIncW.batFor example, BuildWinIncW.bat:
set lib=\WinInc\Lib64
set include=\WinInc\Include;%~dp1For \Masm32 and \Masm64, the predefined batch files should work just fine for all files in the Examples and Examples64 folders.
You made me discover a
bug in the setup: extract the attached file to [SimpleEditorFolder]\Res, then launch SimpleEditor.exe again. You should now see the QikPad example, and it should build by hitting F6
There were no batch files (or res folder) when I first started the editor.
I don't like the use of a folder under the editor folder ("res"), mainly because I run the editor from my desktop (to avoid problems with Windows Security), so now my desktop looks untidy :biggrin: .
More to come ☣️
Quote from: sinsi on March 15, 2024, 12:08:48 AMI don't like the use of a folder under the editor folder ("res"), mainly because I run the editor from my desktop (to avoid problems with Windows Security), so now my desktop looks untidy :biggrin: .
Put the exe in \Masm32\SimpleEditor.exe, run it once, then create a shortcut to the exe and copy that to your desktop. Works like a charm here on Win10 :biggrin:
Quote from: jack on March 14, 2024, 01:36:23 PMexcept for the print icon I find most of those icons cryptic and I have hover the mouse over them to hopefully get a hint at what it does
Better? No hovering & tooltips, though. The car to the right means "run" :cool:
(https://i.postimg.cc/ydV5PQgK/QEd-Toolbar.png)
For comparison:
(https://i.postimg.cc/rwHxgKDw/Simple-Ed-Toolbar.png)
@Sinsi - current key shortcuts:- F3: search for selection (i.e. select SendMessage, then hit F3, Return to see the listbox)
- F5: Masm32 console build (with resources, if [filename].rc or rsrc.rc are found)
- F6: Masm32 Windows build (with resources, if [filename].rc or rsrc.rc are found)
- Ctrl F: focus to the search box (type the string to find, hit Return, arrow down to scroll)
- Ctrl O: open file
- Ctrl S: save file
- Ctrl Z+Alt Backspace: undo
- Ctrl Y: redo
- Ctrl T: make SimpleEditor topmost
- Escape: close (with questions asked if there were edits)
Quote from: jj2007 on March 15, 2024, 12:39:21 AMPut the exe in \Masm32\SimpleEditor.exe, run it once, then create a shortcut to the exe and copy that to your desktop. Works like a charm here on Win10 :biggrin:
Don't tell me how to set up my computer :badgrin:
I don't use MASM32, I've gone to the dark side and use VS :cool:
Ha! Latest ML/Link, latest libraries, built-in debugger, not bad editor, free, VB.net :tongue:
Bloated, hard to set up for ASM, updates every week or so... :sad:
I do still use qeditor though, so I am willing to give your Simple Editor a thrash :biggrin:
Time for a new test: version 6 attached here. Extract to any folder on your Masm32 drive, then run the exe. If you see Qikpad.asm, hit F6. If you don't see Qikpad, let me know what you see, please :thup:
As usual, the legal fineprint: use at your own risk etc etc; and tell me if you are satisfied with the way SimpleEditor handles a crash. Simulate one as follows:
- edit a source
- don't save, don't exit
- kill the SimpleEditor.exe process in Task Manager.
P.S.: Ctrl E changes text colour, Ctrl H background colour, Ctrl T/Ctrl Shift T the selection's font size.
Click New File - shows a Save dialog, no way to cancel the save and have a blank document.
No right click, even for copy/paste?
Menu problem is still there re mouse position.
I would prefer to have a blank document if I just open the editor, not the previous one I was working on.
To add to the above, if the file is deleted, when the editor is next opened it shows an Open dialog but if I click cancel it closes the editor.
Dislike how it closes when you hit Esc. Killer move, it doesn't ask to save if you've changed anything.
Focus starts in the search box, would prefer it in the document.
Remembers the last search - for me, distracting.
Toolbar - please let me switch it off :biggrin:
What are bgR1 and fgR1 colours for?
Quote from: sinsi on March 27, 2024, 06:51:57 AMit doesn't ask to save if you've changed anything
That is definitely not intended, sorry :sad:
Quote from: sinsi on March 27, 2024, 06:51:57 AMWhat are bgR1 and fgR1 colours for?
Default background and foreground colours for rich text files.
emm
Is it possible to NOT close main window by the ESC please?? :)
Quote from: greenozon on March 29, 2024, 12:59:04 AMIs it possible to NOT close main window by the ESC please??
That will be fixed soon :azn:
Thanks!
Another question (most probably not related to the qeditor but it was in it's output:
*** console link ***
POLINK: warning: Realigned section '.idata$5' in object 'kernel32.lib(kernel32.dll)' (from 4 to 8 byte(s)).
POLINK: warning: Realigned section '.idata$4' in object 'kernel32.lib(kernel32.dll)' (from 4 to 8 byte(s)).
POLINK: warning: Realigned section '.idata$5' in object 'user32.lib(user32.dll)' (from 4 to 8 byte(s)).
POLINK: warning: Realigned section '.idata$4' in object 'user32.lib(user32.dll)' (from 4 to 8 byte(s)).
POLINK: warning: Realigned section '.idata$5' in object 'gdi32.lib(gdi32.dll)' (from 4 to 8 byte(s)).
POLINK: warning: Realigned section '.idata$4' in object 'gdi32.lib(gdi32.dll)' (from 4 to 8 byte(s)).
POLINK: warning: Realigned section '.idata$5' in object 'shell32.lib(shell32.dll)' (from 4 to 8 byte(s)).
POLINK: warning: Realigned section '.idata$4' in object 'shell32.lib(shell32.dll)' (from 4 to 8 byte(s)).
POLINK: warning: Realigned section '.idata$5' in object 'gdiplus.lib(gdiplus.dll)' (from 4 to 8 byte(s)).
POLINK: warning: Realigned section '.idata$4' in object 'gdiplus.lib(gdiplus.dll)' (from 4 to 8 byte(s)).
*** linking ok ***
*** running "C:\masm64\Examples\Simple\controls\controls.exe" ***
*** all is fine ***
Press any key to continue . . .
any hints how to get rid of above warnings, gentlemen?
No such warnings here:
Tabella codici attiva: 65001
["C:\masm64\Examples\Simple\controls\controls.asm"] [] []
Microsoft (R) Windows (R) Resource Compiler Version 10.0.10011.16384
Copyright (C) Microsoft Corporation. All rights reserved.
*** assembling C:\Masm32\JTools\SimpleEditor\Res\tmp_file.asm ***
Microsoft (R) Macro Assembler (x64) Version 14.30.30705.0
Copyright (C) Microsoft Corporation. All rights reserved.
Assembling: C:\Masm32\JTools\SimpleEditor\Res\\tmp_file.asm
*** console link ***
*** linking ok ***
Impossibile trovare il file specificato.
*** running "C:\Masm64\Examples\Simple\controls\controls.exe" ***
*** all is fine ***
was polink tool in use?
Hmmm; tiny li'l detail, but is this just a display bug?
QuoteAssembling: C:\Masm32\JTools\SimpleEditor\Res\\tmp_file.asm
Quote from: greenozon on April 03, 2024, 06:51:51 AMwas polink tool in use?
Yes. But it works also with M$ linkers.
Quote from: NoCforMe on April 03, 2024, 07:36:50 AMRes\\tmp_file.asm
Right, that's a little flaw in two of the batch files. Will be fixed in the next edition..
Strangely enough, the OS has no problem with the extra backslash :rolleyes:
Well, not exactly
eg
C:\Users\user>dir c:\\\\\\\\\
The specified path is invalid.