Hi. I have Irvine book. I want to test some examples in the book. I downloaded the library and wrote this example. I write the code in MASM32 editor. I run my program using MASM32. My system is Windows 7 64-bit. My code file name is test.asm
Here is the code:
This program adds and subtracts 32-bit integers.
include "c:\masm32\include\Irvine32.inc"
includelib "c:\masm32\lib\irvine32.lib"
includelib "c:\masm32\lib\kernel32.lib"
.code
main PROC
mov eax,10000h ; EAX = 10000h
add eax,40000h ; EAX = 50000h
sub eax,20000h ; EAX = 30000h
call DumpRegs ; display registers
exit
main ENDP
END main
After trying to Assemble and Link it, I get the following error:
irvine32.lib <irvine32.obj> : error lnk2001: unresolved external symbol _MessageBoxA@16
test.exe fatal error : LNK1120: 1 unresolved externals
I correctly copied irvine .lib and .inc files in the masm32 include and lib folders.
Please, help me.
what you are missing is kernel32.inc/lib
and, probably be nice to have windows.inc, as well
Kip is a good guy, and his book has merits - he just uses "non-standard" methods
however, it will be easier to learn assembler if you download and install the masm32 package
if your professor expects you to use Kip's library, then so be it
otherwise, it is better to become accustomed to standard ways of doing things
Dave, you're almost right, but it's user32.lib :biggrin:
ieee2, after these lines in the source
include "c:\masm32\include\Irvine32.inc"
includelib "c:\masm32\lib\irvine32.lib"
includelib "c:\masm32\lib\kernel32.lib"
just add this line:
includelib "c:\masm32\lib\user32.lib"
Thanks. The Assemble and Link worked fine after adding:
includelib c:\masm32\lib\user32.lib
But without quotations in all the include lines.
However, when I run, the console window appear and disappear so fast that I am not able to read anything. How can I fix this issue ? though I wrote the code exactly as the first example in Ch3 of the book.
One way would be to call WaitMsg before you exit.
we usually fix that by use of the "inkey" macro (part of the masm32 package)
it waits for any key press before terminating
another way is to open the console window, then run the program by typing the name at the prompt
when you run a console-mode program this way, the console remains after termination
if none of that suits you, you can add your own "AnyKey" function
see the attached program
Hi All,
I have a similar problem when linking this example from the book. I'm seeing the following errors when assembling:
Microsoft Windows [Version 6.2.9200]
(c) 2012 Microsoft Corporation. All rights reserved.
C:\masm32>ml AddSub.asm
Microsoft (R) Macro Assembler Version 6.14.8444
Copyright (C) Microsoft Corp 1981-1997. All rights reserved.
Assembling: AddSub.asm
c:\masm32\lib\Irvine32.lib(1) : error A2008: syntax error : !
c:\masm32\lib\Irvine32.lib(2) : error A2044: invalid character in file
c:\masm32\lib\Irvine32.lib(3) : error A2044: invalid character in file
c:\masm32\lib\Irvine32.lib(3) : error A2039: line too long
c:\masm32\lib\Irvine32.lib(4) : error A2044: invalid character in file
c:\masm32\lib\Irvine32.lib(5) : error A2044: invalid character in file
c:\masm32\lib\Irvine32.lib(6) : error A2044: invalid character in file
c:\masm32\lib\Irvine32.lib(7) : error A2044: invalid character in file
until masm encounters 100 errors then quits. Any ideas? Corrupt library?
Thanks,
Brian
that looks like you have used "include" with a "lib" file
for INC files (which are similar to ASM files), use INCLUDE
for LIB files (which are binary files), use INCLUDELIB
Thanks Dave that was the magic. Can I ask where the 'inkey' macro is located?
Thanks
not sure about Kip's library - or if he even has an "inkey" macro
there is one in the masm32 package - a different library :P
most of the masm32 macros are in
\masm32\macros\macros.asm
EDIT:
Kip has a file named Macros.inc
as far as i can see, it does not have an inkey macro
you can use this function....
;***********************************************************************************************
AnyKey PROC
;Wait for Any Console Key Press - DednDave
;version 1, 12-2011
;version 2, 2-2013
;
; This function returns when any console key is pressed (bKeyDown = 1).
;A possible drawback is that all input event records are removed from
;the console input queue until a key is pressed. In many cases, this is
;not an issue. The virtual key code, virtual scan code, TCHAR character,
;and control key state values are returned in registers.
;Call With: Nothing
;
; Returns: EAX = TCHAR character (high word of EAX = 0)
; ECX = control key state flags
; Bit Name Meaning
; 0 RIGHT_ALT_PRESSED Right ALT key is pressed
; 1 LEFT_ALT_PRESSED Left ALT key is pressed
; 2 RIGHT_CTRL_PRESSED Right CTRL key is pressed
; 3 LEFT_CTRL_PRESSED Left CTRL key is pressed
; 4 SHIFT_PRESSED SHIFT key is pressed
; 5 NUMLOCK_ON NUM LOCK light is on
; 6 SCROLLLOCK_ON SCROLL LOCK light is on
; 7 CAPSLOCK_ON CAPS LOCK light is on
; 8 ENHANCED_KEY Key is enhanced
; EDX:
; low word (DX) = virtual key code
; high word = virtual scan code
;
; all other registers are preserved
;-------------------------------------------------
LOCAL ir :INPUT_RECORD
LOCAL uRecCnt :UINT
LOCAL hStdInp :HANDLE
;-------------------------------------------------
INVOKE GetStdHandle,STD_INPUT_HANDLE
mov hStdInp,eax
.repeat
INVOKE ReadConsoleInput,hStdInp,addr ir,1,addr uRecCnt
movzx ecx,word ptr ir.EventType
mov edx,dword ptr ir.KeyEvent.wVirtualKeyCode
.until (ecx==KEY_EVENT) && (ecx==ir.KeyEvent.bKeyDown) && (dx!=VK_SHIFT) && (dx!=VK_CONTROL) && (dx!=VK_MENU)
movzx eax,word ptr ir.KeyEvent.UnicodeChar
mov ecx,ir.KeyEvent.dwControlKeyState
ret
AnyKey ENDP
;***********************************************************************************************
Thanks for the code snippet Dave. I must be missing something because I can't seem to get any output from the program at all even with things like
AddSub > output or AddSub | more
and when I added your code I get these errors:
Microsoft (R) Macro Assembler Version 6.14.8444
Copyright (C) Microsoft Corp 1981-1997. All rights reserved.
Assembling: C:\masm32\AddSub.asm
C:\masm32\AddSub.asm(57) : error A2006: undefined symbol : UINT
C:\masm32\AddSub.asm(57) : error A2195: parameter or local cannot have void typ
C:\masm32\AddSub.asm(68) : error A2006: undefined symbol : KeyEvent
C:\masm32\AddSub.asm(70) : error A2006: undefined symbol : KeyEvent
Looking at the book the UINT is called an SWORD and the KeyEvent structure seems to be defined somewhere else. Sorry for all the beginner questions but I'm trying to get this working so I can turn in the class homework.
Thanks
I the short term you can equate UINT to a DWORD which is the correct MASM data size.
UINT equ <DWORD>
In the longer term you need to find where Kip defines his data types, probably in an include file.
There is no UINT type declaration in any of the Irvine32 files that I have, but there should be an INPUT_RECORD structure definition in smallwin.inc. It includes only the KeyEvent member but it should be workable.
Thanks for the suggestions. I'll attach the code that finally built for me at the end. Changing UINT to DWORD was fine. The KeyEvent member of the INPUT_RECORD was called Event in smallwin.inc so I changed that. The only remaining issue is that I still get no output. I have a feeling this might be a Windows 8 issue. I start the program from a command prompt and it seems to just return. there is nothing to standard out. If I open the task manager I see the process name running but have a feeling it just forked into the ether with no controlling terminal.
This is frustrating for me as I'll likely have to drop the class since I won't be able to turn in the homework. That being said all the help here has been great. Here's my complete code so that maybe the next poor sucker might have a better result.
TITLE ADD and Subtract (AddSub.asm)
; This program adds and subtracts 32-bit integers.
INCLUDE c:\masm32\include\Irvine32.inc
INCLUDELIB c:\masm32\lib\Irvine32.lib
INCLUDELIB c:\masm32\lib\kernel32.lib
INCLUDELIB c:\masm32\lib\user32.lib
.code
main PROC
mov eax,10000h ; EAX = 10000h
add eax,40000h ; EAX = 50000h
sub eax,20000h ; EAX = 30000h
call DumpRegs
call AnyKey
exit
main ENDP
;***********************************************************************************************
AnyKey PROC
;Wait for Any Console Key Press - DednDave
;version 1, 12-2011
;version 2, 2-2013
;
; This function returns when any console key is pressed (bKeyDown = 1).
;A possible drawback is that all input event records are removed from
;the console input queue until a key is pressed. In many cases, this is
;not an issue. The virtual key code, virtual scan code, TCHAR character,
;and control key state values are returned in registers.
;Call With: Nothing
;
; Returns: EAX = TCHAR character (high word of EAX = 0)
; ECX = control key state flags
; Bit Name Meaning
; 0 RIGHT_ALT_PRESSED Right ALT key is pressed
; 1 LEFT_ALT_PRESSED Left ALT key is pressed
; 2 RIGHT_CTRL_PRESSED Right CTRL key is pressed
; 3 LEFT_CTRL_PRESSED Left CTRL key is pressed
; 4 SHIFT_PRESSED SHIFT key is pressed
; 5 NUMLOCK_ON NUM LOCK light is on
; 6 SCROLLLOCK_ON SCROLL LOCK light is on
; 7 CAPSLOCK_ON CAPS LOCK light is on
; 8 ENHANCED_KEY Key is enhanced
; EDX:
; low word (DX) = virtual key code
; high word = virtual scan code
;
; all other registers are preserved
;-------------------------------------------------
LOCAL ir :INPUT_RECORD
LOCAL uRecCnt :DWORD
LOCAL hStdInp :HANDLE
;-------------------------------------------------
INVOKE GetStdHandle,STD_INPUT_HANDLE
mov hStdInp,eax
.repeat
INVOKE ReadConsoleInput,hStdInp,addr ir,1,addr uRecCnt
movzx ecx,word ptr ir.EventType
mov edx,dword ptr ir.Event.wVirtualKeyCode
.until (ecx==KEY_EVENT) && (ecx==ir.Event.bKeyDown) && (dx!=VK_SHIFT) && (dx!=VK_CONTROL) && (dx!=VK_MENU)
movzx eax,word ptr ir.Event.UnicodeChar
mov ecx,ir.Event.dwControlKeyState
ret
AnyKey ENDP
;***********************************************************************************************
END main
It does not build for me. For an error ML indicates what the error is and where it is.
After changing the includes to match my installation there were two problems:
blobue.asm(60) : error A2006: undefined symbol : HANDLE
blobue.asm(60) : error A2195: parameter or local cannot have void type
blobue.asm(72) : error A2006: undefined symbol : UnicodeChar
>Exit code: 1
Since HANDLE is not defined, you need to replace it with DWORD.
UnicodeChar is being reported as undefined because the union has name:
KEY_EVENT_RECORD STRUCT
bKeyDown DWORD ?
wRepeatCount WORD ?
wVirtualKeyCode WORD ?
wVirtualScanCode WORD ?
UNION uChar
UnicodeChar WORD ?
AsciiChar BYTE ?
ENDS
dwControlKeyState DWORD ?
KEY_EVENT_RECORD ENDS
You can fix this by including the union name in the reference.
my appologies
Kip has a file named "SmallWindows.inc", i believe
he has a short version of windows.inc
in order to use a lot of code in here, you will want to install the masm32 package
if you just want to make that routine work, you need to define the structures
the INPUT_RECORD structure is a union of a few others
in order to use that one, you need to define all of them
there are probably easier ways to go about this - lol
put these at the beginning of the program (or in an include file)
notice, they are only structure definitions, and do not generate any code
i also included the UINT typedef, as Hutch suggested
you may have to add a similar line for HANDLE (also a DWORD)
UINT TYPEDEF DWORD
;----------------------------------------------------
MOUSE_EVENT_RECORD STRUCT
dwMousePosition COORD <>
dwButtonState dd ?
dwControlKeyState dd ?
dwEventFlags dd ?
MOUSE_EVENT_RECORD ENDS
;----------------------------------------------------
KEY_EVENT_RECORD STRUCT
bKeyDown dd ?
wRepeatCount dw ?
wVirtualKeyCode dw ?
wVirtualScanCode dw ?
UNION
UnicodeChar dw ?
AsciiChar db ?
ENDS
dwControlKeyState dd ?
KEY_EVENT_RECORD ENDS
;----------------------------------------------------
WINDOW_BUFFER_SIZE_RECORD STRUCT
dwSize COORD <>
WINDOW_BUFFER_SIZE_RECORD ENDS
;----------------------------------------------------
MENU_EVENT_RECORD STRUCT
dwCommandId dd ?
MENU_EVENT_RECORD ENDS
;----------------------------------------------------
FOCUS_EVENT_RECORD STRUCT
bSetFocus dd ?
FOCUS_EVENT_RECORD ENDS
;----------------------------------------------------
INPUT_RECORD STRUCT
EventType dw ?
alignment db ?,?
UNION
KeyEvent KEY_EVENT_RECORD <>
MouseEvent MOUSE_EVENT_RECORD <>
WindowBufferSizeEvent WINDOW_BUFFER_SIZE_RECORD <>
MenuEvent MENU_EVENT_RECORD <>
FocusEvent FOCUS_EVENT_RECORD <>
ENDS
INPUT_RECORD ENDS
;----------------------------------------------------
Michael's method is shorter, but may leave you wanting, later
ok - i took another look at Kip's include files
it seems that he does have the structures defined
if you "include Irvine32.inc", that file includes SmallWin.inc
SmallWin.inc has them
so - all you should need is HANDLE and UINT
they are both DWORD-sized types
so - you can replace HANDLE and UINT with DWORD
or, add the typedef's
HANDLE TYPEDEF DWORD
UINT TYPEDEF DWORD
you should place them near the beginning of the program, just after the include's/includelib's
Dave,
The Irvine smallwin.inc structure follows the Microsoft declaration:
typedef struct _KEY_EVENT_RECORD {
BOOL bKeyDown;
WORD wRepeatCount;
WORD wVirtualKeyCode;
WORD wVirtualScanCode;
union {
WCHAR UnicodeChar;
CHAR AsciiChar;
} uChar;
DWORD dwControlKeyState;
} KEY_EVENT_RECORD, *PKEY_EVENT_RECORD;
And in C/C++ (or any language where the header files follow the Microsoft declaration) the union name is required to access the union members:
#include <windows.h>
#include <stdio.h>
#include <conio.h>
void main( void )
{
KEY_EVENT_RECORD ker;
// ker.AsciiChar = 'X';
// CL:
// error C2039: 'AsciiChar' : is not a member of '_KEY_EVENT_RECORD'
// C:\Program Files\Microsoft Platform SDK\Include\WinCon.h(41) :
// see declaration of '_KEY_EVENT_RECORD'
// GCC:
// error: 'KEY_EVENT_RECORD' has no member named 'AsciiChar'
// But this works as expected:
ker.uChar.AsciiChar = 'X';
printf("%c\n", ker.uChar.AsciiChar);
getch();
}
A structure that does not conform to the published and widely distributed Microsoft documentation is a hidden problem that anyone using the structure, and the Microsoft documentation as a reference, will have to deal with at least once.
I have been compiling a list of such structures in the MASM32 windows.inc, and this makes 6 so far.
There seems to be online help for Irvine lib here (http://programming.msjc.edu/asm/help/)
Thanks again for all the help on this. Is anyone able to get console or terminal output for the program? As I said, I have my suspicions that my output issue might be related to windows 8 permissions or terminal model issues. I'll give it a little more effort today before I throw in the towel.
Thanks
Are you building it as a console app (/subsystem:console)?
ok - going back to the original post of this thread.....
i wanted to see if i could make it work without using the masm32 package :P
so, i went to Kip's site and downloaded the VS2005 version of his library with examples
http://www.kipirvine.com/asm/examples/index.htm (http://www.kipirvine.com/asm/examples/index.htm)
i removed the double quotes from the includes to assemble the program
you may have to adjust the inc/lib paths to suit your needs
it gave me an unresolved external message with a decorated name
that told me that the library was missing from the source - user32.lib
include Irvine32.inc
includelib Irvine32.lib
includelib kernel32.lib
includelib user32.lib
.code
main PROC
mov eax,10000h ; EAX = 10000h
add eax,40000h ; EAX = 50000h
sub eax,20000h ; EAX = 30000h
call DumpRegs ; display registers
call WaitMsg ; wait for a keypress
exit
main ENDP
END main
to assemble...
ml /c /coff test.asm
link /SUBSYSTEM:CONSOLE test.obj
notice that some of the switches are case-sensitive
the output....
EAX=00030000 EBX=7FFD4000 ECX=0012FFB0 EDX=7C90E514
ESI=00000000 EDI=00000010 EBP=0012FFF0 ESP=0012FFC4
EIP=00401014 EFL=00000206 CF=0 SF=0 ZF=0 OF=0 AF=0 PF=1
Press any key to continue...
EDIT:
i looked a little further, and i see that Kip has a routine named "WaitMsg", which is like our inkey macro
i added that to the source above
Thanks all! That works beautifully. I missed the linker option to create a console program. That's a big difference coming from UNIX coding. Thanks Microsoft!
Though I'm novice in the field of assembly, I have Kip R.Irvine's assembly book and want to follow this source code example on MASM32 editor
[ My computer's operation system is Windows 7 professional and using MASM32 SDK Version 11 currently. I supercited below code and made a main.asm file on MASM32 subdirectory of C drive(c:\MASM32)].
Whenever I select Assemble&Link option from Project tab,It shows building result of console windows questionless but Whenever I select run program option,There is no response at all.
[Even in console windows(select cmd prompt from file tab), Main.exe execution show no response.]
TITLE This program adds and subtracts 32-bit integers.
include C:\irvine\Irvine32.inc
includelib C:\irvine\irvine32.lib
includelib c:\masm32\lib\kernel32.lib
includelib C:\irvine\user32.lib
.code
main PROC
mov eax,10000h ; EAX = 10000h
add eax,40000h ; EAX = 50000h
sub eax,20000h ; EAX = 30000h
call DumpRegs ; display registers
exit
main ENDP
END main
But strangely, Whenever I type below assemble building code on console windows(selecting Cmd Prompt or shortcut key Ctrl+D) ,then Select run program from project tab or Execute main.exe on console windows, Both of two execution method normally shows register output.
ml /c /coff main.asm
link /SUBSYSTEM:CONSOLE main.obj
It is out of the question for me Why it won't be executed Whenever I build asm file with Assemble&Link option .
Is there anyone who know what cause this irritating build disorder and Let me know How I can fix this problem?
I'm sorry My poor English may cause you some[/size][/font] kind of misunderstand and Thanks in advance. :bgrin:
Hello chth96, welcome,
Use Console Assemble & Link, farther down on the same menu
Quote from: rrr314159 on February 22, 2015, 10:52:27 PM
Hello chth96, welcome,
Use Console Assemble & Link, farther down on the same menu
Thanks very much for your reply! It works perfectly.I seems to have overlooked that There is console Assemble & Link option.
BTW,What is crucial difference between "Console Assemble & Link option" and primary Assemble & Link?
It uses this link option:
link /SUBSYSTEM:CONSOLE yourprog.obj
Use the other one when you don't want a console, e.g. Windows program. That's why it worked when you typed the lines into the cmd window.
c u later ...
Thanks you again for your confirmation reply. :t
I noticed that MASM32 classify build type into two options(windows and cmd console mode),and It is very unfamiliar for me who are accustomed to MS Visual basic which provide only one building and execute.
Anyway,now I tried to accustom myself to Ollydbg debugger in order to observe Flag and stack and value of memory address during Real-time execution of given source code.
I hope that you don't mind me If I happen to asking much of basic instructions about MASM32 which might seems like needless question on your end.
chth96:
QuoteI hope that you don't mind me If I happen to asking much of basic instructions about MASM32 ...
Certainly I don't mind at all, ask away. But I hope that you don't mind me If I happen to not answer :biggrin:
Quote...which might seems like needless question on your end.
I was tripped up also by that menu. I saw "Assemble & Link" and figured that's what I wanted ... that "console a&l" was some advanced option ... took me a while to figure it out.
Quotenow I tried to accustom myself to Ollydbg debugger in order to observe Flag and stack and value of memory address during Real-time execution of given source code.
Actually I find WinDbg easier to deal with. Olly has various advanced options, e.g. a lot of stuff to do with Windows function calls, that I don't care about ... I don't want all the info displayed, takes up 2 much real estate on the screen, and usually I need only a register value or a few lines disassembly ... but everybody loves it, so probably u will too.
Good luck, c u later!
Hey yall - sorry to intrude but didnt wany to start a topic since I'm trying to get theings working too
I'm having trouble with BeginPaint, specifically PAINTSTRUCT is unrecognized when I try to set up my local variable of that type.
Is there anything like a struct.inc for masm or can it be found somewhere else?
(I can define it myself but I'd rather get into the swing or doing things right.)
John.
PAINTSTRUCT is defined in Windows.inc
One line is sufficient:
include \masm32\include\masm32rt.inc
Jochen forgot to mention....
open the file \masm32\include\masm32rt.inc - it's a plain text file
see what it adds for you
you won't need the processor, model, etc