TVector problem?

[HSE]

Hi Biterider!

Look like there is a problem in InsertAt method:

Code Select Expand

    OCall xbx::DWordVector.Insert, 15
    OCall xbx::DWordVector.Insert, 14
    -----------------------------------
    OCall xbx::DWordVector.InsertAt, 0, 15
    OCall xbx::DWordVector.InsertAt, 0, 14


Code Select Expand

Test DWordVector
──────────────────────────────────────────────────────────────────────
esi = 0
DWORD ptr [xax] = 15
esi = 1
DWORD ptr [xax] = 14
──────────────────────────────────────────────────────────────────────
esi = 0
DWORD ptr [xax] = 14
esi = 1
DWORD ptr [xax] = -144682624

Thanks in advance, HSE.

[Biterider]

Hi Hector
Thanks for the testbed code.
You are right 
I put the value assignment line in the wrong place.
I have attached the corrected version of TVector.inc.

Looking into

Code Select Expand

.for (esi = 0 : esi != [xbx].$Obj(DWordVector).dCount : esi++)
  DbgDec esi
  OCall xbx::DWordVector.ItemAt, esi
  DbgDec DWORD ptr [xax]
.endforit works perfectly fine!

It could also be written like this

Code Select Expand

.VecForEach [xbx].$Obj(DWordVector), esi
  DbgDec esi
  DbgDec DWORD ptr [xax]
.VecNextwhich is a bit more efficient, since it does not call .ItemAt

An alternative using implicit indexing is

Code Select Expand

.VecForEach [xbx].$Obj(DWordVector)
  DbgDec DWORD ptr [xax]
.VecNext
Looking at the disassembly, I discovered an instruction that can be omitted. This little optimisation is implemented in the attached file.

Regards, Biterider

[HSE]

Hi Biterider!

 Perfect now

Thanks, HSE