Vararg in Colletion::ForEach

[HSE]

Hi Biterider!

Not so elegant but look like in 32 bits this is going to work:

Code Select Expand

Method CollectionV.ForEach, uses xbx xdi xsi, pActionProc:POINTER, xArg1:VARARG
  local dires[25]:POINTER
  local store: XWORD
  ArgReg pActionProc:rdx

    dec xax
    mov store, xax
    test xax,xax
    jmp loop1b 
loop1:
        mov xcx, [esp+xax*@WordSize+28+25*4]
        mov dires[xax*@WordSize], xcx
        dec xax
loop1b:   
    jnz loop1
   
    SetObject xcx
    mov xdi, $ArgReg(pActionProc)
    mov ebx, [xcx].dCount
    mov xsi, [xcx].pItems
    ReleaseObject
   
    test ebx, ebx
    jmp loop0b
loop0a:
        mov xax, store
        test xax,xax
        jmp loop2b
    loop2:
             push dires[xax*@WordSize]
             dec xax
    loop2b:
        jnz loop2
       
        push [xsi]
        call PColProc ptr xdi
        mov xax, store
        shl xax, 2
        add xax, 4
        sub esp, xax
        add xsi, sizeof(POINTER)                            ;xsi -> Next item in the collection
        dec ebx
loop0b:
    jnz loop0a
MethodEnd

Regards, HSE.

[Biterider]

Hi HSE
I think it will work in 32bit. 
In 64bit the task is much more complicated, with many more instructions and therefore more CPU cycles to transfer the arguments, that I'm not sure it's wise to go that way. 
But as always, this has to be proven first, it is only a guess.

Biterider

[HSE]

In 64bit the task is much more complicated, with many more instructions and therefore more CPU cycles to transfer the arguments, that I'm not sure it's wise to go that way.