ObjAsm Tools

[HSE]

Hi Biterider|

Setup is perfect now 

Code Select Expand

Utilizar anotaciones
Las modificaciones tienen efecto en las ventanas nuevas
Seleccionar el idioma de la aplicación


[Biterider]

Hi JJ, HSE
Thanks for testing. I think everything works now. 
I hope this tool will help us to find the most common programming problems.


I'll keep the download up for a few more days and then integrate the tool into the OA package.


Regards, Biterider

[sinsi]

Is this specific to ObjAsm only or any MASM source?

Working...
ERROR: possibly unpreserved register(s) detected.
  Code block:  desktopinit (106)
  Register(s): ebx esi

Code Select Expand


desktopinit proc public uses ebx esi pst:PTR IStream


[Biterider]

Hi Sinsi
I'm not able to find something wrong here. 
I'm testing with

Code Select Expand

desktopinit proc public uses ebx esi pst:PTR IStream
  push ebx
  pop esi
  ret
desktopinit endp

Make sure you habe selected 32 bit code in the setup dialog (press F2 for quick access). A wrong setting here may produce this message.
If the setting is correct, can you send me or post the whole file that contains this procedure?

Thank you!
Biterider

[sinsi]

OK, the problem seems to be the case used

Code Select Expand


MyProc proc uses ebx ;lower case
    xor ebx,ebx      ;matching case, no problem
    ret
MyProc endp

MyOtherProc proc USES EBX ;upper case
    xor ebx,ebx           ;lower case, triggers warning
    ret
MyOtherProc endp


ERROR: possibly unpreserved register(s) detected.
  Code block:  MyOtherProc (10)
  Register(s): ebx
Working
WARNING: possibly unnecessary register preservation detected.
  Code block:  MyOtherProc (10)
  Register(s): EBX

One other small complaint, having to load the file every time to check it.

[jj2007]

OK, the problem seems to be the case used

Right, the tool should issue a warning "lousy and inconsistent coding style"

One other small complaint, having to load the file every time to check it.

True. CommandLineToArgvW and WM_DROPFILES (DragQueryFile, DragFinish) are your friends.

[Biterider]

Hi Sinsi

MyOtherProc proc USES EBX

That was a good one. Thank your for investigating the issue. 
It was easy to correct. A new version can be downloaded (build 79).

One other small complaint, having to load the file every time to check it.

I'm not sure if you tried the child window context menu. It has 2 items to open the analysed file and to recheck it.

Regards, Biterider

[Biterider]

Hi JJ

Right, the tool should issue a warning "lousy and inconsistent coding style"

I agree with you 

CommandLineToArgvW and WM_DROPFILES

Dropping files dosn't make much sense atm, since you have to trigger the check type from the menu. 
Command line arguments may be a good option. 

Some questions remain for this operation mode:
- single file analysis or batch mode?
- output to window or console?

Regards, Biterider

[LiaoMi]

Dropping files dosn't make much sense atm, since you have to trigger the check type from the menu. 

It would be convenient if a single window with the choice of architecture appears when dragging a file 

[Biterider]

Hi JJ, LiaoMi
I took LiaoMis idea and implemented the code to drop files into the application. 

The new release (build 80) can be downloaded.

Regards, Biterider

[HSE]

Hi Biterider!

I added a few lines before CheckRegInSentence:

Code (OA_Tools_Checks.inc) Select Expand

    invoke StrCICompA, pWordStart, offset szUsing, dWordSize
    .if eax == 0
        GetRegisters
        jmp @@NextLine   
    .endif

    CheckRegInSentence

Then tool can deal with current Masm64 SDK register preservation:

Code Select Expand

    USING rbx,rsi,rdi,r12

Regards, HSE.

[Biterider]

Added, thanks 

Biterider

[greenozon]

Hi Biterider!
could you please update the valid download link in the 1st post?
right now it gives 404...

[Biterider]

Hi greenozon
The zip from the first post no longer exists, so I've replaced it with links to the repo where you can download the latest version.

Regards, Biterider