Code to align to 32 bits

[NoCforMe]

Small li'l tidbit here: in my current program I needed to align some data to a 32-bit (DWORD) boundary. I'm dealing with BMP bitmaps here and needed to determine the padding necessary for lines that didn't fall on such a boundary.

I came up with the following code:

Code Select Expand

      MOV    EAX, <line length>
      NEG    EAX                       ;Flip bits arithmetically
      AND    EAX, 11B                  ;Isolate 2 low bits
      MOV    padding, EAX              ;and Bob's your uncle

which works out to:

Code Select Expand

   length AND 11B   padding
          0            0
          1            3
          2            2
          3            1

I actually figured this out myself. I know there are other ways to skin this particular cat, and maybe even some cleverer ones. (Would it be possible to do it in only two instructions?) So I'm wondering what other methods people have come up with.

Micro$oft has this tricky technique that I still haven't quite figured out how it works:

Code Select Expand

    pbmi->bmiHeader.biSizeImage = ((pbmi->bmiHeader.biWidth * cClrBits + 31) & ~31) /8
                                  * pbmi->bmiHeader.biHeight;


[Vortex]

Hi NoCforMe,

Reading your code from this message :

Code Select Expand

; Calculate actual bitmap size including any needed padding:
    MOV    EAX, BMPwidth
    MUL    BMPbpp
    ADD    EAX, 31
    AND    EAX, NOT 31
    SHR    EAX, 3
    MUL    BMPheight
    MOV    actualBMPsize, EAX
https://masm32.com/board/index.php?msg=126368

Code Select Expand

;  Bitmap size = (( BITMAPINFO.bmiHeader.biWidth * BITMAP.bmPlanes * BITMAP.bmBitsPixel + 31 ) & ~31 ) / 8
;                 * BITMAPINFO.bmiHeader.biHeight

;  ~31 = NOT 31 = NOT 00011111 = 11100000

;  NOT 00011111 = 11100000 => -32


The count of bits is aligned to the next 32-bit boundry. ( +31 trick )

This line does the 32-bit alignment :

Code Select Expand

    AND    EAX, NOT 31  ;  AND EAX,-32
A quick test :

Code Select Expand

Test 1
x=0  ,  x AND -32 = 0
x=1  ,  x AND -32 = 0
x=2  ,  x AND -32 = 0
x=3  ,  x AND -32 = 0
x=4  ,  x AND -32 = 0
.
.
x=29  ,  x AND -32 = 0
x=30  ,  x AND -32 = 0
x=31  ,  x AND -32 = 0
x=32  ,  x AND -32 = 32
x=33  ,  x AND -32 = 32
x=34  ,  x AND -32 = 32
.
.
x=62  ,  x AND -32 = 32
x=63  ,  x AND -32 = 32
x=64  ,  x AND -32 = 64
x=65  ,  x AND -32 = 64
x=66  ,  x AND -32 = 64
x=67  ,  x AND -32 = 64

Test 2
x=0  ,  (x+31) AND -32 = 0
x=1  ,  (x+31) AND -32 = 32
x=2  ,  (x+31) AND -32 = 32
x=3  ,  (x+31) AND -32 = 32
x=4  ,  (x+31) AND -32 = 32
.
.
x=29  ,  (x+31) AND -32 = 32
x=30  ,  (x+31) AND -32 = 32
x=31  ,  (x+31) AND -32 = 32
x=32  ,  (x+31) AND -32 = 32
x=33  ,  (x+31) AND -32 = 64
x=34  ,  (x+31) AND -32 = 64
.
.
x=62  ,  (x+31) AND -32 = 64
x=63  ,  (x+31) AND -32 = 64
x=64  ,  (x+31) AND -32 = 64
x=65  ,  (x+31) AND -32 = 96
x=66  ,  (x+31) AND -32 = 96
x=67  ,  (x+31) AND -32 = 96


[sinsi]

The count of bits is aligned to the next 32-bit boundry. ( +31 trick )

This line does the 32-bit alignment :

Code Select Expand

Code Select Expand

    AND    EAX, NOT 31  ;  AND EAX,-32

Isn't that 32 byte alignment?

Code Select Expand

;EAX has an address
  add eax,3
  and eax,not 3


[Windows 10]

Isn't that 32 byte alignment?

  this made me chuckle.
So does the OP need 32 bit alignment, or 32 byte alignment? A big difference. I think I know the answer. 

[NoCforMe]

So my way is simpler. I win!

(This technique could be adapted for 32-byte alignment.)

Not this:

Reading your code from this message :

Code Select Expand

; Calculate actual bitmap size including any needed padding:
    MOV    EAX, BMPwidth
    MUL    BMPbpp
    ADD    EAX, 31
    AND    EAX, NOT 31
    SHR    EAX, 3
    MUL    BMPheight
    MOV    actualBMPsize, EAX
https://masm32.com/board/index.php?msg=126368

Yikes; my old code comes back to haunt me ...

[Vortex]

Hello,

Same method used to align the stack inside a procedure ( 64-bit coding ) :

Code Select Expand

and rsp,-16

[sinsi]

Hello,

Same method used to align the stack inside a procedure ( 64-bit coding ) :

Code Select Expand

and esp,-16

That would clear the high 32 bits of RSP though...ouch

Code Select Expand

and rsp,-16
and sp,-16
and spl,-16


[Vortex]

Hi Sinsi,

Sorry for the typo, statement corrected above : and rsp,-16

[mineiro]

So my way is simpler. I win!

What did you get? More ego?
Next time, stop posting lots of messages with technical errors, this is for you and zedd151. Waiting for the "gang of 4" to come and protect members of the bubble, but not criticize him as they have done in the past. So, to be fair and honest, I'm here.
A simple topic, just see in binary and see patterns. An and with 1111 will do the rest, wow,. For a person who owns an oscilloscope this would be trivial,...

[NoCforMe]

So my way is simpler. I win!

What did you get? More ego?

It was a, it was a, a joke, son.
What, do I have to use smileys to indicate that?

Next time, stop posting lots of messages with technical errors, this is for you and zedd151. Waiting for the "gang of 4" to come and protect members of the bubble, but not criticize him as they have done in the past. So, to be fair and honest, I'm here.
A simple topic, just see in binary and see patterns. An and with 1111 will do the rest, wow,. For a person who owns an oscilloscope this would be trivial,...

What technical errors did I commit here? None that I can see.

I like my method, and it seems to be simpler than the other ones I've seen.

Those patterns you mention aren't obvious to me.
And what does an oscilloscope have to do with it? I'm curious, because I do own one (an old Tektronix). How can this be used to illustrate bit alignment?

[mineiro]

does an oscilloscope have to do with it? I'm curious,

Square waves? I'm wasting my time.

[NoCforMe]

OK, what specifically about square waves? I'm quite familiar with them, but have no idea what you're getting at here.

[Windows 10]

Next time, stop posting lots of messages with technical errors, this is for you and zedd151.

???
What are you even talking about? 

"gang of four"?
Gang of Four - CCP
I am not now, or have I ever been, a member of the Chinese communist party.    I do own Chinese products though, of varying quality. 

Or did you mean "gang of four" design patterns?
Gang of Four - Design Patterns
I have no clue what that is, I googled and it was one of the responses, besides the one mentioned above. 

[NoCforMe]

That's what I'm trying to figure out.
Maybe they had too much to drink.

[TimoVJL]

What is Data Alignment?