Custom procedure question

[Landsfiskalen]

Hi all!
If I want to create a custom procedure, am I going about it the correct way if I do like this?

Code Select Expand


DisableCtrls proto :BOOL

....

invoke DisableCtrls,0

....

DisableCtrls proc Enabled:BOOL
invoke EnableWindow,hButton,Enabled;
DisableCtrls endp


Right now it crashes when I call the procedure with the invoke command.

Any help would be greatly appreciated!

[fearless]

This is how i might do this:

Code Select Expand

EnableCtrls proto :DWORD

....

invoke EnableCtrls, TRUE ; TRUE for enable, FALSE for disable - changed name of function for better understanding of function based on api call below

....

EnableCtrls proc dwEnabledOrDisable:DWORD
   invoke EnableWindow, hButton, dwEnabledOrDisable ; last param uses TRUE or FALSE based on win32 documentation, so easier to stick with that for our parameter.
   ret ; need return here when coming back out of function, otherwise it might run on into some other function below it
EnableCtrls endp

[Landsfiskalen]

Cheers! Looks way nicer than my attempt. :) I was missing the ret in the proc... Doh!

This is how i might do this:

Code Select Expand

EnableCtrls proto :DWORD

....

invoke EnableCtrls, TRUE ; TRUE for enable, FALSE for disable - changed name of function for better understanding of function based on api call below

....

EnableCtrls proc dwEnabledOrDisable:DWORD
   invoke EnableWindow, hButton, dwEnabledOrDisable ; last param uses TRUE or FALSE based on win32 documentation, so easier to stick with that for our parameter.
   ret ; need return here when coming back out of function, otherwise it might run on into some other function below it
EnableCtrls endp

[dedndave]

i rarely use BOOL types, because they're a little confusing
if you look in windows.inc...

Code Select Expand

bool                        typedef BYTE
BOOLEAN                     typedef BYTE
BOOL                        typedef DWORD

looks like an accident waiting to happen

[Landsfiskalen]

Yikes! What do you recommend using instead, Dave? Byte or DWORD?

i rarely use BOOL types, because they're a little confusing
if you look in windows.inc...

Code Select Expand

bool                        typedef BYTE
BOOLEAN                     typedef BYTE
BOOL                        typedef DWORD

looks like an accident waiting to happen

[dedndave]

well - you don't want to use BYTE - the stack should always be 4-aligned for 32-bit code
DWORD is probably the best choice in this case

[Landsfiskalen]

Ah, true, true. Works like a charm now.  :t

well - you don't want to use BYTE - the stack should always be 4-aligned for 32-bit code
DWORD is probably the best choice in this case