News:

Masm32 SDK description, downloads and other helpful links
Message to All Guests
NB: Posting URL's See here: Posted URL Change

Main Menu

Toolbar bitmap creator

Started by NoCforMe, September 23, 2023, 11:42:39 AM

Previous topic - Next topic

NoCforMe

OK, took a look at my palette editing code and found at least a potential problem. I'm going to try to read your mind, Biterider, and say that what you did was click on a palette entry (either in the righthand listbox or by clicking on the palette display), then choosing "Edit palette entry", and then you changed the length from half (8) to full (16). Doing so would indeed cause a serious error.

I fixed it so that you can't do this: if you're editing a half-length palette entry and the palette is full (there's not room to expand this entry from half to full), I simply disable the "full" radio button. Does that sound like what happened?

The problem is that there's only room for 256 palette elements (DWORDs), and if you try to define any more than that you run into inaccessible memory. So there's a bunch of code to make sure this doesn't happen; it was left out of the editing code in that dialog.

This shows just a little bit of the complexity of the user interface here, which has many interlocking parts depending on the value or setting of certain data items.

Glad you found this bug!
Assembly language programming should be fun. That's why I do it.

Biterider

Quote from: NoCforMe on October 25, 2023, 06:05:35 AMand then you changed the length from half (8) to full (16).
Yes, I did that too.

Biterider

NoCforMe

I owe you one (beer, cocktail, joint) for doing my alpha testing for me!
Assembly language programming should be fun. That's why I do it.

Biterider


NoCforMe

New version w/problem found by Biterider fixed. This one's linked with debug info so if it crashes you should be able to see useful stuff.

Let me know, any suggestions, bugs (gawd forbid!), etc.
Assembly language programming should be fun. That's why I do it.