Author Topic: JWasm212 fixed TYPE  (Read 20020 times)

habran

  • Member
  • *****
  • Posts: 1228
    • uasm
JWasm212 fixed TYPE
« on: April 23, 2015, 08:25:31 PM »
Hello  mortals :biggrin:
long time no see, sorry... busy ;)
rrr314159 tanks for pointing out a TYPE error :t

the error was here:
Code: [Select]
parser.h

// values for sflags if register
enum op1_flags {
    SFR_SIZMSK  = 0x1F, /* size in bits 0-4 */
    SFR_IREG    = 0x20,
    SFR_SSBASED = 0x40, /* v2.11: added */
    SFR_YMMMASK = 0x3f, /* added by habran */
};

parser.c

int SizeFromRegister( int registertoken )
/***************************************/
{
    unsigned flags;
    if (((registertoken >= T_YMM0) && (registertoken <= T_YMM7 ))||
      ((registertoken >= T_YMM8) && (registertoken <= T_YMM15 )))
      flags = GetSflagsSp( registertoken ) & SFR_YMMMASK ;   //added by habran
   
    else
      flags = GetSflagsSp( registertoken ) & SFR_SIZMSK;

    if ( flags )
        return( flags );

    flags = GetValueSp( registertoken );
    if ( flags & OP_SR )
        return( CurrWordSize );

    /* CRx, DRx, TRx remaining */
#if AMD64_SUPPORT
    return( ModuleInfo.Ofssize == USE64 ? 8 : 4 );
#else
    return( 4 );
#endif
}
here is a fixed binary version
P.S.
Still working on AVX512 8)
Cod-Father

TWell

  • Member
  • ****
  • Posts: 743
Re: JWasm212 fixed TYPE
« Reply #1 on: April 23, 2015, 08:37:55 PM »
can you give that 32-bit version too?

habran

  • Member
  • *****
  • Posts: 1228
    • uasm
Re: JWasm212 fixed TYPE
« Reply #2 on: April 23, 2015, 09:12:39 PM »
Certainly TWell :biggrin:
my second name is CANDO ;)
Cod-Father

Gunther

  • Member
  • *****
  • Posts: 4196
  • Forgive your enemies, but never forget their names
Re: JWasm212 fixed TYPE
« Reply #3 on: April 24, 2015, 02:17:28 AM »
Hi Habran,

special thanks. Have you heard something of Andreas? What is with the other OS (DOS, Linux, BSD, OS/2)?

Gunther
You have to know the facts before you can distort them.

habran

  • Member
  • *****
  • Posts: 1228
    • uasm
Re: JWasm212 fixed TYPE
« Reply #4 on: April 24, 2015, 06:22:24 AM »
Hi Gunther, you welcome
Keine Ahnung where is Andreas :icon_eek:
I am afraid of the worst  :(
Quote
What is with the other OS (DOS, Linux, BSD, OS/2)?
I can build only for windows
In the attached folder there are three files I changed, so if you are able to build them you are welcome
Cod-Father

Gunther

  • Member
  • *****
  • Posts: 4196
  • Forgive your enemies, but never forget their names
Re: JWasm212 fixed TYPE
« Reply #5 on: April 24, 2015, 11:11:05 PM »
Hi Habran,

I can build only for windows
In the attached folder there are three files I changed, so if you are able to build them you are welcome

I'll try it for DOS and Unix. I've to check the build scripts by Andreas. OS/2 is a bit tricky, because I have only an old OS/2 Warp 4 original CD here and could try to build it in a Virtual Machine. I'm not sure if that's sufficient.

Gunther
You have to know the facts before you can distort them.

anta40

  • Member
  • ***
  • Posts: 315
Re: JWasm212 fixed TYPE
« Reply #6 on: April 25, 2015, 03:08:18 AM »
Hi habran,

Are the changes based on the latest jwasm code by Japheth?

Gunther

  • Member
  • *****
  • Posts: 4196
  • Forgive your enemies, but never forget their names
Re: JWasm212 fixed TYPE
« Reply #7 on: April 25, 2015, 03:27:46 AM »
Hi anta40,

Are the changes based on the latest jwasm code by Japheth?

I think so. But Habran made a lot of changes to implement for example  AVX and AVX2.

Gunther
You have to know the facts before you can distort them.

habran

  • Member
  • *****
  • Posts: 1228
    • uasm
Re: JWasm212 fixed TYPE
« Reply #8 on: April 25, 2015, 05:53:55 AM »
>anta40 Yes, JWasm212s_140105
>Gunther I am adamant that you will do your best :t
Cod-Father

rrr314159

  • Member
  • *****
  • Posts: 1378
Re: JWasm212 fixed TYPE
« Reply #9 on: April 25, 2015, 02:04:37 PM »
Hi Habran,

thanks for the fix makes life a little easier. Someday I'll learn how to fix JWasm myself, can't count on you mortals being around forever ;)
I am NaN ;)

habran

  • Member
  • *****
  • Posts: 1228
    • uasm
Re: JWasm212 fixed TYPE
« Reply #10 on: April 25, 2015, 02:41:56 PM »
Hi rrr314159 :biggrin:
It is my pleasure to make you grumpy old people happy ;)
Quote
Someday I'll learn how to fix JWasm myself
Yeah, if you want the job done properly, do it yourself :lol:
Quote
can't count on you mortals being around forever ;)
mortals is my invention, so I am excluded 8)
Cod-Father

FORTRANS

  • Member
  • *****
  • Posts: 1235
Re: JWasm212 fixed TYPE
« Reply #11 on: April 26, 2015, 12:28:25 AM »
Hi Gunther,

OS/2 is a bit tricky, because I have only an old OS/2 Warp 4 original CD here and could try to build it in a Virtual Machine. I'm not sure if that's sufficient.

   If you need some (minor) help, I have working OS/2 systems
in use here.  Do you have a preferred virtual environment?

   You could look at eCS or Warpstock Europe for current items
related to OS/2 as well.

Regards,

Steve N.

Gunther

  • Member
  • *****
  • Posts: 4196
  • Forgive your enemies, but never forget their names
Re: JWasm212 fixed TYPE
« Reply #12 on: April 26, 2015, 03:49:36 AM »
Hi Steve,

   If you need some (minor) help, I have working OS/2 systems
in use here.  Do you have a preferred virtual environment?

good to know. I would prefer VirtualBox or VMware Player, because I've no experiences with Quemu and Virtual PC from MS doesn't work with Windows 8 and above, I think.

Gunther
You have to know the facts before you can distort them.

jj2007

  • Member
  • *****
  • Posts: 13944
  • Assembly is fun ;-)
    • MasmBasic
Re: JWasm212 fixed TYPE
« Reply #13 on: May 05, 2015, 10:26:56 PM »
my second name is CANDO ;)

Hi Cando,

Just tested version 23 April on my latest RichMasm (16k lines) and MB (25k) sources, and it works absolutely fine - great compliment :t

Given that Andreas seems to have abandoned the project, we are really lucky that you maintain it - thanks a lot :icon14:

Jochen

habran

  • Member
  • *****
  • Posts: 1228
    • uasm
Re: JWasm212 fixed TYPE
« Reply #14 on: May 05, 2015, 10:50:54 PM »
Thanks Jochen :t
Cod-Father